Added some updateComplete calls to make the tests more stable

Signed-off-by: Dennis Labordus <[email protected]>

Author: Dennis Labordus

src/Logging.ts

@@ -148,22 +148,21 @@ export function Logging<TBase extends LitElementConstructor>(Base: TBase) {
       };
     }
 
-    private async onLoadHistoryFromDoc(event: OpenDocEvent) {
-      if (event.detail && event.detail.doc) {
-        const doc = event.detail.doc;
-        Array.from(
-          doc.querySelectorAll(':root > Header > History > Hitem')
-        ).forEach(historyItem => {
-          this.history.push(
-            this.createSclHistoryEntry(
-              historyItem.getAttribute('who'),
-              historyItem.getAttribute('what'),
-              historyItem.getAttribute('why'),
-              historyItem.getAttribute('when')
-            )
-          );
-        });
-      }
+    private onLoadHistoryFromDoc(event: OpenDocEvent) {
+      const doc = event.detail.doc;
+
+      Array.from(
+        doc.querySelectorAll(':root > Header > History > Hitem')
+      ).forEach(historyItem => {
+        this.history.push(
+          this.createSclHistoryEntry(
+            historyItem.getAttribute('who'),
+            historyItem.getAttribute('what'),
+            historyItem.getAttribute('why'),
+            historyItem.getAttribute('when')
+          )
+        );
+      });
     }
 
     private onIssue(de: IssueEvent): void {

src/compas/CompasSession.ts

@@ -139,7 +139,7 @@ export class CompasSessionExpiredDialogElement extends LitElement {
                   translateUnsafeHTML('compas.session.explainExpiredWithProject',
                                         {expiredSessionMessage: expiredSessionMessage}) }
         </div>
-        ${(this.doc != null) ?
+        ${(this.doc !== null) ?
              html `<mwc-button slot="primaryAction"
                                @click=${() => this.save()}
                                ?disabled=${this.doc == null}>
@@ -221,7 +221,7 @@ export async function retrieveUserInfo(): Promise<void> {
   await CompasUserInfoService().getCompasUserInfo()
     .then(response => {
       const name = response.querySelectorAll("Name").item(0)?.textContent;
-      if (name != null) {
+      if (name !== null) {
         dispatchEventOnOpenScd(newUserInfoEvent(name));
       }
 

test/integration/validators/ValidateTemplates.test.ts

@@ -45,6 +45,7 @@ describe('ValidateTemplates OpenSCD integration test ', () => {
     }).timeout(1000);
     it('pushes issues to the diagnostics pane that look like the latest snapshot', async () => {
       await parent.requestUpdate();
+      await parent.updateComplete;
       await expect(parent.diagnosticUI).to.equalSnapshot();
     });
   });
@@ -80,6 +81,7 @@ describe('ValidateTemplates OpenSCD integration test ', () => {
     }).timeout(1000);
     it('pushes a specific issue to the diagnostics pane that look like the latest snapshot', async () => {
       await parent.requestUpdate();
+      await parent.updateComplete;
       await expect(parent.diagnosticUI).to.equalSnapshot();
     });
   });

test/unit/menu/UpdateDescriptionSEL.test.ts

@@ -22,11 +22,14 @@ describe('Update method for desc attributes in SEL IEDs', () => {
     parent = await fixture(html`
       <open-scd><update-description-sel></update-description-sel></open-scd>
     `);
+    await parent.requestUpdate();
+    await parent.updateComplete;
 
     element = <UpdateDescriptionSel>(
       parent.querySelector('update-description-sel')!
     );
     await element.requestUpdate();
+    await element.updateComplete;
 
     editorAction = spy();
     window.addEventListener('editor-action', editorAction);
@@ -56,6 +59,7 @@ describe('Update method for desc attributes in SEL IEDs', () => {
 
       element.processSignalList(signalList);
       await parent.requestUpdate();
+      await parent.updateComplete;
     });
 
     it('cannot find any desc fields to update', async () => {
@@ -82,6 +86,7 @@ describe('Update method for desc attributes in SEL IEDs', () => {
 
         element.processSignalList(signalList);
         await parent.requestUpdate();
+        await parent.updateComplete;
       });
 
       it('creates filtered list with all proposed desc attribute updates', async () => {
@@ -113,6 +118,7 @@ describe('Update method for desc attributes in SEL IEDs', () => {
 
         element.processSignalList(signalList);
         await parent.requestUpdate();
+        await parent.updateComplete;
       });
 
       it('creates filtered list with all proposed desc attribute updates', async () => {
@@ -124,6 +130,7 @@ describe('Update method for desc attributes in SEL IEDs', () => {
           ?.querySelector<HTMLElement>('mwc-button[slot="primaryAction"]')!
           .click();
 
+        await parent.requestUpdate();
         await parent.updateComplete;
         expect(editorAction).to.have.been.calledOnce;
         expect(editorAction.args[0][0].detail.action).to.not.satisfy(isSimple);