Skip to content

Commit dd9843e

Browse files
refactor(action-pane): remove h5 and h6 max to h4 (openscd#755)
1 parent ecfeb5d commit dd9843e

File tree

2 files changed

+4
-46
lines changed

2 files changed

+4
-46
lines changed

src/action-pane.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,8 @@ export class ActionPane extends LitElement {
7979
return html`<h2>${content}</h2>`;
8080
case 3:
8181
return html`<h3>${content}</h3>`;
82-
case 4:
83-
return html`<h4>${content}</h4>`;
84-
case 5:
85-
return html`<h5>${content}</h5>`;
8682
default:
87-
return html`<h6>${content}</h6>`;
83+
return html`<h4>${content}</h4>`;
8884
}
8985
}
9086

@@ -150,9 +146,7 @@ export class ActionPane extends LitElement {
150146
h1,
151147
h2,
152148
h3,
153-
h4,
154-
h5,
155-
h6 {
149+
h4 {
156150
color: var(--mdc-theme-on-surface);
157151
font-family: 'Roboto', sans-serif;
158152
font-weight: 300;

test/unit/action-pane.test.ts

Lines changed: 2 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ describe('action-pane', () => {
2323
expect(element.shadowRoot?.querySelector('h2')).to.not.exist;
2424
expect(element.shadowRoot?.querySelector('h3')).to.not.exist;
2525
expect(element.shadowRoot?.querySelector('h4')).to.not.exist;
26-
expect(element.shadowRoot?.querySelector('h5')).to.not.exist;
27-
expect(element.shadowRoot?.querySelector('h6')).to.not.exist;
2826
});
2927

3028
it('renders the header as <h1> with level 1', async () => {
@@ -34,8 +32,6 @@ describe('action-pane', () => {
3432
expect(element.shadowRoot?.querySelector('h2')).to.not.exist;
3533
expect(element.shadowRoot?.querySelector('h3')).to.not.exist;
3634
expect(element.shadowRoot?.querySelector('h4')).to.not.exist;
37-
expect(element.shadowRoot?.querySelector('h5')).to.not.exist;
38-
expect(element.shadowRoot?.querySelector('h6')).to.not.exist;
3935
});
4036

4137
it('renders the header as <h2> with level 2', async () => {
@@ -45,8 +41,6 @@ describe('action-pane', () => {
4541
expect(element.shadowRoot?.querySelector('h1')).to.not.exist;
4642
expect(element.shadowRoot?.querySelector('h3')).to.not.exist;
4743
expect(element.shadowRoot?.querySelector('h4')).to.not.exist;
48-
expect(element.shadowRoot?.querySelector('h5')).to.not.exist;
49-
expect(element.shadowRoot?.querySelector('h6')).to.not.exist;
5044
});
5145

5246
it('renders the header as <h3> with level 3', async () => {
@@ -56,8 +50,6 @@ describe('action-pane', () => {
5650
expect(element.shadowRoot?.querySelector('h1')).to.not.exist;
5751
expect(element.shadowRoot?.querySelector('h2')).to.not.exist;
5852
expect(element.shadowRoot?.querySelector('h4')).to.not.exist;
59-
expect(element.shadowRoot?.querySelector('h5')).to.not.exist;
60-
expect(element.shadowRoot?.querySelector('h6')).to.not.exist;
6153
});
6254

6355
it('renders the header as <h4> with level 4', async () => {
@@ -67,41 +59,15 @@ describe('action-pane', () => {
6759
expect(element.shadowRoot?.querySelector('h1')).to.not.exist;
6860
expect(element.shadowRoot?.querySelector('h2')).to.not.exist;
6961
expect(element.shadowRoot?.querySelector('h3')).to.not.exist;
70-
expect(element.shadowRoot?.querySelector('h5')).to.not.exist;
71-
expect(element.shadowRoot?.querySelector('h6')).to.not.exist;
7262
});
7363

74-
it('renders the header as <h5> with level 5', async () => {
75-
element.level = 5;
76-
await element.updateComplete;
77-
expect(element.shadowRoot?.querySelector('h5')).to.exist;
78-
expect(element.shadowRoot?.querySelector('h1')).to.not.exist;
79-
expect(element.shadowRoot?.querySelector('h2')).to.not.exist;
80-
expect(element.shadowRoot?.querySelector('h3')).to.not.exist;
81-
expect(element.shadowRoot?.querySelector('h4')).to.not.exist;
82-
expect(element.shadowRoot?.querySelector('h6')).to.not.exist;
83-
});
84-
85-
it('renders the header as <h6> with level 6', async () => {
86-
element.level = 6;
87-
await element.updateComplete;
88-
expect(element.shadowRoot?.querySelector('h6')).to.exist;
89-
expect(element.shadowRoot?.querySelector('h1')).to.not.exist;
90-
expect(element.shadowRoot?.querySelector('h2')).to.not.exist;
91-
expect(element.shadowRoot?.querySelector('h3')).to.not.exist;
92-
expect(element.shadowRoot?.querySelector('h4')).to.not.exist;
93-
expect(element.shadowRoot?.querySelector('h5')).to.not.exist;
94-
});
95-
96-
it('renders the header as <h6> for levels > 6', async () => {
64+
it('renders the header as <h4> for levels > 4', async () => {
9765
element.level = 7;
9866
await element.updateComplete;
99-
expect(element.shadowRoot?.querySelector('h6')).to.exist;
67+
expect(element.shadowRoot?.querySelector('h4')).to.exist;
10068
expect(element.shadowRoot?.querySelector('h1')).to.not.exist;
10169
expect(element.shadowRoot?.querySelector('h2')).to.not.exist;
10270
expect(element.shadowRoot?.querySelector('h3')).to.not.exist;
103-
expect(element.shadowRoot?.querySelector('h4')).to.not.exist;
104-
expect(element.shadowRoot?.querySelector('h5')).to.not.exist;
10571
});
10672

10773
it('renders the header as <h1> for levels < 1', async () => {
@@ -111,8 +77,6 @@ describe('action-pane', () => {
11177
expect(element.shadowRoot?.querySelector('h2')).to.not.exist;
11278
expect(element.shadowRoot?.querySelector('h3')).to.not.exist;
11379
expect(element.shadowRoot?.querySelector('h4')).to.not.exist;
114-
expect(element.shadowRoot?.querySelector('h5')).to.not.exist;
115-
expect(element.shadowRoot?.querySelector('h6')).to.not.exist;
11680
});
11781

11882
it('does not set contrasted class property with odd level', async () => {

0 commit comments

Comments
 (0)