Skip to content

Commit e399e7e

Browse files
JakobVogelsangJakobVogelsang
authored
fix(editors/plugin): disable read-only inputs (openscd#1000)
1 parent e60cbd4 commit e399e7e

8 files changed

+93
-2
lines changed

‎src/editors/publisher/data-set-element-editor.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,15 @@ export class DataSetElementEditor extends LitElement {
4040
.maybeValue=${this.name}
4141
helper="${translate('scl.name')}"
4242
required
43+
disabled
4344
>
4445
</wizard-textfield>
4546
<wizard-textfield
4647
label="desc"
4748
.maybeValue=${this.desc}
4849
helper="${translate('scl.desc')}"
4950
nullable
51+
disabled
5052
>
5153
</wizard-textfield>
5254
<filtered-list

‎src/editors/publisher/gse-control-element-editor.ts‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ export class GseControlElementEditor extends LitElement {
7575
><mwc-checkbox
7676
id="instType"
7777
?checked="${hasInstType}"
78+
disabled
7879
></mwc-checkbox></mwc-formfield
7980
>${Object.entries(attributes).map(
8081
([key, value]) =>
@@ -84,20 +85,23 @@ export class GseControlElementEditor extends LitElement {
8485
.maybeValue=${value}
8586
pattern="${ifDefined(typePattern[key])}"
8687
required
88+
disabled
8789
></wizard-textfield>`
8890
)}<wizard-textfield
8991
label="MinTime"
9092
.maybeValue=${minTime}
9193
nullable
9294
suffix="ms"
9395
type="number"
96+
disabled
9497
></wizard-textfield
9598
><wizard-textfield
9699
label="MaxTime"
97100
.maybeValue=${maxTime}
98101
nullable
99102
suffix="ms"
100103
type="number"
104+
disabled
101105
></wizard-textfield>
102106
</div>`;
103107
}
@@ -122,19 +126,22 @@ export class GseControlElementEditor extends LitElement {
122126
pattern="${patterns.asciName}"
123127
maxLength="${maxLength.cbName}"
124128
dialogInitialFocus
129+
disabled
125130
></wizard-textfield>
126131
<wizard-textfield
127132
label="desc"
128133
.maybeValue=${desc}
129134
nullable
130135
helper="${translate('scl.desc')}"
136+
disabled
131137
></wizard-textfield>
132138
<wizard-select
133139
label="type"
134140
.maybeValue=${type}
135141
helper="${translate('scl.type')}"
136142
nullable
137143
required
144+
disabled
138145
>${['GOOSE', 'GSSE'].map(
139146
type => html`<mwc-list-item value="${type}">${type}</mwc-list-item>`
140147
)}</wizard-select
@@ -145,19 +152,22 @@ export class GseControlElementEditor extends LitElement {
145152
helper="${translate('scl.id')}"
146153
required
147154
validationMessage="${translate('textfield.nonempty')}"
155+
disabled
148156
></wizard-textfield>
149157
<wizard-checkbox
150158
label="fixedOffs"
151159
.maybeValue=${fixedOffs}
152160
nullable
153161
helper="${translate('scl.fixedOffs')}"
162+
disabled
154163
></wizard-checkbox>
155164
<wizard-select
156165
label="securityEnabled"
157166
.maybeValue=${securityEnabled}
158167
nullable
159168
required
160169
helper="${translate('scl.securityEnable')}"
170+
disabled
161171
>${['None', 'Signature', 'SignatureAndEncryption'].map(
162172
type => html`<mwc-list-item value="${type}">${type}</mwc-list-item>`
163173
)}</wizard-select

‎src/editors/publisher/report-control-element-editor.ts‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ export class ReportControlElementEditor extends LitElement {
6464
.maybeValue=${value}
6565
nullable
6666
helper="${translate(`scl.${key}`)}"
67+
disabled
6768
></wizard-checkbox>`
6869
)}`;
6970
}
@@ -87,6 +88,7 @@ export class ReportControlElementEditor extends LitElement {
8788
.maybeValue=${value}
8889
nullable
8990
helper="${translate(`scl.${key}`)}"
91+
disabled
9092
></wizard-checkbox>`
9193
)}`;
9294
}
@@ -120,30 +122,35 @@ export class ReportControlElementEditor extends LitElement {
120122
pattern="${patterns.asciName}"
121123
maxLength="${maxLength.cbName}"
122124
dialogInitialFocus
125+
disabled
123126
></wizard-textfield
124127
><wizard-textfield
125128
label="desc"
126129
.maybeValue=${desc}
127130
nullable
128131
helper="${translate('scl.desc')}"
132+
disabled
129133
></wizard-textfield
130134
><wizard-checkbox
131135
label="buffered"
132136
.maybeValue=${buffered}
133137
helper="${translate('scl.buffered')}"
138+
disabled
134139
></wizard-checkbox
135140
><wizard-textfield
136141
label="rptID"
137142
.maybeValue=${rptID}
138143
nullable
139144
required
140145
helper="${translate('report.rptID')}"
146+
disabled
141147
></wizard-textfield
142148
><wizard-checkbox
143149
label="indexed"
144150
.maybeValue=${indexed}
145151
nullable
146152
helper="${translate('scl.indexed')}"
153+
disabled
147154
></wizard-checkbox
148155
><wizard-textfield
149156
label="max Clients"
@@ -152,6 +159,7 @@ export class ReportControlElementEditor extends LitElement {
152159
nullable
153160
type="number"
154161
suffix="#"
162+
disabled
155163
></wizard-textfield
156164
><wizard-textfield
157165
label="bufTime"
@@ -162,6 +170,7 @@ export class ReportControlElementEditor extends LitElement {
162170
type="number"
163171
min="0"
164172
suffix="ms"
173+
disabled
165174
></wizard-textfield
166175
><wizard-textfield
167176
label="intgPd"
@@ -172,6 +181,7 @@ export class ReportControlElementEditor extends LitElement {
172181
type="number"
173182
min="0"
174183
suffix="ms"
184+
disabled
175185
></wizard-textfield>
176186
</div>`;
177187
}

‎src/editors/publisher/sampled-value-control-element-editor.ts‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ export class SampledValueControlElementEditor extends LitElement {
7272
><mwc-checkbox
7373
id="instType"
7474
?checked="${hasInstType}"
75+
disabled
7576
></mwc-checkbox></mwc-formfield
7677
>${Object.entries(attributes).map(
7778
([key, value]) =>
@@ -81,6 +82,7 @@ export class SampledValueControlElementEditor extends LitElement {
8182
.maybeValue=${value}
8283
pattern="${ifDefined(typePattern[key])}"
8384
required
85+
disabled
8486
></wizard-textfield>`
8587
)}`;
8688
}
@@ -110,6 +112,7 @@ export class SampledValueControlElementEditor extends LitElement {
110112
.maybeValue=${value}
111113
nullable
112114
helper="${translate(`scl.${key}`)}"
115+
disabled
113116
></wizard-checkbox>`
114117
)}`;
115118
}
@@ -151,12 +154,14 @@ export class SampledValueControlElementEditor extends LitElement {
151154
pattern="${patterns.asciName}"
152155
maxLength="${maxLength.cbName}"
153156
dialogInitialFocus
157+
disabled
154158
></wizard-textfield>
155159
<wizard-textfield
156160
label="desc"
157161
.maybeValue=${desc}
158162
nullable
159163
helper="${translate('scl.desc')}"
164+
disabled
160165
></wizard-textfield>
161166
${multicast === 'true'
162167
? html``
@@ -172,13 +177,15 @@ export class SampledValueControlElementEditor extends LitElement {
172177
helper="${translate('scl.id')}"
173178
required
174179
validationMessage="${translate('textfield.nonempty')}"
180+
disabled
175181
></wizard-textfield>
176182
<wizard-select
177183
label="smpMod"
178184
.maybeValue=${smpMod}
179185
nullable
180186
required
181187
helper="${translate('scl.smpMod')}"
188+
disabled
182189
>${['SmpPerPeriod', 'SmpPerSec', 'SecPerSmp'].map(
183190
option =>
184191
html`<mwc-list-item value="${option}">${option}</mwc-list-item>`
@@ -191,6 +198,7 @@ export class SampledValueControlElementEditor extends LitElement {
191198
required
192199
type="number"
193200
min="0"
201+
disabled
194202
></wizard-textfield>
195203
<wizard-textfield
196204
label="nofASDU"
@@ -199,13 +207,15 @@ export class SampledValueControlElementEditor extends LitElement {
199207
required
200208
type="number"
201209
min="0"
210+
disabled
202211
></wizard-textfield>
203212
<wizard-select
204213
label="securityEnabled"
205214
.maybeValue=${securityEnabled}
206215
nullable
207216
required
208217
helper="${translate('scl.securityEnable')}"
218+
disabled
209219
>${['None', 'Signature', 'SignatureAndEncryption'].map(
210220
type => html`<mwc-list-item value="${type}">${type}</mwc-list-item>`
211221
)}</wizard-select

‎test/unit/editors/publisher/__snapshots__/data-set-element-editor.test.snap.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ snapshots["Editor for DataSet element with valid DataSet looks like the latest s
1212
</div>
1313
</h2>
1414
<wizard-textfield
15+
disabled=""
1516
helper="[scl.name]"
1617
label="name"
1718
required=""

‎test/unit/editors/publisher/__snapshots__/gse-control-element-editor.test.snap.js‎

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ snapshots["Editor for GSEControl element and its direct children with valid GSEC
1616
<div class="content">
1717
<wizard-textfield
1818
dialoginitialfocus=""
19+
disabled=""
1920
helper="[scl.name]"
2021
label="name"
2122
maxlength="32"
@@ -32,6 +33,7 @@ snapshots["Editor for GSEControl element and its direct children with valid GSEC
3233
>
3334
</wizard-textfield>
3435
<wizard-select
36+
disabled=""
3537
helper="[scl.type]"
3638
label="type"
3739
nullable=""
@@ -60,13 +62,15 @@ snapshots["Editor for GSEControl element and its direct children with valid GSEC
6062
</mwc-list-item>
6163
</wizard-select>
6264
<wizard-textfield
65+
disabled=""
6366
helper="[scl.id]"
6467
label="appID"
6568
required=""
6669
validationmessage="[textfield.nonempty]"
6770
>
6871
</wizard-textfield>
6972
<wizard-checkbox
73+
disabled=""
7074
helper="[scl.fixedOffs]"
7175
label="fixedOffs"
7276
nullable=""
@@ -113,43 +117,52 @@ snapshots["Editor for GSEControl element and its direct children with valid GSEC
113117
Communication Settings (GSE)
114118
</h3>
115119
<mwc-formfield label="[connectedap.wizard.addschemainsttype]">
116-
<mwc-checkbox id="instType">
120+
<mwc-checkbox
121+
disabled=""
122+
id="instType"
123+
>
117124
</mwc-checkbox>
118125
</mwc-formfield>
119126
<wizard-textfield
127+
disabled=""
120128
label="MAC-Address"
121129
pattern="([0-9A-F]{2}-){5}[0-9A-F]{2}"
122130
required=""
123131
>
124132
</wizard-textfield>
125133
<wizard-textfield
134+
disabled=""
126135
label="APPID"
127136
pattern="[0-9A-F]{4}"
128137
required=""
129138
>
130139
</wizard-textfield>
131140
<wizard-textfield
141+
disabled=""
132142
label="VLAN-ID"
133143
nullable=""
134144
pattern="[0-9A-F]{3}"
135145
required=""
136146
>
137147
</wizard-textfield>
138148
<wizard-textfield
149+
disabled=""
139150
label="VLAN-PRIORITY"
140151
nullable=""
141152
pattern="[0-7]"
142153
required=""
143154
>
144155
</wizard-textfield>
145156
<wizard-textfield
157+
disabled=""
146158
label="MinTime"
147159
nullable=""
148160
suffix="ms"
149161
type="number"
150162
>
151163
</wizard-textfield>
152164
<wizard-textfield
165+
disabled=""
153166
label="MaxTime"
154167
nullable=""
155168
suffix="ms"

0 commit comments

Comments
 (0)