feat(editors/laterbinding): Filter later binding GOOSE/SMV by serviceType (closes openscd#1150) (openscd#1151)

Author: danyill

src/editors/subscription/later-binding/ext-ref-later-binding-list.ts

@@ -56,6 +56,11 @@ export class ExtRefLaterBindingList extends LitElement {
   @state()
   currentIedElement: Element | undefined;
 
+  serviceTypeLookup = {
+    GSEControl: 'GOOSE',
+    SampledValueControl: 'SMV',
+  };
+
   constructor() {
     super();
 
@@ -232,7 +237,13 @@ export class ExtRefLaterBindingList extends LitElement {
       <Element>this.doc.getRootNode(),
       this.currentSelectedFcdaElement,
       true
-    ).filter(extRefElement => !isSubscribed(extRefElement));
+    ).filter(
+      extRefElement =>
+        !isSubscribed(extRefElement) &&
+        (!extRefElement.hasAttribute('serviceType') ||
+          extRefElement.getAttribute('serviceType') ===
+            this.serviceTypeLookup[this.controlTag])
+    );
   }
 
   private renderTitle(): TemplateResult {

test/testfiles/editors/LaterBindingGOOSE-LGOS.scd

@@ -133,6 +133,7 @@
 							<ExtRef iedName="GOOSE_Publisher" serviceType="GOOSE" ldInst="QB2_Disconnector" lnClass="CSWI" lnInst="1" prefix="" doName="Pos" daName="stVal" srcLDInst="QB2_Disconnector" srcPrefix="" srcLNClass="LLN0" srcCBName="GOOSE2" intAddr="Pos;CSWI1/Pos/stVal" desc="Interlocking.Input2"/>
 							<ExtRef iedName="GOOSE_Publisher" serviceType="GOOSE" ldInst="QB2_Disconnector" lnClass="CSWI" lnInst="1" prefix="" doName="Pos" daName="q" srcLDInst="QB2_Disconnector" srcPrefix="" srcLNClass="LLN0" srcCBName="GOOSE2" intAddr="Pos;CSWI1/Pos/q" desc="Interlocking.Input2"/>
 							<ExtRef intAddr="someRestrictedExtRef" desc="Restricted To Pos" pLN="CSWI" pDO="Pos" pDA="stVal"/>
+							<ExtRef intAddr="someWeirdAnalogue" serviceType="SMV"/>
 						</Inputs>
 					</LN>
 					<LN prefix="" lnClass="XSWI" inst="1" lnType="Dummy.XSWI"/>
@@ -548,4 +549,4 @@
 			<EnumVal ord="8">process</EnumVal>
 		</EnumType>
 	</DataTypeTemplates>
-</SCL>
+</SCL>

test/testfiles/editors/LaterBindingSMV-LSVS.scd

@@ -88,6 +88,7 @@
 							<ExtRef intAddr="AmpSv;TCTR2/AmpSv/q" desc="MeasPoint.CT1"/>
 							<ExtRef intAddr="AmpSv;TCTR3/AmpSv/instMag.i" desc="MeasPoint.CT3"/>
 							<ExtRef intAddr="AmpSv;TCTR3/AmpSv/q" desc="MeasPoint.CT1"/>
+							<ExtRef intAddr="sillyLikeA" serviceType="GOOSE"/>
 						</Inputs>
 					</LN>
 				</LDevice>