fix: reduce items on menu if elsewhere in the UI (openscd#1256)

* fix: reduce items on menu if elsewhere in the UI

* chore: removed tests for log and diag menu click

* chore: action items dont need to render in menu

Author: Stef3st

src/Hosting.ts

@@ -237,6 +237,7 @@ export function Hosting<
     renderMenuItem(me: MenuItem | 'divider'): TemplateResult {
       if (me === 'divider')
         return html`<li divider padded role="separator"></li>`;
+      if (me.actionItem) return html``;
       return html`
         <mwc-list-item
           class="${me.kind}"
@@ -288,7 +289,9 @@ export function Hosting<
               //       if clause not neccassary when oscd... compenents in open-scd not list
               if (ae.target instanceof List)
                 (<MenuItem>(
-                  this.menu.filter(item => item !== 'divider')[ae.detail.index]
+                  this.menu.filter(
+                    item => item !== 'divider' && !item.actionItem
+                  )[ae.detail.index]
                 ))?.action?.(ae);
             }}
           >

test/integration/__snapshots__/open-scd.test.snap.js

@@ -76,38 +76,6 @@ snapshots["open-scd looks like its snapshot"] =
       role="separator"
     >
     </li>
-    <mwc-list-item
-      aria-disabled="true"
-      class="static"
-      disabled=""
-      graphic="icon"
-      iconid="undo"
-      mwc-list-item=""
-      tabindex="-1"
-    >
-      <mwc-icon slot="graphic">
-        undo
-      </mwc-icon>
-      <span>
-        Undo
-      </span>
-    </mwc-list-item>
-    <mwc-list-item
-      aria-disabled="true"
-      class="static"
-      disabled=""
-      graphic="icon"
-      iconid="redo"
-      mwc-list-item=""
-      tabindex="-1"
-    >
-      <mwc-icon slot="graphic">
-        redo
-      </mwc-icon>
-      <span>
-        Redo
-      </span>
-    </mwc-list-item>
     <mwc-list-item
       aria-disabled="true"
       class="validator"
@@ -144,36 +112,6 @@ snapshots["open-scd looks like its snapshot"] =
     </mwc-list-item>
     <oscd-plugin186320cdd626e422 class="plugin validator">
     </oscd-plugin186320cdd626e422>
-    <mwc-list-item
-      aria-disabled="false"
-      class="static"
-      graphic="icon"
-      iconid="history"
-      mwc-list-item=""
-      tabindex="-1"
-    >
-      <mwc-icon slot="graphic">
-        history
-      </mwc-icon>
-      <span>
-        View log
-      </span>
-    </mwc-list-item>
-    <mwc-list-item
-      aria-disabled="false"
-      class="static"
-      graphic="icon"
-      iconid="rule"
-      mwc-list-item=""
-      tabindex="-1"
-    >
-      <mwc-icon slot="graphic">
-        rule
-      </mwc-icon>
-      <span>
-        View diagnostics
-      </span>
-    </mwc-list-item>
     <li
       divider=""
       padded=""

test/integration/open-scd.test.ts

@@ -47,26 +47,12 @@ describe('open-scd', () => {
     expect(element.logUI).to.have.property('open', true);
   });
 
-  it('opens the log on log menu entry click', async () => {
-    await (<HTMLElement>(
-      element.shadowRoot!.querySelector('mwc-list-item[iconid="history"]')!
-    )).click();
-    expect(element.logUI).to.have.property('open', true);
-  });
-
   it('opens the log on snackbar button click', async () => {
     expect(element.logUI).to.have.property('open', false);
     await element.errorUI.querySelector('mwc-button')!.click();
     expect(element.logUI).to.have.property('open', true);
   });
 
-  it('opens the diagnostics on diagnostics menu entry click', async () => {
-    await (<HTMLElement>(
-      element.shadowRoot!.querySelector('mwc-list-item[iconid="rule"]')!
-    )).click();
-    expect(element.diagnosticUI).to.have.property('open', true);
-  });
-
   it('opens the diagnostics on snackbar button click', async () => {
     expect(element.diagnosticUI).to.have.property('open', false);
     await element.issueUI.querySelector('mwc-button')!.click();