Skip to content

Commit f113180

Browse files
juancho0202Sander3003danyill
authored
fixes: Services section tooltip seems incorrect (openscd#1252)
* fix: tooltip for ied-container's settings icon * fix: update tooltip text to account for ports * test: fixing ied-container snapshot * chore: adding missing german translations * Update src/translations/en.ts Signed-off-by: Sander Jansen <[email protected]> Co-authored-by: danyill <[email protected]> --------- Co-authored-by: Sander Jansen <[email protected]> Co-authored-by: danyill <[email protected]>
1 parent 04d351f commit f113180

File tree

5 files changed

+6
-4
lines changed

5 files changed

+6
-4
lines changed

src/editors/ied/access-point-container.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export class AccessPointContainer extends Container {
4646
return html``;
4747
}
4848

49-
return html` <abbr slot="action" title="${translate('settings')}">
49+
return html` <abbr slot="action" title="${translate('iededitor.settings')}">
5050
<mwc-icon-button
5151
icon="settings"
5252
@click=${() => this.openSettingsWizard(services)}

src/editors/ied/ied-container.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export class IedContainer extends Container {
4040
return html``;
4141
}
4242

43-
return html` <abbr slot="action" title="${translate('settings')}">
43+
return html` <abbr slot="action" title="${translate('iededitor.settings')}">
4444
<mwc-icon-button
4545
icon="settings"
4646
@click=${() => this.openSettingsWizard(services)}

src/translations/de.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,9 +222,10 @@ export const de: Translations = {
222222
},
223223
iededitor: {
224224
iedSelector: 'IED auswählen',
225-
lnFilter: '???',
225+
lnFilter: 'Filter für logische Knoten',
226226
missing: 'Kein IED vorhanden',
227227
toggleChildElements: 'Kindelemente umschalten',
228+
settings: 'Services für IED or AccessPoint',
228229
wizard: {
229230
daTitle: 'DA Informationen anzeigen',
230231
doTitle: 'DO Informationen anzeigen',

src/translations/en.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,7 @@ export const en = {
222222
lnFilter: 'Logical Node Filter',
223223
missing: 'No IED',
224224
toggleChildElements: 'Toggle child elements',
225+
settings: 'Show Services the IED/AccessPoint provides',
225226
wizard: {
226227
daTitle: 'Show DA Info',
227228
doTitle: 'Show DO Info',

test/unit/editors/ied/__snapshots__/ied-container.test.snap.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ snapshots["ied-container looks like the latest snapshot"] =
2222
</abbr>
2323
<abbr
2424
slot="action"
25-
title="[settings]"
25+
title="[iededitor.settings]"
2626
>
2727
<mwc-icon-button icon="settings">
2828
</mwc-icon-button>

0 commit comments

Comments
 (0)