Added check on NOT_FOUND to show correct message. (Tests)

Signed-off-by: Dennis Labordus <[email protected]>

Author: Dennis Labordus

src/compas-services/foundation.ts

@@ -70,7 +70,7 @@ export function handleError(error: Error): Promise<never> {
 }
 
 export function isNotFoundError(reason: any): boolean {
-  return (reason.type && reason.type === NOT_FOUND_ERROR);
+  return (reason.type !== undefined && reason.type === NOT_FOUND_ERROR);
 }
 
 export function createLogEvent(reason: any): void {

test/unit/compas-services/foundation.test.ts

@@ -1,6 +1,11 @@
 import {expect} from "@open-wc/testing";
 
-import {processErrorMessage} from "../../../src/compas-services/foundation.js";
+import {
+  isNotFoundError,
+  NOT_FOUND_ERROR,
+  processErrorMessage,
+  SERVER_ERROR
+} from "../../../src/compas-services/foundation.js";
 
 const errorBody =
 `<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
@@ -19,13 +24,29 @@ describe('compas-services-foundation', () => {
     const result = await processErrorMessage(response);
     expect(result).to.be.equal(statusText);
   })
-
   it('when there is a body in the response, the message is retrieved from the body', async () => {
     const expectedMessage = 'Name is not a correct name to be used later as filename. (CORE-8000)'
     const statusText = 'some status text';
     const response = new Response(errorBody, <ResponseInit>{statusText: statusText});
     const result = await processErrorMessage(response);
     expect(result).to.be.equal(expectedMessage);
+
+  })
+
+  it('when the error is caused by a status 404 then return true', () => {
+    const reason = {type: NOT_FOUND_ERROR};
+    const result = isNotFoundError(reason);
+    expect(result).to.be.true;
+  })
+  it('when the error is caused by other status then return false', () => {
+    const reason = {type: SERVER_ERROR};
+    const result = isNotFoundError(reason);
+    expect(result).to.be.false;
+  })
+  it('when no type of error found then return false', () => {
+    const reason = {};
+    const result = isNotFoundError(reason);
+    expect(result).to.be.false;
   })
 });