From 2432ef37834c56283338db482176d6c2199f3f46 Mon Sep 17 00:00:00 2001 From: Sergio Alvarenga Date: Wed, 5 Mar 2025 11:11:03 +0100 Subject: [PATCH 1/5] feat: add subscriber later binding as submodule --- .gitmodules | 4 ++++ packages/compas-open-scd/public/js/plugins.js | 7 +++++++ packages/external-plugins/scl-editor | 1 + 3 files changed, 12 insertions(+) create mode 160000 packages/external-plugins/scl-editor diff --git a/.gitmodules b/.gitmodules index 5c01514298..32df23302e 100644 --- a/.gitmodules +++ b/.gitmodules @@ -6,3 +6,7 @@ path = packages/external-plugins/oscd-plugins url = https://github.com/sprinteins/oscd-plugins branch = gh-pages +[submodule "packages/external-plugins/scl-editor"] + path = packages/external-plugins/scl-editor + url = https://github.com/danyill/scl-editor + branch = gh-pages diff --git a/packages/compas-open-scd/public/js/plugins.js b/packages/compas-open-scd/public/js/plugins.js index 49bf7595ec..8fb0c37ae8 100644 --- a/packages/compas-open-scd/public/js/plugins.js +++ b/packages/compas-open-scd/public/js/plugins.js @@ -111,6 +111,13 @@ export const officialPlugins = [ default: false, kind: 'editor', }, + { + name: 'Subscribe (Later Binding)', + src: '/external-plugins/scl-editor/plugins/oscd-subscriber-later-binding/oscd-subscriber-later-binding.js', + icon: 'link', + default: false, + kind: 'editor', + }, { name: 'Open project', src: '/src/menu/CompasOpen.js', diff --git a/packages/external-plugins/scl-editor b/packages/external-plugins/scl-editor new file mode 160000 index 0000000000..fb9a2aae45 --- /dev/null +++ b/packages/external-plugins/scl-editor @@ -0,0 +1 @@ +Subproject commit fb9a2aae45378bbc72ff6ab9809a8d9407c0588a From e6fbc7866b489912dc357aa9c800491db729f994 Mon Sep 17 00:00:00 2001 From: Sergio Alvarenga Date: Wed, 5 Mar 2025 11:12:14 +0100 Subject: [PATCH 2/5] docs: update plug-ins.md documentation --- docs/plug-ins.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/plug-ins.md b/docs/plug-ins.md index 5906e748f8..c574c0d781 100644 --- a/docs/plug-ins.md +++ b/docs/plug-ins.md @@ -277,6 +277,14 @@ implemented in these plugins. > https://sprinteins.github.io/oscd-plugins/documentation/index.js > ``` +### Subscriber (Later Binding) + +> Editor | by [Daniel](https://github.com/danyill) | [Repository](https://github.com/danyill/scl-editor) +> +> ``` +> https://danyill.github.io/scl-editor/plugins/oscd-subscriber-later-binding/oscd-subscriber-later-binding.js +> ``` + ## Vendor Specific Plug-ins These plug-ins are specific to a vendor and can include vendor specific From 4fca05227035478e684044ed20b6c6f41e89597e Mon Sep 17 00:00:00 2001 From: Sergio Alvarenga Date: Wed, 5 Mar 2025 16:29:20 +0100 Subject: [PATCH 3/5] remove scl editor submodule --- .gitmodules | 4 ---- packages/external-plugins/scl-editor | 1 - 2 files changed, 5 deletions(-) delete mode 160000 packages/external-plugins/scl-editor diff --git a/.gitmodules b/.gitmodules index 32df23302e..5c01514298 100644 --- a/.gitmodules +++ b/.gitmodules @@ -6,7 +6,3 @@ path = packages/external-plugins/oscd-plugins url = https://github.com/sprinteins/oscd-plugins branch = gh-pages -[submodule "packages/external-plugins/scl-editor"] - path = packages/external-plugins/scl-editor - url = https://github.com/danyill/scl-editor - branch = gh-pages diff --git a/packages/external-plugins/scl-editor b/packages/external-plugins/scl-editor deleted file mode 160000 index fb9a2aae45..0000000000 --- a/packages/external-plugins/scl-editor +++ /dev/null @@ -1 +0,0 @@ -Subproject commit fb9a2aae45378bbc72ff6ab9809a8d9407c0588a From d75890db39d411d1e93f80f2ad81de21792ddb45 Mon Sep 17 00:00:00 2001 From: Sergio Alvarenga Date: Wed, 5 Mar 2025 16:40:00 +0100 Subject: [PATCH 4/5] feat: add only the subscriber-later-binding plugin --- .gitmodules | 4 ++++ packages/compas-open-scd/public/js/plugins.js | 2 +- packages/external-plugins/oscd-subscriber-later-binding | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) create mode 160000 packages/external-plugins/oscd-subscriber-later-binding diff --git a/.gitmodules b/.gitmodules index 5c01514298..3d89d65cab 100644 --- a/.gitmodules +++ b/.gitmodules @@ -6,3 +6,7 @@ path = packages/external-plugins/oscd-plugins url = https://github.com/sprinteins/oscd-plugins branch = gh-pages +[submodule "packages/external-plugins/oscd-subscriber-later-binding"] + path = packages/external-plugins/oscd-subscriber-later-binding + url = https://github.com/danyill/oscd-subscriber-later-binding + branch = gh-pages diff --git a/packages/compas-open-scd/public/js/plugins.js b/packages/compas-open-scd/public/js/plugins.js index 8fb0c37ae8..db1aacbc63 100644 --- a/packages/compas-open-scd/public/js/plugins.js +++ b/packages/compas-open-scd/public/js/plugins.js @@ -113,7 +113,7 @@ export const officialPlugins = [ }, { name: 'Subscribe (Later Binding)', - src: '/external-plugins/scl-editor/plugins/oscd-subscriber-later-binding/oscd-subscriber-later-binding.js', + src: '/external-plugins/oscd-subscriber-later-binding/oscd-subscriber-later-binding.js', icon: 'link', default: false, kind: 'editor', diff --git a/packages/external-plugins/oscd-subscriber-later-binding b/packages/external-plugins/oscd-subscriber-later-binding new file mode 160000 index 0000000000..8ad609be13 --- /dev/null +++ b/packages/external-plugins/oscd-subscriber-later-binding @@ -0,0 +1 @@ +Subproject commit 8ad609be13a12c6f2dce7cd7dd0a2debff5c6161 From 58464b9ea5ea75113ad1716c90d489d7c5309da4 Mon Sep 17 00:00:00 2001 From: Sergio Alvarenga Date: Wed, 5 Mar 2025 16:43:57 +0100 Subject: [PATCH 5/5] docs: remove docs --- docs/plug-ins.md | 8 -------- 1 file changed, 8 deletions(-) diff --git a/docs/plug-ins.md b/docs/plug-ins.md index c574c0d781..5906e748f8 100644 --- a/docs/plug-ins.md +++ b/docs/plug-ins.md @@ -277,14 +277,6 @@ implemented in these plugins. > https://sprinteins.github.io/oscd-plugins/documentation/index.js > ``` -### Subscriber (Later Binding) - -> Editor | by [Daniel](https://github.com/danyill) | [Repository](https://github.com/danyill/scl-editor) -> -> ``` -> https://danyill.github.io/scl-editor/plugins/oscd-subscriber-later-binding/oscd-subscriber-later-binding.js -> ``` - ## Vendor Specific Plug-ins These plug-ins are specific to a vendor and can include vendor specific