feat: add subscriber plugin #360
Merged
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clepski
requested changes
Mar 5, 2025
.gitmodules
Outdated
Comment on lines
9
to
12
| [submodule "packages/external-plugins/scl-editor"] | ||
| path = packages/external-plugins/scl-editor | ||
| url = https://github.com/danyill/scl-editor | ||
| branch = gh-pages |
There was a problem hiding this comment.
Adding the entire scl-editor seems overkill, let us at just the plugin like it is done in the scl-editor distribution, see https://github.com/danyill/scl-editor/blob/main/.gitmodules#L45C1-L48C20
Our build method isn't very smart and mounts the entire external-plugins directory, this would make the image a lot larger than it has to be
docs/plug-ins.md
Outdated
Comment on lines
280
to
287
| ### Subscriber (Later Binding) | ||
| > <kbd>Editor</kbd> | by [Daniel](https://github.com/danyill) | [Repository](https://github.com/danyill/scl-editor) | ||
| > | ||
| > ``` | ||
| > https://danyill.github.io/scl-editor/plugins/oscd-subscriber-later-binding/oscd-subscriber-later-binding.js | ||
| > ``` | ||
There was a problem hiding this comment.
This file is summary for plugins in the open-scd ecosystem and it is maintained in the open scd repository. If changes are made to the list, it should be done in the open scd repo.
I would not make any changes to the list, because it is independent of compas open scd and more of a reference list for users.
clepski
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.