Skip to content

Commit 36abdd9

Browse files
author
Dennis Labordus
committed
Updated unittest to validate XY Coordinates.
Signed-off-by: Dennis Labordus <[email protected]>
1 parent d5e2222 commit 36abdd9

File tree

2 files changed

+20
-3
lines changed

2 files changed

+20
-3
lines changed

service/src/test/java/org/lfenergy/compas/scl/auto/alignment/service/SclAutoAlignmentEnricherTest.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,13 @@ void enrich_WhenPassingCase1_ThenSCDUpdated() throws Exception {
3535
writeFile(filename + "-updated.scd", scl);
3636

3737
assertXYCoordinates(scl.getElement(), "//scl:VoltageLevel[@name='J1']", 2, 4);
38-
assertXYCoordinates(scl.getElement(), "//scl:Bay[@name='BusBar A']", 1, 15);
38+
assertXYCoordinates(scl.getElement(), "//scl:VoltageLevel[@name='J1']/scl:Bay[@name='BusBar A']", 1, 15);
39+
assertXYCoordinates(scl.getElement(), "//scl:VoltageLevel[@name='J1']/scl:Bay[@name='Bay 1S']", 2, 13);
40+
assertXYCoordinates(scl.getElement(), "//scl:VoltageLevel[@name='J1']/scl:Bay[@name='Bay 1S']/scl:ConductingEquipment[@name='CBR1']", 1, 1);
3941
}
4042

4143
@Test
42-
void enrich_WhenPassingCase2_ThenSCDUpdated() throws IOException {
44+
void enrich_WhenPassingCase2_ThenSCDUpdated() throws Exception {
4345
// The JSON file used here is a copy created by the testcase
4446
// SclAutoAlignmentServiceTest#createJson_WhenPassingCase2_ThenJsonReturned
4547
var filename = "scl-2";
@@ -51,6 +53,12 @@ void enrich_WhenPassingCase2_ThenSCDUpdated() throws IOException {
5153

5254
assertNotNull(scl.getElement());
5355
writeFile(filename + "-updated.scd", scl);
56+
57+
assertXYCoordinates(scl.getElement(), "//scl:PowerTransformer[@name='T4']", 27, 3);
58+
assertXYCoordinates(scl.getElement(), "//scl:VoltageLevel[@name='S1 380kV']", 2, 7);
59+
assertXYCoordinates(scl.getElement(), "//scl:VoltageLevel[@name='S1 380kV']/scl:Bay[@name='BUSBAR10']", 1, 12);
60+
assertXYCoordinates(scl.getElement(), "//scl:VoltageLevel[@name='S1 380kV']/scl:Bay[@name='BAY_T4_2']", 1, 4);
61+
assertXYCoordinates(scl.getElement(), "//scl:VoltageLevel[@name='S1 380kV']/scl:Bay[@name='BAY_T4_2']/scl:ConductingEquipment[@name='BREAKER25']", 1, 4);
5462
}
5563

5664
private Element readSCLElement(String filename) throws IOException {

service/src/test/java/org/lfenergy/compas/scl/auto/alignment/service/SclAutoAlignmentServiceTest.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@ void updateSCL_WhenPassingCase1_ThenUpdatedSCLReturned() throws Exception {
3838

3939
var rootElement = toElement(result);
4040
assertXYCoordinates(rootElement, "//scl:VoltageLevel[@name='J1']", 2, 4);
41-
assertXYCoordinates(rootElement, "//scl:Bay[@name='BusBar A']", 1, 15);
41+
assertXYCoordinates(rootElement, "//scl:VoltageLevel[@name='J1']/scl:Bay[@name='BusBar A']", 1, 15);
42+
assertXYCoordinates(rootElement, "//scl:VoltageLevel[@name='J1']/scl:Bay[@name='Bay 1S']", 2, 13);
43+
assertXYCoordinates(rootElement, "//scl:VoltageLevel[@name='J1']/scl:Bay[@name='Bay 1S']/scl:ConductingEquipment[@name='CBR1']", 1, 1);
4244
}
4345

4446
@Test
@@ -49,6 +51,13 @@ void updateSCL_WhenPassingCase2_ThenUpdatedSCLReturned() throws Exception {
4951
var result = sclAutoAlignmentService.updateSCL(sclString, List.of("_af9a4ae3-ba2e-4c34-8e47-5af894ee20f4"), "Mr. Editor");
5052
assertNotNull(result);
5153
writeFile(filename + "-updated-service.scd", result);
54+
55+
var rootElement = toElement(result);
56+
assertXYCoordinates(rootElement, "//scl:PowerTransformer[@name='T4']", 27, 3);
57+
assertXYCoordinates(rootElement, "//scl:VoltageLevel[@name='S1 380kV']", 2, 7);
58+
assertXYCoordinates(rootElement, "//scl:VoltageLevel[@name='S1 380kV']/scl:Bay[@name='BUSBAR10']", 1, 12);
59+
assertXYCoordinates(rootElement, "//scl:VoltageLevel[@name='S1 380kV']/scl:Bay[@name='BAY_T4_2']", 1, 4);
60+
assertXYCoordinates(rootElement, "//scl:VoltageLevel[@name='S1 380kV']/scl:Bay[@name='BAY_T4_2']/scl:ConductingEquipment[@name='BREAKER25']", 1, 4);
5261
}
5362

5463
@Test

0 commit comments

Comments
 (0)