Added check for duplicate name

Signed-off-by: Flurb <[email protected]>

Author: Flurb

app/src/test/java/org/lfenergy/compas/scl/data/rest/mock/CompasSclDataRepositoryMock.java

@@ -42,6 +42,11 @@ public String findByUUID(SclFileType type, UUID id, Version version) {
         throw new IllegalStateException("Mock method using Mockito. Only needed to startup.");
     }
 
+    @Override
+    public boolean hasDuplicateSclName(SclFileType type, UUID id) {
+        throw new IllegalStateException("Mock method using Mockito. Only needed to startup.");
+    }
+
     @Override
     public void create(SclFileType type, UUID id, String name, String scl, Version version, String who) {
         throw new IllegalStateException("Mock method using Mockito. Only needed to startup.");

repository-basex/src/main/java/org/lfenergy/compas/scl/data/basex/repository/CompasSclDataBaseXRepository.java

@@ -153,6 +153,11 @@ public String findByUUID(SclFileType type, UUID id, Version version) {
         return result.get(0);
     }
 
+    @Override
+    public boolean hasDuplicateSclName(SclFileType type, String name) {
+        return false;
+    }
+
     @Override
     public SclMetaInfo findMetaInfoByUUID(SclFileType type, UUID id) {
         // This find method always searches for the latest version.

repository-postgresql/src/main/java/org/lfenergy/compas/scl/data/repository/postgresql/CompasSclDataPostgreSQLRepository.java

@@ -155,6 +155,11 @@ public String findByUUID(SclFileType type, UUID id, Version version) {
         }
     }
 
+    @Override
+    public boolean hasDuplicateSclName(SclFileType type, String name) {
+        return false;
+    }
+
     @Override
     public SclMetaInfo findMetaInfoByUUID(SclFileType type, UUID id) {
         var sql = SELECT_METADATA_CLAUSE

repository/src/main/java/org/lfenergy/compas/scl/data/exception/CompasSclDataServiceErrorCode.java

@@ -14,6 +14,7 @@ public class CompasSclDataServiceErrorCode {
     public static final String HEADER_NOT_FOUND_ERROR_CODE = "SDS-0004";
     public static final String NO_SCL_ELEMENT_FOUND_ERROR_CODE = "SDS-0005";
     public static final String NO_DATA_FOUND_ERROR_CODE = "SDS-0006";
+    public static final String DULPICATE_SCL_NAME_ERROR_CODE = "SDS-0007";
 
     public static final String BASEX_CLIENT_CREATION_ERROR_CODE = "SDS-1000";
     public static final String BASEX_QUERY_ERROR_CODE = "SDS-1001";

repository/src/main/java/org/lfenergy/compas/scl/data/repository/CompasSclDataRepository.java

@@ -70,6 +70,16 @@ public interface CompasSclDataRepository {
     @Transactional(SUPPORTS)
     String findByUUID(SclFileType type, UUID id, Version version);
 
+    /**
+     * Return the specific version of a specific SCL Entry.
+     *
+     * @param type    The type of SCL to search for the specific SCL.
+     * @param id      The ID of the SCL to search for.
+     * @return True if name is already used by another SCL File of the same File type, otherwise false.
+     */
+    @Transactional(SUPPORTS)
+    boolean hasDuplicateSclName(SclFileType type, String name);
+
     /**
      * Create a new entry for the passed UUID with the version number passed.
      * <p>

service/src/main/java/org/lfenergy/compas/scl/data/service/impl/CompasSclDataServiceImpl.java

@@ -14,6 +14,8 @@
 import org.lfenergy.compas.scl.data.service.CompasSclDataService;
 import org.lfenergy.compas.scl.data.util.SclElementProcessor;
 import org.lfenergy.compas.scl.extensions.model.SclFileType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.w3c.dom.Element;
 
 import javax.transaction.Transactional;
@@ -27,13 +29,17 @@
 import static javax.transaction.Transactional.TxType.REQUIRED;
 import static javax.transaction.Transactional.TxType.SUPPORTS;
 import static org.lfenergy.compas.scl.data.SclDataServiceConstants.*;
+import static org.lfenergy.compas.scl.data.exception.CompasSclDataServiceErrorCode.DULPICATE_SCL_NAME_ERROR_CODE;
 import static org.lfenergy.compas.scl.data.exception.CompasSclDataServiceErrorCode.NO_SCL_ELEMENT_FOUND_ERROR_CODE;
 
 /**
  * Service class that will be using a Repository instance to retrieve, create, update, delete SCL XML Files.
  * These methods contain standard behaviour that is executed for every type of repository.
  */
 public class CompasSclDataServiceImpl implements CompasSclDataService {
+
+    private static final Logger LOGGER = LoggerFactory.getLogger(CompasSclDataServiceImpl.class);
+
     private final CompasSclDataRepository repository;
     private final ElementConverter converter;
     private final SclElementProcessor sclElementProcessor;
@@ -120,6 +126,10 @@ public String create(SclFileType type, String name, String who, String comment,
             throw new CompasException(NO_SCL_ELEMENT_FOUND_ERROR_CODE, "No valid SCL found in the passed SCL Data.");
         }
 
+        if (hasDuplicateSclName(type, name)) {
+            throw new CompasException(DULPICATE_SCL_NAME_ERROR_CODE, "Given name of SCL File already used.");
+        }
+
         // A unique ID is generated to store it under.
         var id = UUID.randomUUID();
         // When the SCL is created the version will be set to 1.0.0
@@ -158,6 +168,14 @@ public String update(SclFileType type, UUID id, ChangeSetType changeSetType, Str
         }
 
         var currentSclMetaInfo = repository.findMetaInfoByUUID(type, id);
+        var newFileName = getFilenameFromXML(scl);
+
+        if (newFileName.isPresent()
+            && !newFileName.get().equals(currentSclMetaInfo.getName())
+            && hasDuplicateSclName(type, newFileName.get())) {
+            throw new CompasException(DULPICATE_SCL_NAME_ERROR_CODE, "Given name of SCL File already used.");
+        }
+
         // We always add a new version to the database, so add version record to the SCL and create a new record.
         var version = new Version(currentSclMetaInfo.getVersion());
         version = version.getNextVersion(changeSetType);
@@ -167,7 +185,7 @@ public String update(SclFileType type, UUID id, ChangeSetType changeSetType, Str
         createHistoryItem(header, "SCL updated", who, comment, version);
 
         // Update or add the Compas Private Element to the SCL File.
-        var newSclName = getFilenameFromXML(scl).orElse(currentSclMetaInfo.getName());
+        var newSclName = newFileName.orElse(currentSclMetaInfo.getName());
         setSclCompasPrivateElement(scl, newSclName, type);
 
         var newSclData = converter.convertToString(scl);
@@ -200,6 +218,10 @@ public void delete(SclFileType type, UUID id, Version version) {
         repository.delete(type, id, version);
     }
 
+    private boolean hasDuplicateSclName(SclFileType type, String name) {
+        return repository.hasDuplicateSclName(type, name);
+    }
+
     /**
      * Retrieve the Header from the SCL Fiel or create one if it doesn't exists and set the ID and
      * version on the Header.