Merge pull request #244 from com-pas/sonar-issues

Fixed sonar code smells.

Author: Dennis Labordus

repository/src/main/java/org/lfenergy/compas/scl/data/model/ChangeSetType.java

@@ -6,10 +6,12 @@
 
 import org.eclipse.microprofile.openapi.annotations.media.Schema;
 
-@Schema(description = "The type of change used to determine the next version value.\n" +
-        "Major change updating the first digit, for example from 1.2.4 to 2.0.0.\n" +
-        "Minor change updating the second digit, for example from 1.2.4 to 1.3.0.\n" +
-        "Patch change updating the third digit, for example from 1.2.4 to 1.2.5.\n")
+@Schema(description = """
+        The type of change used to determine the next version value.
+        Major change updating the first digit, for example from 1.2.4 to 2.0.0.
+        Minor change updating the second digit, for example from 1.2.4 to 1.3.0.
+        Patch change updating the third digit, for example from 1.2.4 to 1.2.5.
+        """)
 public enum ChangeSetType {
     MAJOR,
     MINOR,

repository/src/main/java/org/lfenergy/compas/scl/data/model/Version.java

@@ -83,8 +83,7 @@ public int hashCode() {
     public boolean equals(final Object obj) {
         if (obj == this) return true;
         if (obj == null) return false;
-        if (obj instanceof Version) {
-            final Version other = (Version) obj;
+        if (obj instanceof Version other) {
             return majorVersion == other.majorVersion
                     && minorVersion == other.minorVersion
                     && patchVersion == other.patchVersion;

repository/src/main/java/org/lfenergy/compas/scl/data/util/SclElementProcessor.java

@@ -166,8 +166,8 @@ public List<Element> getChildNodesByName(Element root, String localName) {
         if (childNodes.getLength() > 0) {
             for (int i = 0; i < childNodes.getLength(); i++) {
                 Node node = childNodes.item(i);
-                if (node instanceof Element && localName.equals(node.getLocalName())) {
-                    foundElements.add((Element) node);
+                if (node instanceof Element element && localName.equals(element.getLocalName())) {
+                    foundElements.add(element);
                 }
             }
         }