Implemented adding comments when doing create or update of SCL.

Signed-off-by: Dennis Labordus <[email protected]>

Author: Dennis Labordus

service/src/test/java/org/lfenergy/compas/scl/data/service/CompasSclDataServiceTest.java

@@ -105,15 +105,15 @@ void create_WhenCalledWithOutCompasExtension_ThenRepositoryIsCalledAndUUIDIsRetu
 
         assertNotNull(uuid);
         assertCompasExtenions(scl, name, type);
-        assertHistoryItem(scl, initialVersion);
+        assertHistoryItem(scl, initialVersion, comment);
         verify(compasSclDataRepository, times(1)).create(eq(type), any(UUID.class), eq(scl), eq(initialVersion));
     }
 
     @Test
     void create_WhenCalledWithCompasExtension_ThenRepositoryIsCalledAndUUIDIsReturned() {
         var type = SclType.SCD;
         var name = "JUSTSOMENAME";
-        var comment = "Some comments";
+        var comment = "";
         var who = "User A";
 
         var scl = readSCL();
@@ -125,7 +125,7 @@ void create_WhenCalledWithCompasExtension_ThenRepositoryIsCalledAndUUIDIsReturne
 
         assertNotNull(uuid);
         assertCompasExtenions(scl, name, type);
-        assertHistoryItem(scl, initialVersion);
+        assertHistoryItem(scl, initialVersion, comment);
         verify(compasSclDataRepository, times(1)).create(eq(type), any(UUID.class), eq(scl), eq(initialVersion));
     }
 
@@ -135,7 +135,6 @@ void update_WhenCalledWithCompasElements_ThenRepositoryIsCalled() {
         var name = "JUSTSOMENAME";
         var uuid = UUID.randomUUID();
         var changeSet = ChangeSetType.MAJOR;
-        var comment = "Some comments";
         var who = "User A";
         var nextVersion = initialVersion.getNextVersion(changeSet);
 
@@ -147,10 +146,10 @@ void update_WhenCalledWithCompasElements_ThenRepositoryIsCalled() {
         when(compasSclDataRepository.findByUUID(type, uuid)).thenReturn(previousScl);
         doNothing().when(compasSclDataRepository).create(type, uuid, scl, nextVersion);
 
-        compasSclDataService.update(type, uuid, changeSet, who, comment, scl);
+        compasSclDataService.update(type, uuid, changeSet, who, null, scl);
 
         assertCompasExtenions(scl, name, type);
-        assertHistoryItem(scl, nextVersion);
+        assertHistoryItem(scl, nextVersion, null);
         verify(compasSclDataRepository, times(1)).create(type, uuid, scl, nextVersion);
         verify(compasSclDataRepository, times(1)).findByUUID(type, uuid);
     }
@@ -213,7 +212,7 @@ private void assertCompasExtenions(Element scl, String name, SclType type) {
         assertEquals(type.toString(), typeElement.get().getTextContent());
     }
 
-    private void assertHistoryItem(Element scl, Version version) {
+    private void assertHistoryItem(Element scl, Version version, String comment) {
         var header = processor.getSclHeader(scl);
         assertTrue(header.isPresent());
 
@@ -225,6 +224,9 @@ private void assertHistoryItem(Element scl, Version version) {
         // The last item should be the one added.
         var item = items.get(items.size() - 1);
         assertEquals(version.toString(), item.getAttribute(SCL_VERSION_ATTR));
+        if (comment != null && !comment.isEmpty()) {
+            assertTrue(item.getAttribute(SCL_WHAT_ATTR).contains(comment));
+        }
     }
 
     private Element readSCL() {