Skip to content

Commit 74c8c8e

Browse files
author
Flurb
committed
Added unit tests
Signed-off-by: Flurb <[email protected]>
1 parent a0bff14 commit 74c8c8e

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

repository-postgresql/src/main/java/org/lfenergy/compas/scl/data/repository/postgresql/CompasSclDataPostgreSQLRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ public boolean hasDuplicateSclName(SclFileType type, String name) {
174174
}
175175
return false;
176176
} catch (SQLException exp) {
177-
throw new CompasSclDataServiceException(POSTGRES_SELECT_ERROR_CODE, "Error select meta info from database!", exp);
177+
throw new CompasSclDataServiceException(POSTGRES_SELECT_ERROR_CODE, "Error selecting latest versions from database!", exp);
178178
}
179179
}
180180

service/src/test/java/org/lfenergy/compas/scl/data/service/impl/CompasSclDataServiceImplTest.java

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ void create_WhenCalledWithOutCompasExtension_ThenSCLReturnedWithCorrectCompasExt
118118

119119
var scl = readSCL();
120120

121+
when(compasSclDataRepository.hasDuplicateSclName(SCL_TYPE, name)).thenReturn(false);
121122
doNothing().when(compasSclDataRepository).create(eq(SCL_TYPE), any(UUID.class), eq(name), anyString(), eq(INITIAL_VERSION), eq(who));
122123

123124
scl = compasSclDataService.create(SCL_TYPE, name, who, comment, scl);
@@ -137,6 +138,7 @@ void create_WhenCalledWithCompasExtension_ThenSCLReturnedWithCorrectCompasExtens
137138
var scl = readSCL();
138139
scl = createCompasPrivate(scl, "JUSTANOTHERNAME");
139140

141+
when(compasSclDataRepository.hasDuplicateSclName(SCL_TYPE, name)).thenReturn(false);
140142
doNothing().when(compasSclDataRepository).create(eq(SCL_TYPE), any(UUID.class), eq(name), anyString(), eq(INITIAL_VERSION), eq(who));
141143

142144
scl = compasSclDataService.create(SCL_TYPE, name, who, comment, scl);
@@ -147,6 +149,22 @@ void create_WhenCalledWithCompasExtension_ThenSCLReturnedWithCorrectCompasExtens
147149
verify(compasSclDataRepository, times(1)).create(eq(SCL_TYPE), any(UUID.class), eq(name), anyString(), eq(INITIAL_VERSION), eq(who));
148150
}
149151

152+
@Test
153+
void create_WhenCalledWithDuplicateSclName_ThenCompasExceptionThrown() throws IOException {
154+
var name = "JUSTSOMENAME";
155+
var comment = "";
156+
var who = "User A";
157+
158+
var scl = readSCL();
159+
160+
when(compasSclDataRepository.hasDuplicateSclName(SCL_TYPE, name)).thenReturn(true);
161+
var exception = assertThrows(CompasException.class, () -> {
162+
compasSclDataService.create(SCL_TYPE, name, who, comment, scl);
163+
});
164+
assertEquals(DUPLICATE_SCL_NAME_ERROR_CODE, exception.getErrorCode());
165+
verify(compasSclDataRepository, times(1)).hasDuplicateSclName(SCL_TYPE, name);
166+
}
167+
150168
@Test
151169
void create_WhenCalledWithXMLStringWithoutSCL_ThenCompasExceptionThrown() {
152170
var name = "JUSTSOMENAME";

0 commit comments

Comments
 (0)