Skip to content

Commit 9e6374d

Browse files
committed
[#464] Increased unit tests quality
Signed-off-by: David Monichi <[email protected]>
1 parent c3a69e7 commit 9e6374d

File tree

1 file changed

+26
-6
lines changed

1 file changed

+26
-6
lines changed

repository/src/test/java/org/lfenergy/compas/scl/data/repository/AbstractCompasSclDataRepositoryTest.java

Lines changed: 26 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import org.lfenergy.compas.scl.data.model.Version;
99
import org.lfenergy.compas.scl.extensions.model.SclFileType;
1010

11+
import java.util.List;
1112
import java.util.UUID;
1213

1314
import static org.junit.jupiter.api.Assertions.*;
@@ -59,16 +60,35 @@ void findMetaInfoByUUID_WhenCalledWithUnknownUUID_ThenExceptionIsThrown() {
5960
}
6061

6162
@Test
62-
void deleteVersion_WhenCalledWithExistingUUID_ThenSpecificVersionIsDeleted() {
63-
var uuid = UUID.randomUUID();
63+
void delete_AllVersions_SoftDeleted() {
64+
UUID uuid = UUID.randomUUID();
65+
Version version1 = new Version(1, 0, 0);
66+
Version version2 = new Version(2, 0, 0);
67+
68+
var repository = getRepository();
69+
repository.create(TYPE, uuid, "TestName", "<SCL></SCL>", version1, "tester", List.of("label"));
70+
repository.create(TYPE, uuid, "TestName", "<SCL></SCL>", version2, "tester", List.of("label"));
71+
72+
repository.delete(TYPE, uuid);
6473

65-
getRepository().delete(TYPE, uuid);
74+
var items = repository.listVersionsByUUID(TYPE, uuid);
75+
assertEquals(0, items.size(), "All versions should be soft deleted");
6676
}
6777

6878
@Test
69-
void deleteVersion_WhenCalledWithExistingUUIDAndVersion_ThenSpecificVersionIsDeleted() {
70-
var uuid = UUID.randomUUID();
79+
void delete_SpecificVersion_Deleted() {
80+
UUID uuid = UUID.randomUUID();
81+
Version version1 = new Version(1, 0, 0);
82+
Version version2 = new Version(2, 0, 0);
83+
84+
var repository = getRepository();
85+
repository.create(TYPE, uuid, "TestName", "<SCL></SCL>", version1, "tester", List.of("label"));
86+
repository.create(TYPE, uuid, "TestName", "<SCL></SCL>", version2, "tester", List.of("label"));
87+
88+
repository.delete(TYPE, uuid, version1);
7189

72-
getRepository().delete(TYPE, uuid, new Version(1, 3, 2));
90+
var items = repository.listVersionsByUUID(TYPE, uuid);
91+
assertEquals(1, items.size(), "Only one version should remain");
92+
assertEquals(version2.toString(), items.get(0).getVersion(), "Remaining version should be version2");
7393
}
7494
}

0 commit comments

Comments
 (0)