Fixed sonar issues

Signed-off-by: Dennis Labordus <[email protected]>

Author: Dennis Labordus

repository-basex/src/main/java/org/lfenergy/compas/scl/data/repository/CompasSclDataBaseXRepository.java

@@ -121,7 +121,8 @@ public List<Item> listVersionsByUUID(SclType type, UUID id) {
                 sclDataMarshaller::unmarshal);
 
         if (items.isEmpty()) {
-            throw new CompasNoDataFoundException("No versions found for type '" + type + "' with ID '" + id + "'");
+            var message = String.format("No versions found for type '%s' with ID '%s'", type, id);
+            throw new CompasNoDataFoundException(message);
         }
         return items;
     }
@@ -140,7 +141,8 @@ public Element findByUUID(SclType type, UUID id) {
                 xmlString -> elementConverter.convertToElement(xmlString, SCL_ELEMENT_NAME, SCL_NS_URI));
 
         if (result.isEmpty()) {
-            throw new CompasNoDataFoundException("No record found for type '" + type + "' with ID '" + id + "'");
+            var message = String.format("No record found for type '%s' with ID '%s'", type, id);
+            throw new CompasNoDataFoundException(message);
         }
         return result.get(0);
     }
@@ -154,7 +156,8 @@ public Element findByUUID(SclType type, UUID id, Version version) {
                 xmlString -> elementConverter.convertToElement(xmlString, SCL_ELEMENT_NAME, SCL_NS_URI));
 
         if (result.isEmpty()) {
-            throw new CompasNoDataFoundException("No record found for type '" + type + "' with ID '" + id + "' and version '" + version + "'");
+            var message = String.format("No record found for type '%s' with ID '%s' and version '%s'", type, id, version);
+            throw new CompasNoDataFoundException(message);
         }
         return result.get(0);
     }

repository-basex/src/test/java/org/lfenergy/compas/scl/data/repository/CompasSclDataBaseXRepositoryTest.java

@@ -169,8 +169,9 @@ void findByUUIDWithVersion_WhenCalledWithUnknownVersion_ThenExceptionIsThrown()
         var scl = readSCL(uuid, version);
         repository.create(TYPE, uuid, scl, version);
 
+        var unknownVersion = new Version(1, 1, 1);
         var exception = assertThrows(CompasNoDataFoundException.class, () -> {
-            repository.findByUUID(TYPE, uuid, new Version(1, 1, 1));
+            repository.findByUUID(TYPE, uuid, unknownVersion);
         });
         assertEquals(NO_DATA_FOUND_ERROR_CODE, exception.getErrorCode());
     }

repository/src/main/java/org/lfenergy/compas/scl/data/exception/CompasNoDataFoundException.java

@@ -3,9 +3,11 @@
 // SPDX-License-Identifier: Apache-2.0
 package org.lfenergy.compas.scl.data.exception;
 
+import org.lfenergy.compas.core.commons.exception.CompasException;
+
 import static org.lfenergy.compas.scl.data.exception.CompasSclDataServiceErrorCode.NO_DATA_FOUND_ERROR_CODE;
 
-public class CompasNoDataFoundException extends CompasSclDataServiceException {
+public class CompasNoDataFoundException extends CompasException {
     public CompasNoDataFoundException(String message) {
         super(NO_DATA_FOUND_ERROR_CODE, message);
     }