Small issues and fixes.

Signed-off-by: Dennis Labordus <[email protected]>

Author: Dennis Labordus

app/src/main/java/org/lfenergy/compas/scl/validator/rest/v1/SclValidatorResource.java

@@ -41,4 +41,4 @@ public Uni<SclValidateResponse> validateSCL(@PathParam(TYPE_PATH_PARAM) SclFileT
                         new SclValidatorEventRequest(type, request.getSclData()))
                 .onItem().transform(Message::body);
     }
-}
+}

app/src/main/java/org/lfenergy/compas/scl/validator/rest/v1/SclValidatorServerEndpoint.java

@@ -9,6 +9,8 @@
 import org.lfenergy.compas.scl.validator.rest.v1.event.SclValidatorEventRequest;
 import org.lfenergy.compas.scl.validator.rest.v1.model.SclValidateRequest;
 import org.lfenergy.compas.scl.validator.rest.v1.websocket.SclValidateRequestDecoder;
+import org.lfenergy.compas.scl.validator.rest.v1.websocket.SclValidateRequestEncoder;
+import org.lfenergy.compas.scl.validator.rest.v1.websocket.SclValidateResponseDecoder;
 import org.lfenergy.compas.scl.validator.rest.v1.websocket.SclValidateResponseEncoder;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -25,8 +27,8 @@
 @Authenticated
 @ApplicationScoped
 @ServerEndpoint(value = "/compas-scl-validator/validate-ws/v1/{" + TYPE_PATH_PARAM + "}",
-        decoders = SclValidateRequestDecoder.class,
-        encoders = SclValidateResponseEncoder.class)
+        decoders = {SclValidateRequestDecoder.class, SclValidateResponseDecoder.class},
+        encoders = {SclValidateRequestEncoder.class, SclValidateResponseEncoder.class})
 public class SclValidatorServerEndpoint {
     private static final Logger LOGGER = LoggerFactory.getLogger(SclValidatorServerEndpoint.class);
 
@@ -59,4 +61,4 @@ public void onError(Session session, @PathParam(TYPE_PATH_PARAM) String type, Th
     public void onClose(Session session, @PathParam(TYPE_PATH_PARAM) String type) {
         LOGGER.debug("Closing session {} for type {}.", session.getId(), type);
     }
-}
+}

app/src/main/java/org/lfenergy/compas/scl/validator/rest/v1/event/SclValidatorEventHandler.java

@@ -13,7 +13,7 @@
 import java.io.IOException;
 
 /**
- * Event Handler used by the Websockets implementation to execute the validation asynchronized.
+ * Event Handler used to execute the validation asynchronized.
  */
 @ApplicationScoped
 public class SclValidatorEventHandler {

app/src/main/java/org/lfenergy/compas/scl/validator/rest/v1/websocket/SclValidateRequestDecoder.java

@@ -42,4 +42,4 @@ public SclValidateRequest decode(String message) {
     public void destroy() {
         // do nothing.
     }
-}
+}

app/src/main/java/org/lfenergy/compas/scl/validator/rest/v1/websocket/SclValidateRequestEncoder.java

@@ -39,4 +39,4 @@ public String encode(SclValidateRequest request) {
     public void destroy() {
         // do nothing.
     }
-}
+}

app/src/main/java/org/lfenergy/compas/scl/validator/rest/v1/websocket/SclValidateResponseDecoder.java

@@ -42,4 +42,4 @@ public SclValidateResponse decode(String message) {
     public void destroy() {
         // do nothing.
     }
-}
+}

app/src/main/java/org/lfenergy/compas/scl/validator/rest/v1/websocket/SclValidateResponseEncoder.java

@@ -39,4 +39,4 @@ public String encode(SclValidateResponse response) {
     public void destroy() {
         // do nothing.
     }
-}
+}

app/src/main/resources/application.properties

@@ -7,7 +7,7 @@ compas.validator.nsdoc.directory      = /data/nsdoc
 compas.validator.temp.directory       = /data/temp
 
 quarkus.http.cors                 = false
-# Set s the extra context for all RestEasy API Calls, for Websockets this needs to be included in the path.
+# Sets the extra context for all RestEasy API Calls, for Websockets this needs to be included in the endpoint itself.
 quarkus.http.root-path            = /compas-scl-validator
 quarkus.http.limits.max-body-size = 150M
 
@@ -39,7 +39,7 @@ mp.jwt.verify.audiences          = ${JWT_VERIFY_CLIENT_ID:scl-validator}
 smallrye.jwt.path.groups         = ${JWT_GROUPS_PATH:resource_access/scl-validator/roles}
 
 quarkus.http.auth.permission.deny-default.paths=/*
-quarkus.http.auth.permission.deny-default.policy=permit
+quarkus.http.auth.permission.deny-default.policy=deny
 
 quarkus.http.auth.permission.allow-quarkus-services.paths=/compas-scl-validator/q/health/live,/compas-scl-validator/q/health/ready,/compas-scl-validator/q/openapi
 quarkus.http.auth.permission.allow-quarkus-services.policy=permit

app/src/test/java/org/lfenergy/compas/scl/validator/rest/v1/event/SclValidatorEventHandlerTest.java

@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: 2022 Alliander N.V.
+//
+// SPDX-License-Identifier: Apache-2.0
 package org.lfenergy.compas.scl.validator.rest.v1.event;
 
 import io.smallrye.mutiny.helpers.test.UniAssertSubscriber;
@@ -83,4 +86,4 @@ void validateWebsocketsEvent_WhenCalled_ThenExpectedCallsAreMade() throws IOExce
         verify(request, times(1)).getType();
         verify(request, times(1)).getSclData();
     }
-}
+}

app/src/test/java/org/lfenergy/compas/scl/validator/rest/v1/event/SclValidatorEventRequestTest.java

@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: 2022 Alliander N.V.
+//
+// SPDX-License-Identifier: Apache-2.0
 package org.lfenergy.compas.scl.validator.rest.v1.event;
 
 import com.openpojo.reflection.impl.PojoClassFactory;