feat(#533): Add ExtRefService.getFilteredExtRefs method

Signed-off-by: massifben <[email protected]>

Author: massifben

sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/ExtRefService.java

@@ -16,14 +16,15 @@
 import java.util.List;
 import java.util.Objects;
 import java.util.Optional;
+import java.util.function.Predicate;
 import java.util.stream.Stream;
 
 public class ExtRefService {
 
     /**
      * List all ExtRefs in this LDevice
      *
-     * @return list of ExtRefs. List is modifiable.
+     * @return Stream of ExtRefs
      */
     public Stream<TExtRef> getExtRefs(TLDevice tlDevice) {
         return getInputs(tlDevice)
@@ -32,6 +33,16 @@ public Stream<TExtRef> getExtRefs(TLDevice tlDevice) {
                 .flatMap(tInputs -> tInputs.getExtRef().stream());
     }
 
+    /**
+     * List ExtRefs in this LDevice that satisfy the given predicate
+     *
+     * @return Stream of ExtRefs.
+     */
+    public Stream<TExtRef> getFilteredExtRefs(TLDevice tlDevice, Predicate<TExtRef> tExtRefPredicate) {
+        return getExtRefs(tlDevice)
+                .filter(tExtRefPredicate);
+    }
+
     /**
      * Debind ExtRef
      *
@@ -61,8 +72,8 @@ public void clearExtRefBinding(TExtRef extRef) {
      * @return true if the two ExtRef are fed by same Control Block, otherwise false
      */
     public boolean isExtRefFeedBySameControlBlock(TExtRef t1, TExtRef t2) {
-        String srcLNClass1 = (t1.isSetSrcLNClass()) ? t1.getSrcLNClass().get(0) : TLLN0Enum.LLN_0.value();
-        String srcLNClass2 = (t2.isSetSrcLNClass()) ? t2.getSrcLNClass().get(0) : TLLN0Enum.LLN_0.value();
+        String srcLNClass1 = (t1.isSetSrcLNClass()) ? t1.getSrcLNClass().getFirst() : TLLN0Enum.LLN_0.value();
+        String srcLNClass2 = (t2.isSetSrcLNClass()) ? t2.getSrcLNClass().getFirst() : TLLN0Enum.LLN_0.value();
         return Utils.equalsOrBothBlank(t1.getIedName(), t2.getIedName())
                 && Utils.equalsOrBothBlank(t1.getSrcLDInst(), t2.getSrcLDInst())
                 && srcLNClass1.equals(srcLNClass2)

sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ExtRefServiceTest.java

@@ -66,6 +66,28 @@ private static Stream<Arguments> provideLDevices() {
         );
     }
 
+    @Test
+    void getFilteredExtRefs_should_succeed() {
+        //Given
+        TLDevice tlDevice = new TLDevice();
+        tlDevice.setLN0(new LN0());
+        TInputs tInputs = new TInputs();
+        tlDevice.getLN0().setInputs(tInputs);
+        TExtRef tExtRef1 = new TExtRef();
+        tExtRef1.setDesc("extref1");
+        TExtRef tExtRef2 = new TExtRef();
+        tExtRef2.setDesc("extref2");
+        tInputs.getExtRef().add(tExtRef1);
+        tInputs.getExtRef().add(tExtRef2);
+        // When
+        Stream<TExtRef> result = extRefService.getFilteredExtRefs(tlDevice, extRef -> extRef.getDesc().equals("extref1"));
+        // Then
+        assertThat(result)
+                .singleElement()
+                .extracting(TExtRef::getDesc)
+                .isEqualTo("extref1");
+    }
+
     @Test
     void clearExtRefBinding_should_remove_binding() {
         //Given