fix(78): RSR-437 - add check of source LDevice status

Signed-off-by: massifben <[email protected]>

Author: massifben

sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/ied/InputsAdapter.java

@@ -152,16 +152,25 @@ private Optional<SclReportItem> validateExtRefSource(TExtRef extRef, IEDAdapter
             return warningReportItem(extRef, String.format("The signal ExtRef ExtRefldinst does not match any " +
                 "LDevice with same inst attribute in source IED %s", sourceIed.getXPath()));
         }
-        Optional<String> optionalLDeviceStatus = sourceLDevice.getLDeviceStatus();
-        if (optionalLDeviceStatus.isEmpty()) {
+        Optional<String> optionalSourceLDeviceStatus = sourceLDevice.getLDeviceStatus();
+        if (optionalSourceLDeviceStatus.isEmpty()) {
             return fatalReportItem(extRef, String.format("The signal ExtRef source LDevice %s status is undefined",
                 sourceLDevice.getXPath()));
 
-        } else if (OFF.equals(optionalLDeviceStatus.get())) {
-            return warningReportItem(extRef, String.format("The signal ExtRef source LDevice %s status is off",
-                sourceLDevice.getXPath()));
         }
-        return Optional.empty();
+        return optionalSourceLDeviceStatus.map(sourceLDeviceStatus -> {
+            switch (sourceLDeviceStatus) {
+                case OFF:
+                    return SclReportItem.warning(extRefXPath(extRef.getDesc()), String.format("The signal ExtRef source LDevice %s status is off",
+                        sourceLDevice.getXPath()));
+                case ON:
+                    return null;
+                default:
+                    return SclReportItem.fatal(extRefXPath(extRef.getDesc()),
+                        String.format("The signal ExtRef source LDevice %s status is neither \"on\" nor \"off\"",
+                            sourceLDevice.getXPath()));
+            }
+        });
     }
 
     private boolean hasMatchingLN(TExtRef extRef, LDeviceAdapter lDeviceAdapter) {

sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ExtRefServiceTest.java

@@ -108,7 +108,13 @@ public static Stream<Arguments> updateAllExtRefIedNamesErrors() throws Exception
                         SclReportItem.fatal(
                             "/SCL/IED[@name=\"IED_NAME1\"]/AccessPoint/Server/LDevice[@inst=\"LD_INST11\"]" +
                                 "/LN0/Inputs/ExtRef[@desc=\"Source LDevice is undefined for this ExtRef\"]",
-                            "The signal ExtRef source LDevice /SCL/IED[@name=\"IED_NAME2\"]/AccessPoint/Server/LDevice[@inst=\"LD_INST23\"] status is undefined")
+                            "The signal ExtRef source LDevice /SCL/IED[@name=\"IED_NAME2\"]/AccessPoint/Server/LDevice[@inst=\"LD_INST23\"] status is " +
+                                "undefined"),
+                        SclReportItem.fatal(
+                            "/SCL/IED[@name=\"IED_NAME1\"]/AccessPoint/Server/LDevice[@inst=\"LD_INST11\"]" +
+                                "/LN0/Inputs/ExtRef[@desc=\"Source LDevice is neither on nor off for this ExtRef\"]",
+                            "The signal ExtRef source LDevice /SCL/IED[@name=\"IED_NAME2\"]/AccessPoint/Server/LDevice[@inst=\"LD_INST24\"] " +
+                                "status is neither \"on\" nor \"off\"")
                     }),
                 Arguments.of(
                     "Errors on IEDs",

sct-commons/src/test/resources/scd-extref-iedname/scd_set_extref_iedname_with_extref_errors.xml

@@ -31,6 +31,7 @@
                                 <compas:Flow FlowID="7" FlowKind="BAY_INTERNAL" ExtRefiedName="System_Version_IED_NAME2" ExtReflnClass="ANCR" ExtRefldinst="LD_INST21" ExtReflnInst="1" ExtRefprefix="" FlowStatus="ACTIVE" dataStreamKey="ExtRef does not match any LN is source LDevice"/>
                                 <compas:Flow FlowID="1" FlowKind="BAY_INTERNAL" ExtRefiedName="System_Version_IED_NAME2" ExtReflnClass="ANCR" ExtRefldinst="LD_INST22" ExtReflnInst="1" ExtRefprefix="" FlowStatus="ACTIVE" dataStreamKey="Source LDevice is off for this ExtRef"/>
                                 <compas:Flow FlowID="1" FlowKind="BAY_INTERNAL" ExtRefiedName="System_Version_IED_NAME2" ExtReflnClass="ANCR" ExtRefldinst="LD_INST23" ExtReflnInst="1" ExtRefprefix="" FlowStatus="ACTIVE" dataStreamKey="Source LDevice is undefined for this ExtRef"/>
+                                <compas:Flow FlowID="1" FlowKind="BAY_INTERNAL" ExtRefiedName="System_Version_IED_NAME2" ExtReflnClass="ANCR" ExtRefldinst="LD_INST24" ExtReflnInst="1" ExtRefprefix="" FlowStatus="ACTIVE" dataStreamKey="Source LDevice is neither on nor off for this ExtRef"/>
                             </Private>
                             <!-- nominal case -->
                             <ExtRef iedName="System_Version_IED_NAME2" ldInst="LD_INST21" lnClass="ANCR" lnInst="1" doName="DoName1" daName="daName1" intAddr="INT_ADDR11" pDO="Do11.sdo11" pDA="da11.bda111.bda112.bda113" desc="STAT_LDSUIED_LPDO 1 Sortie_13_BOOLEAN_18_stVal_1"/>
@@ -50,6 +51,8 @@
                             <ExtRef iedName="System_Version_IED_NAME2" ldInst="LD_INST22" lnClass="ANCR" lnInst="1" doName="DoName1" daName="daName1" intAddr="INT_ADDR11" pDO="Do11.sdo11" pDA="da11.bda111.bda112.bda113" desc="Source LDevice is off for this ExtRef"/>
                             <!-- source LDevice status is undefined  -->
                             <ExtRef iedName="System_Version_IED_NAME2" ldInst="LD_INST23" lnClass="ANCR" lnInst="1" doName="DoName1" daName="daName1" intAddr="INT_ADDR11" pDO="Do11.sdo11" pDA="da11.bda111.bda112.bda113" desc="Source LDevice is undefined for this ExtRef"/>
+                            <!-- source LDevice status is neither on nor off  -->
+                            <ExtRef iedName="System_Version_IED_NAME2" ldInst="LD_INST24" lnClass="ANCR" lnInst="1" doName="DoName1" daName="daName1" intAddr="INT_ADDR11" pDO="Do11.sdo11" pDA="da11.bda111.bda112.bda113" desc="Source LDevice is neither on nor off for this ExtRef"/>
                         </Inputs>
                     </LN0>
                 </LDevice>
@@ -133,6 +136,17 @@
                     <LN0 lnClass="LLN0" inst="" lnType="LNEX1"/>
                     <LN lnClass="ANCR" inst="1" lnType="lnType"/>
                 </LDevice>
+                <!-- source LDevice status is neither on nor off -->
+                <LDevice inst="LD_INST24">
+                    <LN0 lnClass="LLN0" inst="" lnType="LNEX1">
+                        <DOI name="Mod">
+                            <DAI name="stVal">
+                                <Val>test</Val>
+                            </DAI>
+                        </DOI>
+                    </LN0>
+                    <LN lnClass="ANCR" inst="1" lnType="lnType"/>
+                </LDevice>
             </Server>
         </AccessPoint>
     </IED>