refactor: Modify customException, memberService

- CustomException 확장성 개선 및 핸들러 추가
- MemberService 예외 처리 일부 삭제

Author: comeevery-git

src/main/java/app/common/infrastructure/exception/CustomException.java

@@ -1,11 +1,35 @@
 package app.common.infrastructure.exception;
 
 import app.common.domain.model.common.ResponseCode;
-import lombok.AllArgsConstructor;
 import lombok.Getter;
 
-@AllArgsConstructor
+import java.io.Serializable;
+
 @Getter
-public class CustomException extends RuntimeException {
+public class CustomException extends RuntimeException implements Serializable {
+    private static final long serialVersionUID = 1L;
+
     private final ResponseCode responseCode;
+    private final String additionalMessage;
+
+    public CustomException(ResponseCode responseCode) {
+        this(responseCode, null, null);
+    }
+
+    public CustomException(ResponseCode responseCode, String additionalMessage) {
+        this(responseCode, additionalMessage, null);
+    }
+
+    public CustomException(ResponseCode responseCode, String additionalMessage, Throwable cause) {
+        super(additionalMessage, cause);
+        this.responseCode = responseCode;
+        this.additionalMessage = additionalMessage;
+    }
+
+    @Override
+    public String getMessage() {
+        return (additionalMessage != null)
+               ? responseCode.getMessage() + ": " + additionalMessage
+               : responseCode.getMessage();
+    }
 }

src/main/java/app/common/infrastructure/exception/CustomExceptionHandler.java

@@ -1,20 +1,86 @@
 package app.common.infrastructure.exception;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.http.HttpStatus;
+import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.ExceptionHandler;
 import org.springframework.web.bind.annotation.RestControllerAdvice;
+import org.springframework.web.servlet.NoHandlerFoundException;
+import org.springframework.web.HttpRequestMethodNotSupportedException;
+import org.springframework.web.bind.MethodArgumentNotValidException;
+import org.springframework.dao.DataAccessException;
+import org.springframework.security.access.AccessDeniedException;
+
+import javax.validation.ConstraintViolationException;
 
 import app.common.domain.model.common.BaseResponse;
 
 @RestControllerAdvice
 public class CustomExceptionHandler {
-    @ExceptionHandler(Exception.class)
-    protected BaseResponse handleException(Exception e) {
-        return BaseResponse.failResponse(e);
-    }
+
+    private static final Logger logger = LoggerFactory.getLogger(CustomExceptionHandler.class);
 
     @ExceptionHandler(CustomException.class)
-    protected BaseResponse handleCustomException(CustomException e) {
-        return BaseResponse.failResponse(e.getResponseCode());
+    protected ResponseEntity<BaseResponse> handleCustomException(CustomException e) {
+        logger.error("CustomException occurred: ", e);
+        BaseResponse response = BaseResponse.failResponse(e.getResponseCode());
+        return new ResponseEntity<>(response, HttpStatus.BAD_REQUEST);
+    }
+
+    @ExceptionHandler(IllegalArgumentException.class)
+    protected ResponseEntity<BaseResponse> handleIllegalArgumentException(IllegalArgumentException e) {
+        logger.error("IllegalArgumentException occurred: ", e);
+        BaseResponse response = BaseResponse.failResponse("INVALID_ARGUMENT");
+        return new ResponseEntity<>(response, HttpStatus.BAD_REQUEST);
+    }
+
+    @ExceptionHandler(NoHandlerFoundException.class)
+    protected ResponseEntity<BaseResponse> handleNoHandlerFoundException(NoHandlerFoundException e) {
+        logger.error("NoHandlerFoundException occurred: ", e);
+        BaseResponse response = BaseResponse.failResponse("RESOURCE_NOT_FOUND");
+        return new ResponseEntity<>(response, HttpStatus.NOT_FOUND);
+    }
+
+    @ExceptionHandler(HttpRequestMethodNotSupportedException.class)
+    protected ResponseEntity<BaseResponse> handleHttpRequestMethodNotSupportedException(HttpRequestMethodNotSupportedException e) {
+        logger.error("HttpRequestMethodNotSupportedException occurred: ", e);
+        BaseResponse response = BaseResponse.failResponse("METHOD_NOT_ALLOWED");
+        return new ResponseEntity<>(response, HttpStatus.METHOD_NOT_ALLOWED);
     }
 
+    @ExceptionHandler(MethodArgumentNotValidException.class)
+    protected ResponseEntity<BaseResponse> handleMethodArgumentNotValidException(MethodArgumentNotValidException e) {
+        logger.error("MethodArgumentNotValidException occurred: ", e);
+        BaseResponse response = BaseResponse.failResponse("INVALID_INPUT");
+        return new ResponseEntity<>(response, HttpStatus.BAD_REQUEST);
+    }
+
+    @ExceptionHandler(ConstraintViolationException.class)
+    protected ResponseEntity<BaseResponse> handleConstraintViolationException(ConstraintViolationException e) {
+        logger.error("ConstraintViolationException occurred: ", e);
+        BaseResponse response = BaseResponse.failResponse("CONSTRAINT_VIOLATION");
+        return new ResponseEntity<>(response, HttpStatus.BAD_REQUEST);
+    }
+
+    @ExceptionHandler(DataAccessException.class)
+    protected ResponseEntity<BaseResponse> handleDataAccessException(DataAccessException e) {
+        logger.error("DataAccessException occurred: ", e);
+        BaseResponse response = BaseResponse.failResponse("DATABASE_ERROR");
+        return new ResponseEntity<>(response, HttpStatus.INTERNAL_SERVER_ERROR);
+    }
+
+    @ExceptionHandler(AccessDeniedException.class)
+    protected ResponseEntity<BaseResponse> handleAccessDeniedException(AccessDeniedException e) {
+        logger.error("AccessDeniedException occurred: ", e);
+        BaseResponse response = BaseResponse.failResponse("ACCESS_DENIED");
+        return new ResponseEntity<>(response, HttpStatus.FORBIDDEN);
+    }
+
+    @ExceptionHandler(Exception.class)
+    protected ResponseEntity<BaseResponse> handleException(Exception e) {
+        logger.error("Unexpected exception occurred: ", e);
+        BaseResponse response = BaseResponse.failResponse("INTERNAL_SERVER_ERROR");
+        return new ResponseEntity<>(response, HttpStatus.INTERNAL_SERVER_ERROR);
+    }
 }

src/main/java/app/member/domain/service/MemberService.java

@@ -24,23 +24,19 @@ public class MemberService {
 
     @Transactional
     public CreateMemberVo createMember(CreateMemberDto dto) {
-        try {
-            Member member = Member.builder()
-                            .name(dto.getName())
-                            .email(dto.getEmail())
-                            .role(dto.getRole())
-                            .build();
-            Member result = memberRepository.save(member);
-            log.info("### 회원 생성 결과: {}", result);
+        validateNewMember(dto);
 
-            return CreateMemberVo.toVo(result);
-        } catch (DataIntegrityViolationException e) {
-            throw new CustomException(ResponseCode.CONFLICT_DATA);
-        } catch (CustomException e) {
-            throw new CustomException(e.getResponseCode());
-        } catch (Exception e) {
-            throw e;
-        }
+        Member member = Member.builder()
+                        .name(dto.getName())
+                        .email(dto.getEmail())
+                        .role(dto.getRole())
+                        .build();
+
+        Member savedMember = memberRepository.save(member);
+
+        log.info("New member created with ID: {}", savedMember.getId());
+
+        return CreateMemberVo.toVo(savedMember);
     }
 
     @Transactional(readOnly = true)