CM-2345: Extracted error message into resources.

Author: yaricom

comet-java-client/src/main/java/ml/comet/experiment/impl/RestApiClient.java

@@ -116,6 +116,8 @@
 import static ml.comet.experiment.impl.constants.QueryParamName.TYPE;
 import static ml.comet.experiment.impl.constants.QueryParamName.WORKSPACE_NAME;
 import static ml.comet.experiment.impl.http.ConnectionUtils.checkResponseStatus;
+import static ml.comet.experiment.impl.resources.LogMessages.NO_RESPONSE_RETURNED_BY_REMOTE_ENDPOINT;
+import static ml.comet.experiment.impl.resources.LogMessages.getString;
 import static ml.comet.experiment.impl.utils.RestApiUtils.artifactDownloadAssetParams;
 import static ml.comet.experiment.impl.utils.RestApiUtils.artifactVersionDetailsParams;
 import static ml.comet.experiment.impl.utils.RestApiUtils.artifactVersionFilesParams;
@@ -497,15 +499,15 @@ private Single<RestApiResponse> singleFromSyncPostWithRetriesEmptyBody(@NonNull
         return this.connection.sendPostWithRetries(JsonUtils.toJson(payload), endpoint, true)
                 .map(body -> Single.just(new RestApiResponse(200, body)))
                 .orElse(Single.error(new CometApiException(
-                        String.format("No response was returned by endpoint: %s", endpoint))));
+                        getString(NO_RESPONSE_RETURNED_BY_REMOTE_ENDPOINT, endpoint))));
     }
 
     private Single<RestApiResponse> singleFromSyncGetWithRetries(@NonNull String endpoint,
                                                                  @NonNull Map<QueryParamName, String> params) {
         return this.connection.sendGetWithRetries(endpoint, params, true)
                 .map(body -> Single.just(new RestApiResponse(200, body)))
                 .orElse(Single.error(new CometApiException(
-                        String.format("No response was returned by endpoint: %s", endpoint))));
+                        getString(NO_RESPONSE_RETURNED_BY_REMOTE_ENDPOINT, endpoint))));
     }
 
     private <T> Single<T> singleFromSyncGetWithRetries(@NonNull String endpoint,

comet-java-client/src/main/java/ml/comet/experiment/impl/resources/LogMessages.java

@@ -98,6 +98,7 @@ public class LogMessages {
     public static final String FAILED_TO_UPDATE_REGISTRY_MODEL_VERSION = "FAILED_TO_UPDATE_REGISTRY_MODEL_VERSION";
     public static final String REGISTRY_MODEL_VERSION_NOT_FOUND = "REGISTRY_MODEL_VERSION_NOT_FOUND";
     public static final String FAILED_TO_DELETE_REGISTRY_MODEL = "FAILED_TO_DELETE_REGISTRY_MODEL";
+    public static final String NO_RESPONSE_RETURNED_BY_REMOTE_ENDPOINT = "NO_RESPONSE_RETURNED_BY_REMOTE_ENDPOINT";
 
 
     /**

comet-java-client/src/main/resources/messages.properties

@@ -83,3 +83,4 @@ FAILED_TO_UPDATE_REGISTRY_MODEL=Failed to update registry model '%s/%s' with dat
 FAILED_TO_UPDATE_REGISTRY_MODEL_VERSION=Failed to update registry model's version '%s/%s:%s' with data: '%s'.
 REGISTRY_MODEL_VERSION_NOT_FOUND=Version '%s' of the registry model '%s/%s' is not found.
 FAILED_TO_DELETE_REGISTRY_MODEL=Failed to delete registry model '%s/%s'.
+NO_RESPONSE_RETURNED_BY_REMOTE_ENDPOINT=No response was returned by endpoint '%s'