Skip to content

Commit c1d4e65

Browse files
authored
Merge pull request #54 from comet-ml/bump-version-1.19
[NA]: Bump to version 1.1.9
2 parents 5568965 + 10757f9 commit c1d4e65

File tree

5 files changed

+22
-7
lines changed

5 files changed

+22
-7
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<dependency>
1313
<groupId>ml.comet</groupId>
1414
<artifactId>comet-java-client</artifactId>
15-
<version>1.1.8</version>
15+
<version>1.1.9</version>
1616
</dependency>
1717
</dependencies>
1818
```

comet-examples/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<parent>
88
<artifactId>comet-java-sdk</artifactId>
99
<groupId>ml.comet</groupId>
10-
<version>1.1.8-SNAPSHOT</version>
10+
<version>1.1.9-SNAPSHOT</version>
1111
</parent>
1212

1313
<properties>

comet-java-client/pom.xml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<parent>
88
<groupId>ml.comet</groupId>
99
<artifactId>comet-java-sdk</artifactId>
10-
<version>1.1.8-SNAPSHOT</version>
10+
<version>1.1.9-SNAPSHOT</version>
1111
</parent>
1212

1313
<dependencyManagement>
@@ -77,12 +77,12 @@
7777
<dependency>
7878
<groupId>org.slf4j</groupId>
7979
<artifactId>slf4j-api</artifactId>
80-
<version>1.7.33</version>
80+
<version>1.7.35</version>
8181
</dependency>
8282
<dependency>
8383
<groupId>org.slf4j</groupId>
8484
<artifactId>slf4j-simple</artifactId>
85-
<version>1.7.33</version>
85+
<version>1.7.35</version>
8686
</dependency>
8787

8888
<!-- tests -->
@@ -94,7 +94,7 @@
9494
<dependency>
9595
<groupId>org.mockito</groupId>
9696
<artifactId>mockito-inline</artifactId>
97-
<version>4.2.0</version>
97+
<version>4.3.1</version>
9898
<scope>test</scope>
9999
</dependency>
100100
<dependency>
@@ -107,6 +107,7 @@
107107
<groupId>org.apache.maven.plugins</groupId>
108108
<artifactId>maven-surefire-plugin</artifactId>
109109
<version>3.0.0-M5</version>
110+
<scope>test</scope>
110111
</dependency>
111112
</dependencies>
112113

comet-java-client/src/test/java/ml/comet/experiment/impl/OnlineExperimentTest.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,15 @@
55
import ml.comet.experiment.OnlineExperiment;
66
import ml.comet.experiment.asset.LoggedExperimentAsset;
77
import ml.comet.experiment.context.ExperimentContext;
8+
import ml.comet.experiment.exception.CometGeneralException;
89
import ml.comet.experiment.model.ExperimentMetadata;
910
import ml.comet.experiment.model.GitMetaData;
1011
import ml.comet.experiment.model.Value;
1112
import org.apache.commons.lang3.StringUtils;
1213
import org.junit.jupiter.api.DisplayName;
1314
import org.junit.jupiter.api.Tag;
1415
import org.junit.jupiter.api.Test;
16+
import org.junit.jupiter.api.Timeout;
1517

1618
import java.time.Instant;
1719
import java.util.HashMap;
@@ -26,12 +28,15 @@
2628
import static ml.comet.experiment.impl.TestUtils.SOME_FULL_CONTEXT;
2729
import static ml.comet.experiment.impl.TestUtils.awaitForCondition;
2830
import static ml.comet.experiment.impl.asset.AssetType.SOURCE_CODE;
31+
import static ml.comet.experiment.impl.resources.LogMessages.FAILED_REGISTER_EXPERIMENT;
32+
import static ml.comet.experiment.impl.resources.LogMessages.getString;
2933
import static ml.comet.experiment.impl.utils.CometUtils.fullMetricName;
3034
import static org.junit.jupiter.api.Assertions.assertEquals;
3135
import static org.junit.jupiter.api.Assertions.assertFalse;
3236
import static org.junit.jupiter.api.Assertions.assertNotEquals;
3337
import static org.junit.jupiter.api.Assertions.assertNotNull;
3438
import static org.junit.jupiter.api.Assertions.assertNull;
39+
import static org.junit.jupiter.api.Assertions.assertThrows;
3540
import static org.junit.jupiter.api.Assertions.assertTrue;
3641
import static org.junit.jupiter.api.Assertions.fail;
3742

@@ -506,6 +511,15 @@ public void testLogAndGetRawCode() {
506511
}
507512
}
508513

514+
@Test
515+
@Timeout(60)
516+
public void testCreateExperiment_wrongApiKey() {
517+
String wrongApiKey = "not existing API key";
518+
CometGeneralException ex = assertThrows(CometGeneralException.class, () ->
519+
OnlineExperimentImpl.builder().withApiKey(wrongApiKey).build());
520+
assertEquals(getString(FAILED_REGISTER_EXPERIMENT), ex.getMessage());
521+
}
522+
509523
static final class OnCompleteAction implements Action, BooleanSupplier {
510524
boolean completed;
511525

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<groupId>ml.comet</groupId>
66
<artifactId>comet-java-sdk</artifactId>
77
<packaging>pom</packaging>
8-
<version>1.1.8-SNAPSHOT</version>
8+
<version>1.1.9-SNAPSHOT</version>
99

1010
<name>${project.groupId}:${project.artifactId}</name>
1111
<description>https://www.comet.ml Java client lib</description>

0 commit comments

Comments
 (0)