Skip to content

Commit 80ee4cb

Browse files
committed
Cleanup var environment default in submodules and update readmes
1 parent 1c8b492 commit 80ee4cb

File tree

8 files changed

+7
-12
lines changed

8 files changed

+7
-12
lines changed

comet-infrastructure/modules/comet_ec2/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ No modules.
4949
| <a name="input_comet_ec2_subnet"></a> [comet\_ec2\_subnet](#input\_comet\_ec2\_subnet) | ID of VPC subnet to launch EC2 instance in | `string` | n/a | yes |
5050
| <a name="input_comet_ec2_volume_size"></a> [comet\_ec2\_volume\_size](#input\_comet\_ec2\_volume\_size) | Size, in gibibytes (GiB), for the EC2 instance root volume | `number` | n/a | yes |
5151
| <a name="input_comet_ec2_volume_type"></a> [comet\_ec2\_volume\_type](#input\_comet\_ec2\_volume\_type) | EBS volume type for the EC2 instance root volume | `string` | n/a | yes |
52-
| <a name="input_environment"></a> [environment](#input\_environment) | Deployment environment, i.e. dev/stage/prod, etc | `string` | `"dev"` | no |
52+
| <a name="input_environment"></a> [environment](#input\_environment) | Deployment environment, i.e. dev/stage/prod, etc | `string` | n/a | yes |
5353
| <a name="input_s3_enabled"></a> [s3\_enabled](#input\_s3\_enabled) | Indicates if S3 bucket is being provisioned for Comet | `bool` | `null` | no |
5454
| <a name="input_vpc_id"></a> [vpc\_id](#input\_vpc\_id) | ID of the VPC that will contain the provisioned resources | `string` | n/a | yes |
5555

@@ -59,4 +59,4 @@ No modules.
5959
|------|-------------|
6060
| <a name="output_comet_ec2_instance_id"></a> [comet\_ec2\_instance\_id](#output\_comet\_ec2\_instance\_id) | ID of the EC2 instance |
6161
| <a name="output_comet_ec2_public_ip"></a> [comet\_ec2\_public\_ip](#output\_comet\_ec2\_public\_ip) | Public IP of the EIP associated with the EC2 instance |
62-
| <a name="output_comet_ec2_sg_id"></a> [comet\_ec2\_sg\_id](#output\_comet\_ec2\_sg\_id) | ID of the security group associated with the EC2 instance |
62+
| <a name="output_comet_ec2_sg_id"></a> [comet\_ec2\_sg\_id](#output\_comet\_ec2\_sg\_id) | ID of the security group associated with the EC2 instance |

comet-infrastructure/modules/comet_ec2/variables.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
variable "environment" {
22
description = "Deployment environment, i.e. dev/stage/prod, etc"
33
type = string
4-
default = "dev"
54
}
65

76
variable "alb_enabled" {

comet-infrastructure/modules/comet_ec2_alb/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929

3030
| Name | Description | Type | Default | Required |
3131
|------|-------------|------|---------|:--------:|
32-
| <a name="input_environment"></a> [environment](#input\_environment) | Deployment environment, i.e. dev/stage/prod, etc | `string` | `"dev"` | no |
32+
| <a name="input_environment"></a> [environment](#input\_environment) | Deployment environment, i.e. dev/stage/prod, etc | `string` | n/a | yes |
3333
| <a name="input_public_subnets"></a> [public\_subnets](#input\_public\_subnets) | Subnets specified for ALB | `list(any)` | n/a | yes |
3434
| <a name="input_ssl_certificate_arn"></a> [ssl\_certificate\_arn](#input\_ssl\_certificate\_arn) | ARN of the ACM certificate to use for the ALB | `string` | n/a | yes |
3535
| <a name="input_vpc_id"></a> [vpc\_id](#input\_vpc\_id) | ID of the VPC that will contain the provisioned resources | `string` | n/a | yes |
@@ -39,4 +39,4 @@
3939
| Name | Description |
4040
|------|-------------|
4141
| <a name="output_alb_dns_name"></a> [alb\_dns\_name](#output\_alb\_dns\_name) | DNS name of the ALB |
42-
| <a name="output_comet_alb_sg"></a> [comet\_alb\_sg](#output\_comet\_alb\_sg) | ID of the security group created for the ALB |
42+
| <a name="output_comet_alb_sg"></a> [comet\_alb\_sg](#output\_comet\_alb\_sg) | ID of the security group created for the ALB |

comet-infrastructure/modules/comet_ec2_alb/variables.tf

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
variable "environment" {
22
description = "Deployment environment, i.e. dev/stage/prod, etc"
33
type = string
4-
default = "dev"
54
}
65

76
variable "vpc_id" {
87
description = "ID of the VPC that will contain the provisioned resources"
98
type = string
10-
#default = ""
119
}
1210

1311
variable "public_subnets" {

comet-infrastructure/modules/comet_eks/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
| <a name="input_eks_mng_name"></a> [eks\_mng\_name](#input\_eks\_mng\_name) | Name for the EKS managed nodegroup | `string` | n/a | yes |
4343
| <a name="input_eks_node_types"></a> [eks\_node\_types](#input\_eks\_node\_types) | Node instance types for EKS managed node group | `list(string)` | n/a | yes |
4444
| <a name="input_eks_private_subnets"></a> [eks\_private\_subnets](#input\_eks\_private\_subnets) | IDs of private subnets within the VPC | `list(string)` | n/a | yes |
45-
| <a name="input_environment"></a> [environment](#input\_environment) | Deployment environment, i.e. dev/stage/prod, etc | `string` | `"dev"` | no |
45+
| <a name="input_environment"></a> [environment](#input\_environment) | Deployment environment, i.e. dev/stage/prod, etc | `string` | n/a | yes |
4646
| <a name="input_s3_enabled"></a> [s3\_enabled](#input\_s3\_enabled) | Indicates if S3 bucket is being provisioned for Comet | `bool` | `null` | no |
4747
| <a name="input_vpc_id"></a> [vpc\_id](#input\_vpc\_id) | ID of the VPC that the EKS cluster will be launched in | `string` | n/a | yes |
4848

@@ -53,4 +53,4 @@
5353
| <a name="output_cluster_certificate_authority_data"></a> [cluster\_certificate\_authority\_data](#output\_cluster\_certificate\_authority\_data) | n/a |
5454
| <a name="output_cluster_endpoint"></a> [cluster\_endpoint](#output\_cluster\_endpoint) | n/a |
5555
| <a name="output_cluster_name"></a> [cluster\_name](#output\_cluster\_name) | n/a |
56-
| <a name="output_nodegroup_sg_id"></a> [nodegroup\_sg\_id](#output\_nodegroup\_sg\_id) | n/a |
56+
| <a name="output_nodegroup_sg_id"></a> [nodegroup\_sg\_id](#output\_nodegroup\_sg\_id) | n/a |

comet-infrastructure/modules/comet_eks/variables.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
variable "environment" {
22
description = "Deployment environment, i.e. dev/stage/prod, etc"
33
type = string
4-
default = "dev"
54
}
65

76
variable "vpc_id" {

comet-infrastructure/modules/comet_elasticache/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ No modules.
3232
| <a name="input_elasticache_num_cache_nodes"></a> [elasticache\_num\_cache\_nodes](#input\_elasticache\_num\_cache\_nodes) | Number of nodes in the Elasticache cluster | `number` | n/a | yes |
3333
| <a name="input_elasticache_param_group_name"></a> [elasticache\_param\_group\_name](#input\_elasticache\_param\_group\_name) | Name for the Elasticache cluster parameter group | `string` | n/a | yes |
3434
| <a name="input_elasticache_private_subnets"></a> [elasticache\_private\_subnets](#input\_elasticache\_private\_subnets) | IDs of private subnets within the VPC | `list(string)` | n/a | yes |
35-
| <a name="input_environment"></a> [environment](#input\_environment) | Deployment environment, i.e. dev/stage/prod, etc | `string` | `"dev"` | no |
35+
| <a name="input_environment"></a> [environment](#input\_environment) | Deployment environment, i.e. dev/stage/prod, etc | `string` | n/a | yes |
3636
| <a name="input_vpc_id"></a> [vpc\_id](#input\_vpc\_id) | ID of the VPC that will contain the provisioned resources | `string` | n/a | yes |
3737

3838
## Outputs

comet-infrastructure/modules/comet_elasticache/variables.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
variable "environment" {
22
description = "Deployment environment, i.e. dev/stage/prod, etc"
33
type = string
4-
default = "dev"
54
}
65

76
variable "vpc_id" {

0 commit comments

Comments
 (0)