Built-in nodes VS Built-in extra nodes

[rhalaly]

What is the difference between the built-in nodes placed in nodes.py and the built-in extra nodes placed in comfy_extra directory? Are they load differently?

[ltdrdata]

comfy_extras is like built-in custom nodes. If possible, avoid modifying nodes.py and create additional core nodes here instead.

[rhalaly]

What is the logic behind this decision to split them? Why not make all the "built-in" core nodes in the same place?

[ltdrdata]

The nodes.py file is already large enough. If we keep adding nodes to it, it will become completely unmanageable.

[rhalaly]

Yeah, I just don't understand why they maintain both, and not moving all the classes from node.py to dedicated nodes in comfy_extras and keep only the loading node logic in node.py. It feels much more natural and maintainable.

I believe that there is a concrete reason they decided to do that like it is now

[ltdrdata]

Yeah, I just don't understand why they maintain both, and not moving all the classes from node.py to dedicated nodes in comfy_extras and keep only the loading node logic in node.py. It feels much more natural and maintainable.

I believe that there is a concrete reason they decided to do that like it is now

If we do that, all custom nodes that depend on nodes.py will collapse instantly.
The benefits of moving it are extremely minimal.

[rhalaly]

Ahh, so if I understand you correctly, you keep in nodes.py core nodes that are also can be reused in custom nodes, by inheritance, I guess.

If this is correct, this is what I missed