Skip to content

Default parameters lead to pickle deserialization vulnerability #5097

@l1k3beef

Description

@l1k3beef

Expected Behavior

This is the reference document of pytorch. Use the safe parameter weights_only=True
image

Actual Behavior

image
image
image
image
default to set safe_load=False which leading to pickle deserialization vulnerability

Steps to Reproduce

  1. Comfyui provides a rich set of node nodes, and there are many interfaces that can download models from remote locations such as huggingface, github, etc. to the server.
  2. When a malicious model is constructed and uploaded to the server, and then the checkpointloadersimple node is used, remote code execution can occur, causing serious network security hazards.

image

Debug Logs

refer to steps to reproduce

Other

As a very influential open source project, we suggest you enable the Security Policy feature of GitHub. For sensitive information, you can communicate through other channels instead of issues.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Potential BugUser is reporting a bug. This should be tested.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions