Skip to content

[V3] convert nodes_compositing.py to V3 schema #10174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[V3] convert nodes_compositing.py to V3 schema #10174

wants to merge 1 commit into from
+69 −60

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Oct 3, 2025

Nodes were tested after conversion:

Screenshot From 2025-10-03 11-04-48

These changes were required to make V3 nodes work, as io.NodeOutput expect *args and not tuple(was not possible to do return io.NodeOutput(result)

result = (torch.stack(out_images), 1.0 - torch.stack(out_alphas))
return result

->

return io.NodeOutput(torch.stack(out_images), torch.stack(out_alphas))

Git diff:

diff --git a/v3_object_info.json b/master_object_info.json
index 4b7579d..35fd591 100644
--- a/v3_object_info.json
+++ b/master_object_info.json
@@ -5271,46 +5271,40 @@
         "input": {
             "required": {
                 "source": [
-                    "IMAGE",
-                    {}
+                    "IMAGE"
                 ],
                 "source_alpha": [
-                    "MASK",
-                    {}
+                    "MASK"
                 ],
                 "destination": [
-                    "IMAGE",
-                    {}
+                    "IMAGE"
                 ],
                 "destination_alpha": [
-                    "MASK",
-                    {}
+                    "MASK"
                 ],
                 "mode": [
-                    "COMBO",
+                    [
+                        "ADD",
+                        "CLEAR",
+                        "DARKEN",
+                        "DST",
+                        "DST_ATOP",
+                        "DST_IN",
+                        "DST_OUT",
+                        "DST_OVER",
+                        "LIGHTEN",
+                        "MULTIPLY",
+                        "OVERLAY",
+                        "SCREEN",
+                        "SRC",
+                        "SRC_ATOP",
+                        "SRC_IN",
+                        "SRC_OUT",
+                        "SRC_OVER",
+                        "XOR"
+                    ],
                     {
-                        "default": "DST",
-                        "multiselect": false,
-                        "options": [
-                            "ADD",
-                            "CLEAR",
-                            "DARKEN",
-                            "DST",
-                            "DST_ATOP",
-                            "DST_IN",
-                            "DST_OUT",
-                            "DST_OVER",
-                            "LIGHTEN",
-                            "MULTIPLY",
-                            "OVERLAY",
-                            "SCREEN",
-                            "SRC",
-                            "SRC_ATOP",
-                            "SRC_IN",
-                            "SRC_OUT",
-                            "SRC_OVER",
-                            "XOR"
-                        ]
+                        "default": "DST"
                     }
                 ]
             }
@@ -5336,26 +5330,18 @@
             "IMAGE",
             "MASK"
         ],
-        "output_tooltips": [
-            null,
-            null
-        ],
         "name": "PorterDuffImageComposite",
         "display_name": "Porter-Duff Image Composite",
         "description": "",
         "python_module": "comfy_extras.nodes_compositing",
         "category": "mask/compositing",
-        "output_node": false,
-        "deprecated": false,
-        "experimental": false,
-        "api_node": false
+        "output_node": false
     },
     "SplitImageWithAlpha": {
         "input": {
             "required": {
                 "image": [
-                    "IMAGE",
-                    {}
+                    "IMAGE"
                 ]
             }
         },
@@ -5376,30 +5362,21 @@
             "IMAGE",
             "MASK"
         ],
-        "output_tooltips": [
-            null,
-            null
-        ],
         "name": "SplitImageWithAlpha",
         "display_name": "Split Image with Alpha",
         "description": "",
         "python_module": "comfy_extras.nodes_compositing",
         "category": "mask/compositing",
-        "output_node": false,
-        "deprecated": false,
-        "experimental": false,
-        "api_node": false
+        "output_node": false
     },
     "JoinImageWithAlpha": {
         "input": {
             "required": {
                 "image": [
-                    "IMAGE",
-                    {}
+                    "IMAGE"
                 ],
                 "alpha": [
-                    "MASK",
-                    {}
+                    "MASK"
                 ]
             }
         },
@@ -5418,18 +5395,12 @@
         "output_name": [
             "IMAGE"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "JoinImageWithAlpha",
         "display_name": "Join Image with Alpha",
         "description": "",
         "python_module": "comfy_extras.nodes_compositing",
         "category": "mask/compositing",
-        "output_node": false,
-        "deprecated": false,
-        "experimental": false,
-        "api_node": false
+        "output_node": false
     },
     "RebatchLatents": {
         "input": {

@bigcat88 bigcat88 requested a review from Kosinkadink as a code owner October 3, 2025 08:08
@bigcat88
Copy link
Contributor Author

bigcat88 commented Oct 3, 2025

+label: Core

@comfy-pr-bot comfy-pr-bot added the Core Core team dependency label Oct 3, 2025
This was referenced Oct 3, 2025
Open
Open
Open
Open
@Kosinkadink
Copy link
Collaborator

Kosinkadink commented Oct 3, 2025 •
edited
Loading

Node authors notified, will merge on Wednesday Oct. 8th with the rest of the scheduled V3 PR batch.

@Kosinkadink Kosinkadink added the Scheduled Merge PR is reviewed and ready, but will be merged at a specific time. label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kosinkadink Kosinkadink Awaiting requested review from Kosinkadink Kosinkadink is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Core Core team dependency Scheduled Merge PR is reviewed and ready, but will be merged at a specific time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bigcat88 @Kosinkadink @comfy-pr-bot