-
Notifications
You must be signed in to change notification settings - Fork 11.4k
BBox widget #11594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
BBox widget #11594
Conversation
|
@jtydhr88 can you fix the conflicts when you get a moment? |
|
fixed conflicts |
|
We should mark this as draft until the FE is ready |
…eCrop (#7825) ## Summary Another implementation for image crop node, alternative for #7014 As discussed with @christian-byrne and @DrJKL we could have single widget - IMAGECROP with 4 ints and UI preview. However, this solution requires changing the definition of image crop node in BE (sent [here](Comfy-Org/ComfyUI#11594)), which will break the exsiting workflow, also it would not allow connect separate int node as input, I am not sure it is a good idea. So I keep two PRs openned for references ## Screenshots https://github.com/user-attachments/assets/fde6938c-4395-48f6-ac05-6282c5eb8157 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7825-feat-Add-visual-crop-preview-widget-for-ImageCrop-node-widget-ImageCrop-2dc6d73d3650812bb8a2cdff4615032b) by [Unito](https://www.unito.io)
| crop = execute # TODO: remove | ||
|
|
||
|
|
||
| class IntToBoundingBox(IO.ComfyNode): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you structure this like the Primitive nodes?
Just BoundingBox with 4 widgets that can then be linked.
| def as_dict(self): | ||
| return super().as_dict() | ||
|
|
||
| @comfytype(io_type="BOUNDINGBOX") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: BOUNDING_BOX?
BE change for Comfy-Org/ComfyUI_frontend#7825, please check the details in the FE PR
As discussed with @christian-byrne and @DrJKL we could have single widget - IMAGECROP with 4 ints and UI preview.
However, this solution requires changing the definition of image crop node in BE here, which will break the exsiting workflow, also it would not allow connect separate int node as input, I am not sure it is a good idea.
So I provided two solution for this.