Skip to content

Conversation

@jtydhr88
Copy link
Contributor

@jtydhr88 jtydhr88 commented Jan 2, 2026

BE change for Comfy-Org/ComfyUI_frontend#7825, please check the details in the FE PR

As discussed with @christian-byrne and @DrJKL we could have single widget - IMAGECROP with 4 ints and UI preview.

However, this solution requires changing the definition of image crop node in BE here, which will break the exsiting workflow, also it would not allow connect separate int node as input, I am not sure it is a good idea.

So I provided two solution for this.

@christian-byrne
Copy link
Contributor

@jtydhr88 can you fix the conflicts when you get a moment?

@jtydhr88
Copy link
Contributor Author

fixed conflicts

@christian-byrne
Copy link
Contributor

We should mark this as draft until the FE is ready

@jtydhr88 jtydhr88 marked this pull request as draft January 16, 2026 01:34
@jtydhr88 jtydhr88 changed the title image crop widget BBox widget Jan 16, 2026
jtydhr88 added a commit to Comfy-Org/ComfyUI_frontend that referenced this pull request Jan 17, 2026
…eCrop (#7825)

## Summary

Another implementation for image crop node, alternative for
#7014
As discussed with @christian-byrne and @DrJKL we could have single
widget - IMAGECROP with 4 ints and UI preview.

However, this solution requires changing the definition of image crop
node in BE (sent
[here](Comfy-Org/ComfyUI#11594)), which
will break the exsiting workflow, also it would not allow connect
separate int node as input, I am not sure it is a good idea.

So I keep two PRs openned for references

## Screenshots


https://github.com/user-attachments/assets/fde6938c-4395-48f6-ac05-6282c5eb8157

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7825-feat-Add-visual-crop-preview-widget-for-ImageCrop-node-widget-ImageCrop-2dc6d73d3650812bb8a2cdff4615032b)
by [Unito](https://www.unito.io)
@jtydhr88 jtydhr88 marked this pull request as ready for review January 17, 2026 22:22
crop = execute # TODO: remove


class IntToBoundingBox(IO.ComfyNode):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you structure this like the Primitive nodes?
Just BoundingBox with 4 widgets that can then be linked.

def as_dict(self):
return super().as_dict()

@comfytype(io_type="BOUNDINGBOX")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: BOUNDING_BOX?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Core team dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants