Support the LTXV 2 model.

[comfyanonymous]

No description provided.

[GlamoramaAttack]

Custom-node MagCache fails to load because...

File "D:\ComfyUI\custom_nodes\ComfyUI-MagCache_init_.py", line 1, in
from .nodes import NODE_CLASS_MAPPINGS as NODES_CLASS, NODE_DISPLAY_NAME_MAPPINGS as NODES_DISPLAY
File "D:\ComfyUI\custom_nodes\ComfyUI-MagCache\nodes.py", line 13, in
from comfy.ldm.lightricks.model import precompute_freqs_cis

ImportError: cannot import name 'precompute_freqs_cis' from 'comfy.ldm.lightricks.model' (D:\ComfyUI\comfy\ldm\lightricks\model.py)

Line 13 in nodes.py of ComfyUI-MagCache is...
from comfy.ldm.lightricks.model import precompute_freqs_cis

... I think, whatever change was made to comfy\ldm\lightricks\model.py, it should not affect other custom-nodes that worked prior with the dependence on that model.py file in ComfyUI\comfy\ldm\lightricks without a warning to users of that MAGCache node or or other nodes who may be affected.

[mahmoudimus]

I agree @GlamoramaAttack. Here's a bridge in the meantime:

import math
import torch

from comfy.ldm.lightricks.model import (
    generate_freq_grid_np,
    generate_freq_grid_pytorch,
    generate_freqs,
    interleaved_freqs_cis,
)

def precompute_freqs_cis_bridge(
    indices_grid,
    dim,
    out_dtype,
    theta=10000.0,
    max_pos=(20, 2048, 2048),
    *,
    use_middle_indices_grid=False,
    num_attention_heads=None,
):
    """
    Bridge: old `precompute_freqs_cis(...)` behavior, implemented via the new API.

    Returns old-style `pe`:
      [B, 1, N, dim//2, 2, 2]
    """
    device = indices_grid.device
    max_pos_count = len(max_pos)
    n_elem = 2 * max_pos_count
    pad_size = dim % n_elem

    # 1) Generate base freqs grid "indices"
    # CPU can use cached numpy path; GPU uses pytorch path.
    if device.type == "cpu":
        indices = generate_freq_grid_np(theta, max_pos_count, dim)
        indices = indices.to(device=device)
    else:
        indices = generate_freq_grid_pytorch(theta, max_pos_count, dim, device=device)

    # 2) Raw freqs per token (matches the old freqs construction)
    freqs = generate_freqs(
        indices=indices,
        indices_grid=indices_grid,
        max_pos=max_pos,
        use_middle_indices_grid=use_middle_indices_grid,
    )

    # 3) Interleave + pad exactly like the old function did
    cos_i, sin_i = interleaved_freqs_cis(freqs, pad_size=pad_size)

    # Old code collapsed duplicated pairs -> [B, N, dim//2]
    cos_vals = cos_i.reshape(*cos_i.shape[:2], -1, 2)[..., 0].to(out_dtype)
    sin_vals = sin_i.reshape(*sin_i.shape[:2], -1, 2)[..., 0].to(out_dtype)

    # 4) Build [[cos, -sin],[sin, cos]] and add head dim (1) like before
    pe = torch.stack(
        [
            torch.stack([cos_vals, -sin_vals], dim=-1),
            torch.stack([sin_vals, cos_vals], dim=-1),
        ],
        dim=-2,
    ).unsqueeze(
        1
    )  # [B, 1, N, dim//2, 2, 2]

    return pe

[GlamoramaAttack]

Here's a bridge in the meantime:

return pe

And after "return pe"? I don't have a clue how edit or write a Python script. My guess is it continues here:

import comfy.ldm.common_dit
import comfy.model_management as mm
import numpy as np

from torch import Tensor
from einops import repeat
from typing import Optional
from unittest.mock import patc

? But line 13 in the original nodes.py:

from comfy.ldm.lightricks.model import precompute_freqs_cis

also needs to be deleted? If not there is an error - but after erasing the line another error appears:

File "D:\ComfyUI\custom_nodes\ComfyUI-MagCache_init_.py", line 2, in
from .nodes_calibration import NODE_CLASS_MAPPINGS as Cal_NODES_CLASS, NODE_DISPLAY_NAME_MAPPINGS as Cal_NODES_DISPLAY
File "D:\ComfyUI\custom_nodes\ComfyUI-MagCache\nodes_calibration.py", line 13, in
from comfy.ldm.lightricks.model import precompute_freqs_cis
ImportError: cannot import name 'precompute_freqs_cis' from 'comfy.ldm.lightricks.model' (D:\ComfyUI\comfy\ldm\lightricks\model.py)

Cannot import D:\ComfyUI\custom_nodes\ComfyUI-MagCache module for custom nodes: cannot import name 'precompute_freqs_cis' from 'comfy.ldm.lightricks.model' (D:\ComfyUI\comfy\ldm\lightricks\model.py)

So, just another guess: the nodes_calibration.py- file needs the same change as nodes.py? I did that: no more error message about it and the MagCache node loads.

[zwukong]

workflow please😄。Looks like we don't need a custom node as https://github.com/Lightricks/ComfyUI-LTXVideo