Lint all unused variables #5989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
force-pushed
the
unused_var
branch
from
f33e31e to
006dd0a
Compare
huchenlei
requested review from
Kosinkadink,
comfyanonymous,
ltdrdata,
pythongosssss,
robinjhuang and
yoland68
as code owners
huchenlei
commented
Dec 10, 2024
| self.control_model.to(comfy.model_management.get_torch_device()) | ||
| diffusion_model = model.diffusion_model | ||
| sd = diffusion_model.state_dict() | ||
| cm = self.control_model.state_dict() |
Contributor
Author
There was a problem hiding this comment.
This should improve performance as state_dict is an expensive call.
| # self.dropout = nn.Dropout(config.dropout_rate) | ||
|
|
||
| def forward(self, x, mask=None, past_bias=None, optimized_attention=None): | ||
| normed_hidden_states = self.layer_norm(x) |
Contributor
Author
There was a problem hiding this comment.
Avoided duplicated call to self.layer_norm(x)
comfyanonymous
added
the
Run-CI-Test
Contributor
|
(Automated Bot Message) CI Tests are running, you can view the results at https://ci.comfy.org/?branch=5989%2Fmerge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5987
This PR enforces F841 (Unused variable).