Feat/#5/map collections (#11)

* #5 - initialize tests for map collections

* #5 - map functionality wip

* #5 - finished comfyMap impl

* #5 - introduced internal interfaces

* #5 - introduced extractors for underlying structures in tests

* #5 - reorganize fold/reduce to only use underlying slices

* #5 - initial mapcmp is ready; introduced BasePairs interface; extracted valuesCounter

* #5 - all `map` cases covered also for `mapcmp`

* #7 - remove `ToSlice` and `ToMap` test coupling for map and cmpmap

* #5 - non-mutable cmp tests done

* #5 - Complete cmp tests, add mutable sort, and refactor test builders

* #10 - added conditional valuesCounter tests to cmpMap

* #9, #10 - Implement value counting and use nil slices for empty collections

* #7, #5 - remove test coupling; some fixes; full coverage of methods

* #5 - fix linter errors

* #5 - cr fixes

* #5 - valuesCounter optimize; add tests

* #5 - valuesCounter test update

Author: maciej-sz

.idea/collections.iml

@@ -1,11 +1,33 @@
-= Comfy Gopher
+= What is Comfy Gopher?
 
-*A Set of general-purpose Tools, Utilities, and Data Structures for Comfortable Development*
+*Comfy Gopher is a Set of general-purpose Tools, Utilities, and Data Structures for Comfortable Development*
 
 These tools prioritize speed and ease of development over strict efficiency or full compliance with Go philosophy.
 They accelerate development and enhance the experience, by reducing the cognitive load,
 making them well suited for rapid prototyping.
 
+== Comfy Gopher - Collections
+
+=== Goals
+
+1. Provide convenient abstraction for collection data structures
+1. Reduce repetition in day-to-day collections operations
+1. Address the missing ordered map data structure
+1. Provide API for in-place modifications of collections
+1. Reduce strain of juggling between empty slice pointers `[]V(nil) vs []V{}`
+
+=== No-goals
+
+This is a set of elements that the Collections package are NOT trying to achieve:
+
+1. Thread-safety
++
+You must implement your own thread-safety.
+
+1. Superb efficiency
++
+Although care is taken to ensure that the data structures used are efficient, exceptional efficiency is not the main goal here.
+
 == Alternatives
 
 There is a very nice library https://github.com/charbz/gophers[github.com/charbz/gophers].

README.adoc

@@ -6,13 +6,13 @@ import (
 	"testing"
 )
 
-type baseIntArgs = testArgs[Base[int], int]
-type baseTestCase = testCase[Base[int], int]
-type baseCollIntBuilder = testCollectionBuilder[Base[int], int]
+type baseIntArgs = testArgs[baseInternal[int], int]
+type baseTestCase = testCase[baseInternal[int], int]
+type baseCollIntBuilder = testCollectionBuilder[baseInternal[int]]
 
-type baseIntPairArgs = testArgs[Base[Pair[int, int]], Pair[int, int]]
-type baseIntPairTestCase = testCase[Base[Pair[int, int]], Pair[int, int]]
-type baseCollIntPairBuilder = testPairCollectionBuilder[Base[Pair[int, int]]]
+type baseIntPairArgs = testArgs[baseInternal[Pair[int, int]], Pair[int, int]]
+type baseIntPairTestCase = testCase[baseInternal[Pair[int, int]], Pair[int, int]]
+type baseCollIntPairBuilder = testPairCollectionBuilder[baseInternal[Pair[int, int]]]
 
 func getContainsCases(builder baseCollIntBuilder) []baseTestCase {
 	return []baseTestCase{
@@ -598,6 +598,50 @@ func testFind(t *testing.T, builder baseCollIntBuilder) {
 	}
 }
 
+func getFindCasesWithDupes(builder baseCollIntPairBuilder) []*baseIntPairTestCase {
+	return []*baseIntPairTestCase{
+		{
+			name: "Find() on six-item collection, first one",
+			coll: builder.SixWithDuplicates(),
+			args: baseIntPairArgs{
+				predicate:    func(i int, p Pair[int, int]) bool { return true },
+				defaultValue: nil,
+			},
+			want1: NewPair(1, 111),
+		},
+		{
+			name: "Find() on six-item collection, second one",
+			coll: builder.SixWithDuplicates(),
+			args: baseIntPairArgs{
+				predicate:    func(i int, p Pair[int, int]) bool { return p.Val() == 222 },
+				defaultValue: nil,
+			},
+			want1: NewPair(2, 222),
+		},
+		{
+			name: "Find() on six-item collection, not found",
+			coll: builder.SixWithDuplicates(),
+			args: baseIntPairArgs{
+				predicate:    func(i int, p Pair[int, int]) bool { return p.Val() == 999 },
+				defaultValue: nil,
+			},
+			want1: nil,
+		},
+	}
+}
+
+func testFindWithDupes(t *testing.T, builder baseCollIntPairBuilder) {
+	cases := getFindCasesWithDupes(builder)
+	for _, tt := range cases {
+		t.Run(tt.name, func(t *testing.T) {
+			got := tt.coll.Find(tt.args.predicate, tt.args.defaultValue)
+			if !reflect.DeepEqual(got, tt.want1) {
+				t.Errorf("Find() = %v, want1 %v", got, tt.want1)
+			}
+		})
+	}
+}
+
 func getFindLastCases(builder baseCollIntBuilder) []*baseTestCase {
 	return []*baseTestCase{
 		{
@@ -659,6 +703,50 @@ func getFindLastCases(builder baseCollIntBuilder) []*baseTestCase {
 	}
 }
 
+func getFindLastCasesWithDupes(builder baseCollIntPairBuilder) []*baseIntPairTestCase {
+	return []*baseIntPairTestCase{
+		{
+			name: "FindLast() on six-item collection, first one",
+			coll: builder.SixWithDuplicates(),
+			args: baseIntPairArgs{
+				predicate:    func(i int, p Pair[int, int]) bool { return true },
+				defaultValue: nil,
+			},
+			want1: NewPair(6, 333),
+		},
+		{
+			name: "FindLast() on six-item collection, second one",
+			coll: builder.SixWithDuplicates(),
+			args: baseIntPairArgs{
+				predicate:    func(i int, p Pair[int, int]) bool { return p.Val() == 222 },
+				defaultValue: nil,
+			},
+			want1: NewPair(5, 222),
+		},
+		{
+			name: "FindLast() on six-item collection, not found",
+			coll: builder.SixWithDuplicates(),
+			args: baseIntPairArgs{
+				predicate:    func(i int, p Pair[int, int]) bool { return p.Val() == 999 },
+				defaultValue: nil,
+			},
+			want1: nil,
+		},
+	}
+}
+
+func testFindLastWithDupes(t *testing.T, builder baseCollIntPairBuilder) {
+	cases := getFindLastCasesWithDupes(builder)
+	for _, tt := range cases {
+		t.Run(tt.name, func(t *testing.T) {
+			got := tt.coll.FindLast(tt.args.predicate, tt.args.defaultValue)
+			if !reflect.DeepEqual(got, tt.want1) {
+				t.Errorf("FindLast() = %v, want1 %v", got, tt.want1)
+			}
+		})
+	}
+}
+
 func testFindLast(t *testing.T, builder baseCollIntBuilder) {
 	cases := getFindLastCases(builder)
 	for _, tt := range cases {
@@ -1005,7 +1093,7 @@ func getSearchPairCases(builder baseCollIntPairBuilder) []*baseIntPairTestCase {
 			name: "Search() pair on six-item collection, found first occurrence",
 			coll: builder.SixWithDuplicates(),
 			args: baseIntPairArgs{predicate: func(i int, v Pair[int, int]) bool {
-				return v.Value() == 111
+				return v.Val() == 111
 			}},
 			want1: NewPair(1, 111),
 			want2: true,
@@ -1014,7 +1102,7 @@ func getSearchPairCases(builder baseCollIntPairBuilder) []*baseIntPairTestCase {
 			name: "Search() pair on six-item collection, found first occurrence",
 			coll: builder.SixWithDuplicates(),
 			args: baseIntPairArgs{predicate: func(i int, v Pair[int, int]) bool {
-				return v.Value() == 222
+				return v.Val() == 222
 			}},
 			want1: NewPair(2, 222),
 			want2: true,
@@ -1023,7 +1111,7 @@ func getSearchPairCases(builder baseCollIntPairBuilder) []*baseIntPairTestCase {
 			name: "Search() pair on six-item collection, found first occurrence",
 			coll: builder.SixWithDuplicates(),
 			args: baseIntPairArgs{predicate: func(i int, v Pair[int, int]) bool {
-				return v.Value() == 333
+				return v.Val() == 333
 			}},
 			want1: NewPair(3, 333),
 			want2: true,
@@ -1199,7 +1287,7 @@ func getSearchRevPairCases(builder baseCollIntPairBuilder) []*baseIntPairTestCas
 			name: "SearchRev() on six-item collection, found first occurrence",
 			coll: builder.SixWithDuplicates(),
 			args: baseIntPairArgs{predicate: func(i int, v Pair[int, int]) bool {
-				return v.Value() == 111
+				return v.Val() == 111
 			}},
 			want1: NewPair(4, 111),
 			want2: true,
@@ -1208,7 +1296,7 @@ func getSearchRevPairCases(builder baseCollIntPairBuilder) []*baseIntPairTestCas
 			name: "SearchRev() on six-item collection, found first occurrence",
 			coll: builder.SixWithDuplicates(),
 			args: baseIntPairArgs{predicate: func(i int, v Pair[int, int]) bool {
-				return v.Value() == 222
+				return v.Val() == 222
 			}},
 			want1: NewPair(5, 222),
 			want2: true,
@@ -1217,7 +1305,7 @@ func getSearchRevPairCases(builder baseCollIntPairBuilder) []*baseIntPairTestCas
 			name: "SearchRev() on six-item collection, found first occurrence",
 			coll: builder.SixWithDuplicates(),
 			args: baseIntPairArgs{predicate: func(i int, v Pair[int, int]) bool {
-				return v.Value() == 333
+				return v.Val() == 333
 			}},
 			want1: NewPair(6, 333),
 			want2: true,

base_cases_test.go

@@ -0,0 +1,33 @@
+package coll
+
+import "cmp"
+
+type valuesCounter[V cmp.Ordered] struct {
+	counter map[V]int
+}
+
+func newValuesCounter[V cmp.Ordered]() *valuesCounter[V] {
+	return &valuesCounter[V]{
+		counter: make(map[V]int),
+	}
+}
+
+func (c *valuesCounter[V]) Count(v V) int {
+	return c.counter[v]
+}
+
+func (c *valuesCounter[V]) Increment(v V) {
+	c.counter[v]++
+}
+
+func (c *valuesCounter[V]) Decrement(v V) {
+	count, exists := c.counter[v]
+	if !exists {
+		return
+	}
+	if count == 1 {
+		delete(c.counter, v)
+	} else {
+		c.counter[v]--
+	}
+}