#22, #29 - major refactor (#30)

* #22, #29 - major refactor

- Removed all methods that can be easily implemented by using iterator of `Values()` and methods alike
- Separated argument function for indexed and non-indexed collections

* #22, #29 - CR - added comment reducing confusion

* #22, #29 - CR - some capacity optimizations in internal functions

Author: maciej-sz

base_cases_test.go

@@ -1,7 +1,6 @@
 package coll
 
 import (
-	"errors"
 	"testing"
 )
 
@@ -306,129 +305,3 @@ func testLastIndexOf[C cmpInternal[int]](t *testing.T, builder testCollectionBui
 		})
 	}
 }
-
-func getMaxCases[C any](builder testCollectionBuilder[C]) []testCase[C, int] {
-	return []testCase[C, int]{
-		{
-			name:  "Max() on empty collection",
-			coll:  builder.Empty(),
-			want1: 0,
-			err:   ErrEmptyCollection,
-		},
-		{
-			name:  "Max() on one-item collection",
-			coll:  builder.One(),
-			want1: 111,
-		},
-		{
-			name:  "Max() on three-item collection",
-			coll:  builder.Three(),
-			want1: 333,
-		},
-		{
-			name:  "Max() on six-item collection",
-			coll:  builder.SixWithDuplicates(),
-			want1: 333,
-		},
-	}
-}
-
-func testMax[C cmpInternal[int]](t *testing.T, builder testCollectionBuilder[C]) {
-	cases := getMaxCases(builder)
-	for _, tt := range cases {
-		t.Run(tt.name, func(t *testing.T) {
-			got, err := tt.coll.Max()
-			if err != nil {
-				if !errors.Is(err, tt.err) {
-					t.Errorf("Max() error = %v, wantErr %v", err, tt.err)
-				}
-			} else if got != tt.want1 {
-				t.Errorf("Max() = %v, want1 %v", got, tt.want1)
-			}
-		})
-	}
-}
-
-func getMinCases[C any](builder testCollectionBuilder[C]) []testCase[C, int] {
-	return []testCase[C, int]{
-		{
-			name:  "Min() on empty collection",
-			coll:  builder.Empty(),
-			want1: 0,
-			err:   ErrEmptyCollection,
-		},
-		{
-			name:  "Min() on one-item collection",
-			coll:  builder.One(),
-			want1: 111,
-		},
-		{
-			name:  "Min() on three-item collection",
-			coll:  builder.Three(),
-			want1: 111,
-		},
-		{
-			name:  "Min() on three-item collection reversed",
-			coll:  builder.ThreeRev(),
-			want1: 111,
-		},
-		{
-			name:  "Min() on six-item collection",
-			coll:  builder.SixWithDuplicates(),
-			want1: 111,
-		},
-	}
-}
-
-func testMin[C cmpInternal[int]](t *testing.T, builder testCollectionBuilder[C]) {
-	cases := getMinCases(builder)
-	for _, tt := range cases {
-		t.Run(tt.name, func(t *testing.T) {
-			got, err := tt.coll.Min()
-			if err != nil {
-				if !errors.Is(err, tt.err) {
-					t.Errorf("Min() error = %v, wantErr %v", err, tt.err)
-				}
-			} else if got != tt.want1 {
-				t.Errorf("Min() = %v, want1 %v", got, tt.want1)
-			}
-		})
-	}
-}
-
-func getSumCases[C any](builder testCollectionBuilder[C]) []testCase[C, int] {
-	return []testCase[C, int]{
-		{
-			name:  "Sum() on empty collection",
-			coll:  builder.Empty(),
-			want1: 0,
-		},
-		{
-			name:  "Sum() on one-item collection",
-			coll:  builder.One(),
-			want1: 111,
-		},
-		{
-			name:  "Sum() on three-item collection",
-			coll:  builder.Three(),
-			want1: 666,
-		},
-		{
-			name:  "Sum() on six-item collection",
-			coll:  builder.SixWithDuplicates(),
-			want1: 1332,
-		},
-	}
-}
-
-func testSum[C cmpInternal[int]](t *testing.T, builder testCollectionBuilder[C]) {
-	cases := getSumCases(builder)
-	for _, tt := range cases {
-		t.Run(tt.name, func(t *testing.T) {
-			got := tt.coll.Sum()
-			if got != tt.want1 {
-				t.Errorf("Sum() = %v, want1 %v", got, tt.want1)
-			}
-		})
-	}
-}

cmp_cases_test.go

@@ -8,11 +8,10 @@ type testArgs[C any, V any] struct {
 	values          []V
 	defaultValue    V
 	defaultRawValue any
-	visit           Visitor[V]
-	predicate       Predicate[V]
+	visit           func(v V)
+	predicate       func(v V) bool
 	intPredicate    func(i int) bool
-	reducer         Reducer[V]
-	mapper          Mapper[V]
+	mapper          func(val V) V
 	comparer        func(a, b V) int
 	initial         V
 	coll            C