Skip to content

Conversation

@eFiniLan
Copy link
Contributor

Hi team,

I noticed that the current translation strings used for displaying the Panda/vehicle status are inconsistent and potentially confusing. The existing code displays “NO / PANDA” when the interface is not detected, but “VEHICLE / ONLINE” when it is:

def _update_panda_status(self):
  if ui_state.panda_type == log.PandaState.PandaType.unknown:
    self._panda_status.update(tr_noop("NO"), tr_noop("PANDA"), Colors.DANGER)
  else:
    self._panda_status.update(tr_noop("VEHICLE"), tr_noop("ONLINE"), Colors.GOOD)

This mixes two different concepts (Panda hardware vs. vehicle) and results in UI text that is harder to translate and less intuitive for users.

Proposed change

This PR updates the status text to consistently refer to the interface being checked, using:

  • INTERFACE OFFLINE
  • INTERFACE ONLINE
def _update_panda_status(self):
  if ui_state.panda_type == log.PandaState.PandaType.unknown:
    self._panda_status.update(tr_noop("INTERFACE"), tr_noop("OFFLINE"), Colors.DANGER)
  else:
    self._panda_status.update(tr_noop("INTERFACE"), tr_noop("ONLINE"), Colors.GOOD)

Why this is beneficial

  • Consistency: Both states now refer to the same thing—the interface status.
  • Clarity: “INTERFACE OFFLINE/ONLINE” avoids implying the entire vehicle is offline.
  • Translation-friendly: The terms are symmetrical and easy for translators to handle.
  • Accurate: The check is about whether the Panda interface is present, not vehicle connectivity.

If the team prefers more explicit wording (e.g., “PANDA OFFLINE/ONLINE”), I’m happy to update the PR accordingly, but I’ve chosen “INTERFACE” as the most neutral and user-friendly option.

Thanks!

@github-actions github-actions bot added the ui label Nov 14, 2025
@github-actions
Copy link
Contributor

raylib UI Preview

homescreen : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
homescreen_paired : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
homescreen_prime : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
homescreen_unifont : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
homescreen_update_available : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
offroad_alert : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad_sidebar : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
All Screenshots

@TheSecurityDev
Copy link
Contributor

TheSecurityDev commented Nov 14, 2025

"Interface" is pretty vague. The code is specifically referring to the status of the panda system. "Vehicle online" makes sense when everything is working (to avoid jargon that not everyone is familiar with), otherwise it shows the more technical wording "no panda". "Panda offline" or "Vehicle offline" would be better, if anything, but I doubt it will be merged. This PR smells of AI.

@eFiniLan
Copy link
Contributor Author

"Interface" is pretty vague. The code is specifically referring to the status of the panda system. "Vehicle online" makes sense when everything is working (to avoid jargon that not everyone is familiar with), otherwise it shows the more technical wording "no panda". "Panda offline" or "Vehicle offline" would be better, if anything, but I doubt it will be merged. This PR smells of AI.

Thanks for the feedback — I get your point about 'interface' being vague. My main concern isn't the specific word, it's that the current labels mix "NO PANDA" with "VEHICLE ONLINE", even though they refer to the same check. That makes translation and UX confusing.

on top of that, the HUD is designed to always show noun + state in two lines (top line = what the status refers to, bottom line = the status). So labels like "NO / PANDA" don't fit the pattern — "PANDA ONLINE/OFFLINE" or "VEHICLE ONLINE/OFFLINE" would match the structure and be easier to translate.

I did use AI to help with English. (thanks to ChatGPT again)

@sshane
Copy link
Contributor

sshane commented Nov 27, 2025

Ideally you only see vehicle online on release, if something is wrong you see a little more information with "no panda." Going to close for now

@sshane sshane closed this Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants