Use StringSliceFlag instead of comma separated filters

Author: SimonBaeumer

cmd/commander/commander.go

@@ -63,15 +63,15 @@ func createTestCommand() cli.Command {
 				Name:  "dir",
 				Usage: "Execute all test files in a directory sorted by file name, this is not recursive - e.g. /path/to/test_files/",
 			},
-			cli.StringFlag{
+			cli.StringSliceFlag{
 				Name: "filter",
 				Usage: `Filter tests by a given regex pattern. Tests are filtered by its title.
 
 Example:
 test commander.yaml --filter="my test"
 
-Apply multiple filters separated by commas:
-test commander.yaml --filter=filter1,filter2
+Apply multiple filters:
+test commander.yaml --filter=filter1 --filter=filter2
 `,
 			},
 		},

commander_unix.yaml

@@ -102,7 +102,7 @@ tests:
     exit-code: 0
 
   test mulitple filters:
-    command: ./commander test integration/unix/filter_test.yaml --filter="executed$,should be ignored"
+    command: ./commander test integration/unix/filter_test.yaml --filter="executed$" --filter="should be ignored"
     stdout:
       contains:
         - ✓ [local] should be executed

pkg/app/app.go

@@ -2,7 +2,6 @@ package app
 
 import (
 	"github.com/urfave/cli"
-	"strings"
 )
 
 const (
@@ -23,16 +22,11 @@ type AddCommandContext struct {
 
 //NewAddContextFromCli is a constructor which creates the context
 func NewAddContextFromCli(c *cli.Context) AddCommandContext {
-	filters := strings.Split(c.String("filter"), ",")
-	if filters[0] == "" {
-		filters = make([]string, 0)
-	}
-
 	return AddCommandContext{
 		Verbose:    c.Bool("verbose"),
 		NoColor:    c.Bool("no-color"),
 		Dir:        c.Bool("dir"),
 		Concurrent: c.Int("concurrent"),
-		Filters:    filters,
+		Filters:    c.StringSlice("filter"),
 	}
 }