Add filter regex support

Author: SimonBaeumer

CHANGELOG.md

@@ -1,6 +1,7 @@
 # v2.2.0
 
  - Move from `github.com/SimonBaeumer` to `github.com/commander-cli`
+ - Remove `filter` as an argument, instead use `--filter` with regex support
 
 # v2.1.0
 

cmd/commander/commander.go

@@ -65,7 +65,7 @@ func createTestCommand() cli.Command {
 			},
 			cli.StringFlag{
 				Name:  "filter",
-				Usage: "Filter for specific tests to execute",
+				Usage: "Filter tests by a given regex pattern. Tests are filtered by its title.",
 			},
 		},
 		Action: func(c *cli.Context) error {

pkg/app/test_command.go

@@ -103,11 +103,11 @@ func execute(s suite.Suite, title string) (runtime.Result, error)
 
 	// Filter tests if test filters was given
 	for _, f := range filters {
-		t, err := s.GetTestByTitle(f)
+		t, err := s.FindTests(f)
 		if err != nil {
 			return runtime.Result{}, err
 		}
-		tests = append(tests, t)
+		tests = append(tests, t...)
 	}
 
 	r := runtime.NewRuntime(out.GetEventHandler(), s.Nodes...)

pkg/app/test_command_test.go

@@ -68,16 +68,6 @@ func Test_TestCommand_Dir(t *testing.T) {
 	}
 }
 
-func Test_TestCommand_Dir_FilterTitle(t *testing.T) {
-	err := TestCommand("/fake", AddCommandContext{Dir: true})
-
-	if runtime.GOOS == "windows" {
-		assert.Contains(t, err.Error(), "Test may not be filtered when --dir is enabled")
-	} else {
-		assert.Equal(t, "Test may not be filtered when --dir is enabled", err.Error())
-	}
-}
-
 func Test_ConvergeResults(t *testing.T) {
 	duration, _ := time.ParseDuration("5s")
 

pkg/suite/suite.go

@@ -2,6 +2,7 @@ package suite
 
 import (
 	"fmt"
+	"regexp"
 
 	"github.com/commander-cli/commander/pkg/runtime"
 )
@@ -55,6 +56,27 @@ func (s Suite) GetTestByTitle(title string) (runtime.TestCase, error) {
 	return runtime.TestCase{}, fmt.Errorf("could not find test %s", title)
 }
 
+// GetTestByTitle returns a test by title, if the test was not found an error is returned
+func (s Suite) FindTests(pattern string) ([]runtime.TestCase, error) {
+	var r []runtime.TestCase
+	for _, t := range s.GetTests() {
+		matched, err := regexp.Match(pattern, []byte(t.Title))
+		if err != nil {
+			panic(fmt.Sprintf("Regex error %s: %s", pattern, err.Error()))
+		}
+
+		if matched {
+			r = append(r, t)
+		}
+	}
+
+	if len(r) == 0 {
+		return []runtime.TestCase{}, fmt.Errorf("could not find test with pattern: %s", pattern)
+	}
+
+	return r, nil
+}
+
 // GetGlobalConfig returns the global configuration which applies to the complete suite
 func (s Suite) GetGlobalConfig() runtime.GlobalTestConfig {
 	return s.Config

pkg/suite/suite_test.go

@@ -46,3 +46,28 @@ func Test_GetGlobalConfig(t *testing.T) {
 	s := Suite{Config: runtime.GlobalTestConfig{Dir: "/tmp"}}
 	assert.Equal(t, "/tmp", s.GetGlobalConfig().Dir)
 }
+
+func Test_FindTests(t *testing.T) {
+	s := Suite{TestCases: []runtime.TestCase{
+		{Title: "exists"},
+		{Title: "another"},
+		{Title: "another one"},
+	}}
+
+	test, _ := s.FindTests("exists")
+	assert.Len(t, test, 1)
+}
+
+func Test_FindMultipleTests(t *testing.T) {
+	s := Suite{TestCases: []runtime.TestCase{
+		{Title: "exists"},
+		{Title: "another"},
+		{Title: "another one"},
+	}}
+
+	test, _ := s.FindTests("another")
+	assert.Len(t, test, 2)
+
+	test, _ = s.FindTests("another$")
+	assert.Len(t, test, 1)
+}