Add not-contains assertion

Author: SimonBaeumer

CHANGELOG.md

@@ -1,3 +1,7 @@
+# v1.1.0
+
+ - Add `not-contains` assertion on `stdout` and `stderr`
+
 # v1.0.1
 
  - Remove unnecessary command logs

README.md

@@ -81,6 +81,8 @@ tests:
         stderr:
             contains: 
                 - invalid # Assert only contain work
+            not-contains:
+                - not in there # Validate that a string does not occur in stdout
             exactly: "/bin/sh: 1: invalid: not found"
             line-count: 1 # Assert amount of lines
             lines: # Assert specific lines

docs/manual.md

@@ -46,6 +46,8 @@ tests:
         stderr:
             contains: 
                 - invalid # Assert only contain work
+            not-contains:
+                - does not contains # validate that a string does not occur in stdout
             exactly: "/bin/sh: 1: invalid: not found"
             line-count: 1 # Assert amount of lines
             lines: # Assert specific lines

integration/unix/commander_test.yaml

@@ -37,4 +37,10 @@ tests:
         1: line1
         2: line2
         4: line4
-    exit-code: 0
+    exit-code: 0
+
+  it should validate not contains:
+    command: echo lorem ipsum
+    stdout:
+      not-contains:
+        - not contains

integration/windows/commander_test.yaml

@@ -32,4 +32,10 @@ tests:
         1: line1
         2: line2
         4: line4
-    exit-code: 0
+    exit-code: 0
+
+  it should validate not contains:
+    command: echo lorem ipsum
+    stdout:
+      not-contains:
+      - not contains

pkg/matcher/matcher.go

@@ -13,6 +13,8 @@ const (
 	Contains = "contains"
 	// Equal matcher type
 	Equal = "equal"
+	// Not contains matcher type
+	NotContains = "notcontains"
 )
 
 // NewMatcher creates a new matcher by type
@@ -24,6 +26,8 @@ func NewMatcher(matcher string) Matcher {
 		return ContainsMatcher{}
 	case Equal:
 		return EqualMatcher{}
+	case NotContains:
+		return NotContainsMatcher{}
 	default:
 		panic(fmt.Sprintf("Validator '%s' does not exist!", matcher))
 	}
@@ -118,3 +122,18 @@ func (m EqualMatcher) Match(got interface{}, expected interface{}) MatcherResult
 		Diff:    diffText,
 	}
 }
+
+type NotContainsMatcher struct {
+}
+
+func (m NotContainsMatcher) Match(got interface{}, expected interface{}) MatcherResult {
+	result := true
+	if strings.Contains(got.(string), expected.(string)) {
+		result = false
+	}
+
+	return MatcherResult{
+		Success: result,
+		Diff:    "",
+	}
+}

pkg/matcher/matcher_test.go

@@ -71,3 +71,22 @@ func TestContainsMatcher_MatchFail(t *testing.T) {
 	got := m.Match("hello world", "nope")
 	assert.False(t, got.Success)
 }
+
+func TestNewMatcher_NotContains(t *testing.T) {
+	m := NewMatcher(NotContains)
+	assert.IsType(t, NotContainsMatcher{}, m)
+}
+
+func TestNotContainsMatcher(t *testing.T) {
+	m := NotContainsMatcher{}
+	r := m.Match("lore ipsum donor", "hello")
+	assert.True(t, r.Success)
+	assert.Empty(t, r.Diff)
+}
+
+func TestNotContainsMatcher_Fails(t *testing.T) {
+	m := NotContainsMatcher{}
+	r := m.Match("lore ipsum donor", "donor")
+	assert.False(t, r.Success)
+	assert.Empty(t, r.Diff)
+}

pkg/runtime/runtime.go

@@ -65,10 +65,11 @@ type Expected struct {
 
 //ExpectedOut represents the assertions on stdout and stderr
 type ExpectedOut struct {
-	Contains  []string
-	Lines     map[int]string
-	Exactly   string
-	LineCount int
+	Contains    []string
+	Lines       map[int]string
+	Exactly     string
+	LineCount   int
+	NotContains []string
 }
 
 // CommandUnderTest represents the command under test

pkg/runtime/validator.go

@@ -92,6 +92,15 @@ func validateExpectedOut(got string, expected ExpectedOut) matcher.MatcherResult
 		}
 	}
 
+	if len(expected.NotContains) > 0 {
+		m = matcher.NewMatcher(matcher.NotContains)
+		for _, c := range expected.NotContains {
+			if result = m.Match(got, c); !result.Success {
+				return result
+			}
+		}
+	}
+
 	return result
 }
 

pkg/runtime/validator_test.go

@@ -81,16 +81,18 @@ func getExampleTest() TestCase {
 	test := TestCase{
 		Expected: Expected{
 			Stdout: ExpectedOut{
-				Lines:     map[int]string{1: "hello"},
-				LineCount: 1,
-				Exactly:   "hello",
-				Contains:  []string{"hello"},
+				Lines:       map[int]string{1: "hello"},
+				LineCount:   1,
+				Exactly:     "hello",
+				Contains:    []string{"hello"},
+				NotContains: []string{"not-exist"},
 			},
 			Stderr: ExpectedOut{
-				Lines:     map[int]string{1: "error"},
-				LineCount: 1,
-				Exactly:   "error",
-				Contains:  []string{"error"},
+				Lines:       map[int]string{1: "error"},
+				LineCount:   1,
+				Exactly:     "error",
+				Contains:    []string{"error"},
+				NotContains: []string{"not-exist"},
 			},
 			LineCount: 1,
 		},