Revert "Merge branch 'develop' of github.com:commandlineparser/commandline into develop" (5343c5d, reversing changes 9f91088)

Author: moh-hassan

src/CommandLine/Core/ReflectionExtensions.cs

@@ -14,8 +14,6 @@ namespace CommandLine.Core
 {
     static class ReflectionExtensions
     {
-        public const string CannotSetValueToTargetInstance = "Cannot set value to target instance.";
-
         public static IEnumerable<T> GetSpecifications<T>(this Type type, Func<PropertyInfo, T> selector)
         {
             return from pi in type.FlattenHierarchy().SelectMany(x => x.GetTypeInfo().GetProperties())
@@ -93,10 +91,6 @@ public static IEnumerable<Error> SetProperties<T>(
 
         private static IEnumerable<Error> SetValue<T>(this SpecificationProperty specProp, T instance, object value)
         {
-            Action<Exception> fail = inner => {
-                throw new InvalidOperationException(CannotSetValueToTargetInstance, inner);
-            };
-            
             try
             {
                 specProp.Property.SetValue(instance, value, null);
@@ -110,13 +104,6 @@ private static IEnumerable<Error> SetValue<T>(this SpecificationProperty specPro
             {
                  return new[] { new SetValueExceptionError(specProp.Specification.FromSpecification(), e, value) };
             }
-            catch(ArgumentException e)
-            {
-                var argEx = new ArgumentException(InvalidAttributeConfigurationError.ErrorMessage, e);
-                fail(argEx);
-            }
-
-            return instance;
         }
 
         public static object CreateEmptyArray(this Type type)

src/CommandLine/Error.cs

@@ -65,11 +65,6 @@ public enum ErrorType
         /// Value of <see cref="CommandLine.SetValueExceptionError"/> type.
         /// </summary>
         SetValueExceptionError
-        VersionRequestedError,
-        /// <summary>
-        /// Value of <see cref="CommandLine.InvalidAttributeConfigurationError"/> type.
-        /// </summary>
-        InvalidAttributeConfigurationError
     }
 
     /// <summary>

tests/CommandLine.Tests/Fakes/Options_With_InvalidDefaults.cs

@@ -1133,21 +1133,6 @@ public void Parse_TimeSpan()
             // Teardown
         }
 
-        [Fact]
-        public void Build_DefaultBoolTypeString_ThrowsInvalidOperationException()
-        {
-            // Exercize system 
-            Action test = () => InvokeBuild<Options_With_InvalidDefaults>(
-                new string[] { });
-
-            // Verify outcome
-            test.ShouldThrow<InvalidOperationException>()
-                .WithMessage(ReflectionExtensions.CannotSetValueToTargetInstance)
-                .WithInnerException<ArgumentException>()
-                .WithInnerMessage(InvalidAttributeConfigurationError.ErrorMessage);
-        }
-
-
         [Fact]
         public void OptionClass_IsImmutable_HasNoCtor()
         {
@@ -1163,7 +1148,7 @@ private class ValueWithNoSetterOptions
         }
 
 
-        public static IEnumerable<object> RequiredValueStringData
+        public static IEnumerable<object[]> RequiredValueStringData
         {
             get
             {