Issue #283: Add NameInfo information to SetValueExceptionError

Author: e673

src/CommandLine/Core/ReflectionExtensions.cs

@@ -86,24 +86,24 @@ public static IEnumerable<Error> SetProperties<T>(
             Func<SpecificationProperty, bool> predicate,
             Func<SpecificationProperty, object> selector)
         {
-            return specProps.Where(predicate).SelectMany(specProp => specProp.Property.SetValue(instance, selector(specProp)));
-        }
-
-        private static IEnumerable<Error> SetValue<T>(this PropertyInfo property, T instance, object value)
-        {           
-             try
-             {
-                 property.SetValue(instance, value, null);
-                 return Enumerable.Empty<Error>();
-             }
-             catch (TargetInvocationException e)
-             {
-                 return new[] { new SetValueExceptionError(e.InnerException) };
-             }
-             catch (Exception e)
-             {
-                 return new[] { new SetValueExceptionError(e) };
-             }
+            return specProps.Where(predicate).SelectMany(specProp => specProp.SetValue(instance, selector(specProp)));
+        }
+
+        private static IEnumerable<Error> SetValue<T>(this SpecificationProperty specProp, T instance, object value)
+        {
+            try
+            {
+                specProp.Property.SetValue(instance, value, null);
+                return Enumerable.Empty<Error>();
+            }
+            catch (TargetInvocationException e)
+            {
+                return new[] { new SetValueExceptionError(specProp.Specification.FromSpecification(), e.InnerException) };
+            }
+            catch (Exception e)
+            {
+                 return new[] { new SetValueExceptionError(specProp.Specification.FromSpecification(), e) };
+            }
         }
 
         public static object CreateEmptyArray(this Type type)

src/CommandLine/Text/SentenceBuilder.cs

@@ -138,7 +138,8 @@ public override Func<Error, string> FormatError
                                     return "Option '".JoinTo(((RepeatedOptionError)error).NameInfo.NameText,
                                         "' is defined multiple times.");
                                 case ErrorType.SetValueExceptionError:
-                                    return "Error setting option value: ".JoinTo(((SetValueExceptionError)error).Exception.Message);
+                                    var setValueError = (SetValueExceptionError)error;
+                                    return "Error setting value to option '".JoinTo(setValueError.NameInfo.NameText, "': ", setValueError.Exception.Message);
                             }
                             throw new InvalidOperationException();
                         };