WIP: refactor traits with type safe abstract methods

Author: Jens Schulze

src/Core/Model/Common/LocaleTrait.php

@@ -16,6 +16,11 @@ public function setLocale($locale)
         return $this;
     }
 
+    /**
+     * @return array
+     */
+    abstract public function toArray();
+
     /**
      * @return array
      */

src/Core/Request/CustomerIdTrait.php

@@ -10,10 +10,15 @@
 
 /**
  * @package Commercetools\Core\Request
- * @method $this addParamObject(ParameterInterface $param)
  */
 trait CustomerIdTrait
 {
+    /**
+     * @param ParameterInterface $param
+     * @return $this
+     */
+    abstract public function addParamObject(ParameterInterface $param);
+
     public function byCustomerId($customerId)
     {
         if (!is_null($customerId)) {

src/Core/Request/ExpandTrait.php

@@ -10,10 +10,15 @@
 
 /**
  * @package Commercetools\Core\Request
- * @method $this addParamObject(ParameterInterface $param)
  */
 trait ExpandTrait
 {
+    /**
+     * @param ParameterInterface $param
+     * @return $this
+     */
+    abstract public function addParamObject(ParameterInterface $param);
+
     /**
      * @param $fieldReference
      * @return $this

src/Core/Request/PageTrait.php

@@ -11,10 +11,15 @@
 
 /**
  * @package Commercetools\Core\Request
- * @method $this addParamObject(ParameterInterface $param)
  */
 trait PageTrait
 {
+    /**
+     * @param ParameterInterface $param
+     * @return $this
+     */
+    abstract public function addParamObject(ParameterInterface $param);
+
     /**
      * @param int $limit
      * @return $this

src/Core/Request/PriceSelectTrait.php

@@ -11,10 +11,14 @@
 use Commercetools\Core\Request\Query\ParameterInterface;
 
 /**
- * @method $this addParamObject(ParameterInterface $param)
  */
 trait PriceSelectTrait
 {
+    /**
+     * @param ParameterInterface $param
+     * @return $this
+     */
+    abstract public function addParamObject(ParameterInterface $param);
 
     protected function select($key, $value)
     {

src/Core/Request/QueryTrait.php

@@ -11,10 +11,15 @@
 
 /**
  * @package Commercetools\Core\Request
- * @method $this addParamObject(ParameterInterface $param)
  */
 trait QueryTrait
 {
+    /**
+     * @param ParameterInterface $param
+     * @return $this
+     */
+    abstract public function addParamObject(ParameterInterface $param);
+
     /**
      * @param string $where
      * @return $this

src/Core/Request/SortTrait.php

@@ -11,10 +11,15 @@
 
 /**
  * @package Commercetools\Core\Request
- * @method $this addParamObject(ParameterInterface $param)
  */
 trait SortTrait
 {
+    /**
+     * @param ParameterInterface $param
+     * @return $this
+     */
+    abstract public function addParamObject(ParameterInterface $param);
+
     /**
      * @param string $sort
      * @return $this

src/Core/Request/StagedTrait.php

@@ -11,10 +11,15 @@
 
 /**
  * @package Commercetools\Core\Request
- * @method $this addParamObject(ParameterInterface $param)
  */
 trait StagedTrait
 {
+    /**
+     * @param ParameterInterface $param
+     * @return $this
+     */
+    abstract public function addParamObject(ParameterInterface $param);
+
     /**
      * @param bool $staged
      * @return $this

src/Core/Request/WithTotalTrait.php

@@ -10,10 +10,15 @@
 
 /**
  * @package Commercetools\Core\Request
- * @method $this addParamObject(ParameterInterface $param)
  */
 trait WithTotalTrait
 {
+    /**
+     * @param ParameterInterface $param
+     * @return $this
+     */
+    abstract public function addParamObject(ParameterInterface $param);
+
     /**
      * @param bool $withTotal
      * @return $this