fix(Payment): add missing type for payment transactions

Author: Jens Schulze

src/Model/Common/AbstractJsonDeserializeObject.php

@@ -126,15 +126,15 @@ protected function isDeserializable($value)
      */
     protected function isDeserializableType($type)
     {
-        if (!is_string($type)) {
+        if (!is_string($type) || empty($type)) {
             return false;
         }
         return $this->hasInterface($type, static::JSON_DESERIALIZE_INTERFACE);
     }
 
     protected function isTypeableType($type)
     {
-        if (!is_string($type)) {
+        if (!is_string($type) || empty($type)) {
             return false;
         }
         return $this->hasInterface($type, static::TYPEABLE_INTERFACE);

src/Model/Payment/Payment.php

@@ -78,7 +78,7 @@ public function fieldDefinitions()
             'paymentMethodInfo' => [static::TYPE => '\Commercetools\Core\Model\Payment\PaymentMethodInfo'],
             'custom' => [static::TYPE => '\Commercetools\Core\Model\CustomField\CustomFieldObject'],
             'paymentStatus' => [static::TYPE => '\Commercetools\Core\Model\Payment\PaymentStatus'],
-            'transactions' => [static::TYPE => ''],
+            'transactions' => [static::TYPE => '\Commercetools\Core\Model\Payment\TransactionCollection'],
             'interfaceInteractions' => [
                 static::TYPE => '\Commercetools\Core\Model\CustomField\CustomFieldObjectCollection'
             ],

src/Model/Payment/Transaction.php

@@ -23,6 +23,12 @@
  */
 class Transaction extends JsonObject
 {
+    const AUTHORIZATION = 'Authorization';
+    const CANCEL_AUTHORIZATION = 'CancelAuthorization';
+    const CHARGE = 'Charge';
+    const REFUND = 'Refund';
+    const CHARGE_BACK = 'Chargeback';
+
     public function fieldDefinitions()
     {
         return [

src/Model/Payment/TransactionCollection.php

@@ -25,7 +25,7 @@ protected function indexRow($offset, $row)
         if ($row instanceof Transaction) {
             $id = $row->getInteractionId();
         } else {
-            $id = $row[static::INTERACTION_ID];
+            $id = isset($row[static::INTERACTION_ID]) ? $row[static::INTERACTION_ID] : null;
         }
         $this->addToIndex(static::INTERACTION_ID, $offset, $id);
     }