Skip to content

Commit 0bd2ad7

Browse files
committed
use semver lib for checking versions
1 parent e71d12e commit 0bd2ad7

File tree

6 files changed

+11
-5
lines changed

6 files changed

+11
-5
lines changed
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11

22
package com.commercetools.http.apachehttp;
33

4+
import com.vdurmont.semver4j.Semver;
45
import org.assertj.core.api.Assertions;
56
import org.junit.jupiter.api.Test;
67

@@ -9,7 +10,7 @@ public class SolutionInfoTest {
910
public void version() {
1011
String version = new ApacheHttpClientSolutionInfo().getVersion();
1112

12-
Assertions.assertThat(Runtime.Version.parse(version).compareTo(Runtime.Version.parse("5.4.1"))).isGreaterThanOrEqualTo(0);
13+
Assertions.assertThat(new Semver(version).compareTo(new Semver("5.4.1"))).isGreaterThanOrEqualTo(0);
1314
Assertions.assertThat(version).startsWith("5.");
1415
}
1516
}

commercetools/commercetools-async-http-client/src/test/java/com/commercetools/http/asynchttpclient/SolutionInfoTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
import com.commercetools.http.asynchttp.AsyncHttpClientSolutionInfo;
55

6+
import com.vdurmont.semver4j.Semver;
67
import org.assertj.core.api.Assertions;
78
import org.junit.jupiter.api.Test;
89

@@ -11,7 +12,7 @@ public class SolutionInfoTest {
1112
public void version() {
1213
String version = new AsyncHttpClientSolutionInfo().getVersion();
1314

14-
Assertions.assertThat(Runtime.Version.parse(version).compareTo(Runtime.Version.parse("2.12.0"))).isGreaterThanOrEqualTo(0);
15+
Assertions.assertThat(new Semver(version).compareTo(new Semver("2.12.0"))).isGreaterThanOrEqualTo(0);
1516
Assertions.assertThat(version).startsWith("2.");
1617
}
1718
}
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11

22
package com.commercetools.http.okhttp3;
33

4+
import com.vdurmont.semver4j.Semver;
45
import org.assertj.core.api.Assertions;
56
import org.junit.jupiter.api.Test;
67

@@ -9,7 +10,7 @@ public class SolutionInfoTest {
910
public void version() {
1011
String version = new OkHttpClientSolutionInfo().getVersion();
1112

12-
Assertions.assertThat(Runtime.Version.parse(version).compareTo(Runtime.Version.parse("3.14.0"))).isGreaterThanOrEqualTo(0);
13+
Assertions.assertThat(new Semver(version).compareTo(new Semver("3.14.0"))).isGreaterThanOrEqualTo(0);
1314
Assertions.assertThat(version).startsWith("3.");
1415
}
1516
}
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11

22
package com.commercetools.http.okhttp4;
33

4+
import com.vdurmont.semver4j.Semver;
45
import org.assertj.core.api.Assertions;
56
import org.junit.jupiter.api.Test;
67

@@ -9,7 +10,7 @@ public class SolutionInfoTest {
910
public void version() {
1011
String version = new OkHttpClientSolutionInfo().getVersion();
1112

12-
Assertions.assertThat(Runtime.Version.parse(version).compareTo(Runtime.Version.parse("4.12.0"))).isGreaterThanOrEqualTo(0);
13+
Assertions.assertThat(new Semver(version).compareTo(new Semver("4.12.0"))).isGreaterThanOrEqualTo(0);
1314
Assertions.assertThat(version).startsWith("4.");
1415
}
1516
}
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11

22
package com.commercetools.http.netty;
33

4+
import com.vdurmont.semver4j.Semver;
45
import org.assertj.core.api.Assertions;
56
import org.junit.jupiter.api.Test;
67

@@ -9,7 +10,7 @@ public class SolutionInfoTest {
910
public void version() {
1011
String version = new NettyHttpClientSolutionInfo().getVersion();
1112

12-
Assertions.assertThat(Runtime.Version.parse(version).compareTo(Runtime.Version.parse("1.2.0"))).isGreaterThanOrEqualTo(0);
13+
Assertions.assertThat(new Semver(version).compareTo(new Semver("1.2.0"))).isGreaterThanOrEqualTo(0);
1314
Assertions.assertThat(version).startsWith("1.");
1415
}
1516
}

gradle-scripts/subproject-dependencies.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,5 @@ dependencies {
88
testImplementation mockito.inline
99
testImplementation mockito.junit
1010
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
11+
testImplementation 'com.vdurmont:semver4j:3.1.0'
1112
}

0 commit comments

Comments
 (0)