Skip to content

Commit 7b63ac3

Browse files
committed
Update Apache AsyncHttpClient
1 parent de78e1b commit 7b63ac3

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

commercetools/commercetools-apachehttp-client/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11

22
dependencies {
33
api project(":rmf:rmf-java-base")
4-
api "org.apache.httpcomponents.client5:httpclient5:5.3.1" version {
4+
api "org.apache.httpcomponents.client5:httpclient5:5.4.1" version {
55
strictly "[5.0,6.0["
6-
prefer "5.1.3"
6+
prefer "5.4.1"
77
}
88

99
api commons.io version commons.io_version

commercetools/commercetools-apachehttp-client/src/main/java/com/commercetools/http/apachehttp/CtApacheHttpClient.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import org.apache.hc.client5.http.async.methods.SimpleBody;
2020
import org.apache.hc.client5.http.async.methods.SimpleHttpResponse;
2121
import org.apache.hc.client5.http.async.methods.SimpleResponseConsumer;
22+
import org.apache.hc.client5.http.config.TlsConfig;
2223
import org.apache.hc.client5.http.impl.async.CloseableHttpAsyncClient;
2324
import org.apache.hc.client5.http.impl.async.HttpAsyncClientBuilder;
2425
import org.apache.hc.client5.http.impl.nio.PoolingAsyncClientConnectionManagerBuilder;
@@ -32,7 +33,6 @@
3233
import org.apache.hc.core5.http.nio.support.AsyncRequestBuilder;
3334
import org.apache.hc.core5.http2.HttpVersionPolicy;
3435
import org.apache.hc.core5.reactor.IOReactorStatus;
35-
import org.apache.hc.core5.reactor.ssl.TlsDetails;
3636

3737
public class CtApacheHttpClient extends HttpClientBase {
3838
public static final int MAX_REQUESTS = 64;
@@ -46,19 +46,19 @@ public static HttpAsyncClientBuilder createClientBuilder() {
4646
}
4747

4848
public static HttpAsyncClientBuilder createClientBuilder(AsyncClientConnectionManager cm) {
49-
return HttpAsyncClientBuilder.create().setVersionPolicy(HttpVersionPolicy.NEGOTIATE).setConnectionManager(cm);
49+
return HttpAsyncClientBuilder.create().setConnectionManager(cm);
5050
}
5151

5252
public static PoolingAsyncClientConnectionManagerBuilder createConnectionManager(final int maxConnTotal,
5353
final int maxConnPerRoute) {
54-
final TlsStrategy tlsStrategy = ClientTlsStrategyBuilder.create()
55-
.useSystemProperties()
56-
.setTlsDetailsFactory(
57-
sslEngine -> new TlsDetails(sslEngine.getSession(), sslEngine.getApplicationProtocol()))
54+
final TlsStrategy tlsStrategy = ClientTlsStrategyBuilder.create().useSystemProperties().build();
55+
final TlsConfig tlsConfig = TlsConfig.copy(TlsConfig.DEFAULT)
56+
.setVersionPolicy(HttpVersionPolicy.NEGOTIATE)
5857
.build();
5958
return PoolingAsyncClientConnectionManagerBuilder.create()
6059
.setMaxConnPerRoute(maxConnPerRoute)
6160
.setMaxConnTotal(maxConnTotal)
61+
.setDefaultTlsConfig(tlsConfig)
6262
.setTlsStrategy(tlsStrategy);
6363
}
6464

0 commit comments

Comments
 (0)