small optimizations

Author: jenschude

commercetools/commercetools-monitoring-datadog/src/main/java/com/commercetools/monitoring/datadog/statsd/DatadogMiddleware.java

@@ -44,8 +44,7 @@ public class DatadogMiddleware implements TelemetryMiddleware {
     private final Collection<String> tags;
 
     public DatadogMiddleware(final StatsDClient datadogStatsDClient) {
-        this.statsDClient = datadogStatsDClient;
-        this.tags = Collections.emptyList();
+        this(datadogStatsDClient, Collections.emptyMap());
     }
 
     public DatadogMiddleware(final StatsDClient datadogStatsDClient, final Map<String, String> tags) {

commercetools/commercetools-monitoring-datadog/src/main/java/com/commercetools/monitoring/datadog/statsd/DatadogResponseSerializer.java

@@ -29,9 +29,7 @@ public class DatadogResponseSerializer implements ResponseSerializer {
     private final Collection<String> tags;
 
     public DatadogResponseSerializer(final ResponseSerializer serializer, final StatsDClient datadogStatsDClient) {
-        this.serializer = serializer;
-        this.statsDClient = datadogStatsDClient;
-        this.tags = Collections.emptyList();
+        this(serializer, datadogStatsDClient, Collections.emptyMap());
     }
 
     public DatadogResponseSerializer(final ResponseSerializer serializer, final StatsDClient datadogStatsDClient,

commercetools/commercetools-monitoring-newrelic/src/main/java/com/commercetools/monitoring/newrelic/NewRelicTelemetryMiddleware.java

@@ -73,7 +73,6 @@ public CompletableFuture<ApiHttpResponse<byte[]>> invoke(ApiHttpRequest request,
         Optional<Token> token = context.map(NewRelicContext::getTransaction).map(Transaction::getToken);
         Optional<Segment> segment = context.map(c -> c.getTransaction()
                 .startSegment("commercetools", request.getMethod() + " " + request.getUri().getPath()));
-        segment.ifPresent(s -> s.addCustomAttributes(this.attributes));
         return next.apply(request).handle((response, throwable) -> {
             token.ifPresent(Token::linkAndExpire);
 
@@ -99,6 +98,7 @@ else if (throwable instanceof ApiHttpException && ((ApiHttpException) throwable)
                     .noInboundHeaders()
                     .status(statusCode, message)
                     .build()));
+            segment.ifPresent(s -> s.addCustomAttributes(this.attributes));
             segment.ifPresent(Segment::end);
 
             NewRelic.incrementCounter(PREFIX + CLIENT_REQUEST_TOTAL);