SUPPORT-35419: making custom field not required #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenschude
reviewed
Sep 19, 2025
| .name(LocalizedString.of()) | ||
| .build(); | ||
|
|
||
| assertNotNull(paymentMethodInfo.toDraft()); |
Contributor
There was a problem hiding this comment.
better assert the type here
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #991 +/- ##
==========================================
+ Coverage 9.50% 9.51% +0.01%
- Complexity 2015 2016 +1
==========================================
Files 7708 7708
Lines 75582 75582
Branches 302 302
==========================================
+ Hits 7186 7194 +8
+ Misses 68219 68211 -8
Partials 177 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # commercetools/commercetools-sdk-java-api/src/test/java/com/commercetools/PaymentMethodInfoMixinTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changeset added
Features
Making PaymentMethodInfoDraft toDraft() working without field custom, which is not required for the PaymentMethodInfoDraft
Fixes
Breaking changes