fix Credentials deprecation

jenschude · jenschude · commit eb01ef2f58cd · 2025-01-21T22:08:40.000+01:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -98,6 +98,9 @@ jobs:
           - "7.4"
           - "8.0"
           - "8.1"
+          - "8.2"
+          - "8.3"
+          - "8.4"
         dependencies:
           - lowest
           - highest
diff --git a/lib/commercetools-base/src/Client/ClientCredentials.php b/lib/commercetools-base/src/Client/ClientCredentials.php
@@ -38,12 +38,12 @@ class ClientCredentials
      *   Format: `<the scope name>:<the project key>`.
      *   Example: `manage_products:project1`.
      */
-    public function __construct(string $clientId, string $clientSecret, string $scope = null)
+    public function __construct(string $clientId, string $clientSecret, ?string $scope)
     {
         $this->clientId = $clientId;
         $this->clientSecret = $clientSecret;
         $this->scope = $scope;
-        $this->cacheKey = sha1($clientId . (string)$scope);
+        $this->cacheKey = sha1($clientId . $scope);
     }
 
     public function getClientId(): string

-Original file line number
+Diff line change
           - "7.4"
           - "8.0"
           - "8.1"
 +          - "8.2"
 +          - "8.3"
 +          - "8.4"
         dependencies:
           - lowest
           - highest
Original file line number	Diff line number	Diff line change
`@@ -38,12 +38,12 @@ class ClientCredentials`
`38`	`38`	* Format: `<the scope name>:<the project key>`.
`39`	`39`	* Example: `manage_products:project1`.
`40`	`40`	`*/`
`41`		`- public function __construct(string $clientId, string $clientSecret, string $scope = null)`
	`41`	`+ public function __construct(string $clientId, string $clientSecret, ?string $scope)`
`42`	`42`	`{`
`43`	`43`	`$this->clientId = $clientId;`
`44`	`44`	`$this->clientSecret = $clientSecret;`
`45`	`45`	`$this->scope = $scope;`
`46`		`- $this->cacheKey = sha1($clientId . (string)$scope);`
	`46`	`+ $this->cacheKey = sha1($clientId . $scope);`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`public function getClientId(): string`