Create empty StateDraft if required fields are missing

Author: salander85

src/main/java/com/commercetools/sync/states/utils/StateReferenceResolutionUtils.java

@@ -65,19 +65,37 @@ public static List<StateDraft> mapToStateDrafts(
             state -> {
               final List<StateResourceIdentifier> newTransitions =
                   replaceTransitionIdsWithKeys(state, referenceIdToKeyCache);
-              return StateDraftBuilder.of()
-                  .key(state.getKey())
-                  .type(state.getType())
-                  .name(state.getName())
-                  .description(state.getDescription())
-                  .initial(state.getInitial())
-                  .roles(state.getRoles())
-                  .transitions(newTransitions)
-                  .build();
+              return getStateDraft(state, newTransitions);
             })
         .collect(Collectors.toList());
   }
 
+  /**
+   * Creates a new {@link StateDraft} from given {@link State} and transitions as {@link
+   * java.util.List}&lt; {@link StateResourceIdentifier}&gt;
+   *
+   * @param state - template state to build the draft from
+   * @param newTransitions - transformed list of state resource identifiers
+   * @return a new {@link StateDraft} with all fields copied from the {@param state} and transitions
+   *     set {@param newTransitions} - it will return empty StateDraft if key or type are missing.
+   */
+  private static StateDraft getStateDraft(
+      State state, List<StateResourceIdentifier> newTransitions) {
+    if (state.getKey() != null && state.getType() != null) {
+      return StateDraftBuilder.of()
+          .key(state.getKey())
+          .type(state.getType())
+          .name(state.getName())
+          .description(state.getDescription())
+          .initial(state.getInitial())
+          .roles(state.getRoles())
+          .transitions(newTransitions)
+          .build();
+    } else {
+      return StateDraft.of();
+    }
+  }
+
   @SuppressWarnings("PMD.ReturnEmptyCollectionRatherThanNull")
   private static List<StateResourceIdentifier> replaceTransitionIdsWithKeys(
       @Nonnull final State state, @Nonnull final ReferenceIdToKeyCache referenceIdToKeyCache) {

src/test/java/com/commercetools/sync/states/utils/StateReferenceResolutionUtilsTest.java

@@ -120,6 +120,19 @@ void mapToStateDrafts_WithNullReferences_ShouldNotFail() {
     assertThat(referenceReplacedDrafts.get(0).getTransitions()).isEqualTo(null);
   }
 
+  @Test
+  void mapToStateDrafts_WithMissingRequiredFields_ShouldNotFailAndReturnEmptyDraft() {
+    // preparation
+    final State mockState = mock(State.class);
+    when(mockState.getTransitions()).thenReturn(null);
+
+    // test
+    final List<StateDraft> referenceReplacedDrafts =
+        StateReferenceResolutionUtils.mapToStateDrafts(List.of(mockState), referenceIdToKeyCache);
+
+    assertThat(referenceReplacedDrafts.get(0)).isEqualTo(StateDraft.of());
+  }
+
   @Nonnull
   private static State getStateMock(@Nonnull final String key) {
     final State state = mock(State.class);