Add test for syncing images in a product (#1164)

Author: lojzatran

src/integration-test/java/com/commercetools/sync/integration/externalsource/products/ProductSyncIT.java

@@ -1108,6 +1108,51 @@ void sync_withProductContainingAttributeChanges_shouldSyncProductCorrectly() {
             ProductPublishActionBuilder.of().build());
   }
 
+  @Test
+  void sync_whenSourceProductHasNoImage_shouldSyncNewImages() {
+    final ProductDraft productDraftNoImages =
+        createProductDraft(
+            PRODUCT_KEY_7_NO_IMAGES,
+            ProductTypeResourceIdentifierBuilder.of().id(productType.getId()).build(),
+            null,
+            null,
+            null,
+            null);
+
+    TestClientUtils.CTP_TARGET_CLIENT
+        .products()
+        .create(productDraftNoImages)
+        .execute()
+        .thenApply(ApiHttpResponse::getBody)
+        .join();
+
+    final ProductDraft productDraftWithImages =
+        createProductDraft(
+            PRODUCT_KEY_7_WITH_IMAGES,
+            ProductTypeResourceIdentifierBuilder.of().id(productType.getKey()).build(),
+            null,
+            null,
+            null,
+            null);
+
+    final ProductSync productSync = new ProductSync(syncOptions);
+    final ProductSyncStatistics syncStatistics =
+        productSync.sync(singletonList(productDraftWithImages)).toCompletableFuture().join();
+
+    assertThat(syncStatistics).hasValues(1, 0, 1, 0, 0);
+
+    final ProductProjection productProjection =
+        TestClientUtils.CTP_TARGET_CLIENT
+            .productProjections()
+            .withKey(productDraftNoImages.getKey())
+            .get()
+            .execute()
+            .thenApply(ApiHttpResponse::getBody)
+            .join();
+
+    assertThat(productProjection.getMasterVariant().getImages()).hasSize(1);
+  }
+
   @Nonnull
   private static ProductDraft prefixDraftKey(
       @Nonnull final ProductDraft productDraft, @Nonnull final String prefix) {

src/test/java/com/commercetools/sync/products/ProductSyncMockUtils.java

@@ -98,6 +98,9 @@ public class ProductSyncMockUtils {
   public static final String SIMPLE_PRODUCT_WITH_MULTIPLE_VARIANTS_RESOURCE_PATH =
       "simple-product-with-multiple-variants.json";
 
+  public static final String PRODUCT_KEY_7_WITH_IMAGES = "product-key-7-with-images.json";
+  public static final String PRODUCT_KEY_7_NO_IMAGES = "product-key-7-no-images.json";
+
   /**
    * Unfortunately, <a
    * href="http://dev.commercetools.com/http-api-projects-products.html#category-order-hints">

src/test/resources/product-key-7-no-images.json

@@ -0,0 +1,48 @@
+{
+  "id": "ba81a6da-cf83-435b-a89e-2afab579846f",
+  "version": 10,
+  "key": "productKey7",
+  "productType": {
+    "typeId": "product-type",
+    "id": "cda0dbf7-b42e-40bf-8453-241d5b587f93"
+  },
+  "catalogs": [],
+  "masterData": {
+    "staged": {
+      "name": {
+        "en": "english name"
+      },
+      "description": {
+        "en": "english description."
+      },
+      "categories": [
+      ],
+      "categoryOrderHints": {
+      },
+      "slug": {
+        "en": "english-slug-7"
+      },
+      "masterVariant": {
+        "id": 1,
+        "key": "777777",
+        "sku": "777777",
+        "attributes": [
+        ],
+        "assets": []
+      },
+      "variants": [],
+      "searchKeywords": {}
+    },
+    "published": true,
+    "hasStagedChanges": true
+  },
+  "catalogData": {},
+  "taxCategory": {
+    "typeId": "tax-category",
+    "id": "ebbe95fb-2282-4f9a-8747-fbe440e02dc0"
+  },
+  "lastVariantId": 1,
+  "createdAt": "2016-11-21T09:32:41.261Z",
+  "lastModifiedAt": "2016-12-05T16:09:03.307Z",
+  "lastMessageSequenceNumber": 3
+}

src/test/resources/product-key-7-with-images.json

@@ -0,0 +1,57 @@
+{
+  "id": "ba81a6da-cf83-435b-a89e-2afab579846f",
+  "version": 10,
+  "key": "productKey7",
+  "productType": {
+    "typeId": "product-type",
+    "id": "cda0dbf7-b42e-40bf-8453-241d5b587f93"
+  },
+  "catalogs": [],
+  "masterData": {
+    "staged": {
+      "name": {
+        "en": "english name"
+      },
+      "description": {
+        "en": "english description."
+      },
+      "categories": [
+      ],
+      "categoryOrderHints": {
+      },
+      "slug": {
+        "en": "english-slug-7"
+      },
+      "masterVariant": {
+        "id": 1,
+        "key": "777777",
+        "sku": "777777",
+        "attributes": [
+        ],
+        "assets": [],
+        "images": [
+          {
+            "url": "https://53346cfbf3c7e017ed3d-6de74c3efa80f1c837c6a988b57abe66.ssl.cf3.rackcdn.com/old-image.png",
+            "dimensions": {
+              "w": 0,
+              "h": 0
+            }
+          }
+        ]
+      },
+      "variants": [],
+      "searchKeywords": {}
+    },
+    "published": true,
+    "hasStagedChanges": true
+  },
+  "catalogData": {},
+  "taxCategory": {
+    "typeId": "tax-category",
+    "id": "ebbe95fb-2282-4f9a-8747-fbe440e02dc0"
+  },
+  "lastVariantId": 1,
+  "createdAt": "2016-11-21T09:32:41.261Z",
+  "lastModifiedAt": "2016-12-05T16:09:03.307Z",
+  "lastMessageSequenceNumber": 3
+}