Skip to content

Commit fbded7b

Browse files
authored
Fix wrong json object mapper configuration (#1139)
* Fix wrong json object mapper configuration * Release v10.0.4
1 parent 8438e3e commit fbded7b

File tree

6 files changed

+24
-18
lines changed

6 files changed

+24
-18
lines changed

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# commercetools sync java
33
[![CI](https://github.com/commercetools/commercetools-sync-java/workflows/CI/badge.svg)](https://github.com/commercetools/commercetools-sync-java/actions?query=workflow%3ACI)
44
[![codecov](https://codecov.io/gh/commercetools/commercetools-sync-java/branch/master/graph/badge.svg)](https://codecov.io/gh/commercetools/commercetools-sync-java)
5-
[![Javadoc](https://javadoc.io/badge2/com.commercetools/commercetools-sync-java/javadoc.svg?label=Javadoc)](https://commercetools.github.io/commercetools-sync-java/v/10.0.3/)
5+
[![Javadoc](https://javadoc.io/badge2/com.commercetools/commercetools-sync-java/javadoc.svg?label=Javadoc)](https://commercetools.github.io/commercetools-sync-java/v/10.0.4/)
66
[![Known Vulnerabilities](https://snyk.io/test/github/commercetools/commercetools-sync-java/4b2e26113d591bda158217c5dc1cf80a88665646/badge.svg)](https://snyk.io/test/github/commercetools/commercetools-sync-java/4b2e26113d591bda158217c5dc1cf80a88665646)
77

88

@@ -60,26 +60,26 @@ Here are the most popular ones:
6060
<dependency>
6161
<groupId>com.commercetools</groupId>
6262
<artifactId>commercetools-sync-java</artifactId>
63-
<version>10.0.3</version>
63+
<version>10.0.4</version>
6464
</dependency>
6565
````
6666

6767
#### Gradle
6868

6969
````groovy
70-
implementation 'com.commercetools:commercetools-sync-java:10.0.3'
70+
implementation 'com.commercetools:commercetools-sync-java:10.0.4'
7171
````
7272

7373
#### SBT
7474

7575
````
76-
libraryDependencies += "com.commercetools" % "commercetools-sync-java" % "10.0.3"
76+
libraryDependencies += "com.commercetools" % "commercetools-sync-java" % "10.0.4"
7777
````
7878

7979
#### Ivy
8080

8181
````xml
82-
<dependency org="com.commercetools" name="commercetools-sync-java" rev="10.0.3"/>
82+
<dependency org="com.commercetools" name="commercetools-sync-java" rev="10.0.4"/>
8383
````
8484

8585
**Note**: To avoid `commercetools JVM SDK` libraries version mismatch between projects.

docs/README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
# commercetools sync
33
[![CI](https://github.com/commercetools/commercetools-sync-java/workflows/CI/badge.svg)](https://github.com/commercetools/commercetools-sync-java/actions?query=workflow%3ACI)
44
[![codecov](https://codecov.io/gh/commercetools/commercetools-sync-java/branch/master/graph/badge.svg)](https://codecov.io/gh/commercetools/commercetools-sync-java)
5-
[![Benchmarks 10.0.3](https://img.shields.io/badge/Benchmarks-10.0.3-orange.svg)](https://commercetools.github.io/commercetools-sync-java/benchmarks/)
6-
[![Download from Maven Central](https://img.shields.io/badge/Maven_Central-10.0.3-blue.svg)](https://search.maven.org/artifact/com.commercetools/commercetools-sync-java/10.0.3/jar)
7-
[![Javadoc](https://javadoc.io/badge2/com.commercetools/commercetools-sync-java/javadoc.svg?label=Javadoc)](https://commercetools.github.io/commercetools-sync-java/v/10.0.3/)
5+
[![Benchmarks 10.0.4](https://img.shields.io/badge/Benchmarks-10.0.4-orange.svg)](https://commercetools.github.io/commercetools-sync-java/benchmarks/)
6+
[![Download from Maven Central](https://img.shields.io/badge/Maven_Central-10.0.4-blue.svg)](https://search.maven.org/artifact/com.commercetools/commercetools-sync-java/10.0.4/jar)
7+
[![Javadoc](https://javadoc.io/badge2/com.commercetools/commercetools-sync-java/javadoc.svg?label=Javadoc)](https://commercetools.github.io/commercetools-sync-java/v/10.0.4/)
88
[![Known Vulnerabilities](https://snyk.io/test/github/commercetools/commercetools-sync-java/4b2e26113d591bda158217c5dc1cf80a88665646/badge.svg)](https://snyk.io/test/github/commercetools/commercetools-sync-java/4b2e26113d591bda158217c5dc1cf80a88665646)
99

1010

@@ -40,18 +40,18 @@ Here are the most popular ones:
4040
<dependency>
4141
<groupId>com.commercetools</groupId>
4242
<artifactId>commercetools-sync-java</artifactId>
43-
<version>10.0.3</version>
43+
<version>10.0.4</version>
4444
</dependency>
4545
````
4646
#### Gradle
4747
````groovy
48-
implementation 'com.commercetools:commercetools-sync-java:10.0.3'
48+
implementation 'com.commercetools:commercetools-sync-java:10.0.4'
4949
````
5050
#### SBT
5151
````
52-
libraryDependencies += "com.commercetools" % "commercetools-sync-java" % "10.0.3"
52+
libraryDependencies += "com.commercetools" % "commercetools-sync-java" % "10.0.4"
5353
````
5454
#### Ivy
5555
````xml
56-
<dependency org="com.commercetools" name="commercetools-sync-java" rev="10.0.3"/>
56+
<dependency org="com.commercetools" name="commercetools-sync-java" rev="10.0.4"/>
5757
````

docs/RELEASE_NOTES.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,13 @@
2727
7. Add Migration guide section which specifies explicitly if there are breaking changes and how to tackle them.
2828
-->
2929

30+
### 10.0.4 - Jan 9, 2024
31+
[Commits](https://github.com/commercetools/commercetools-sync-java/compare/10.0.3...10.0.4) |
32+
[Javadoc](https://commercetools.github.io/commercetools-sync-java/v/10.0.4/) |
33+
[Jar](https://search.maven.org/artifact/com.commercetools/commercetools-sync-java/10.0.4/jar)
34+
- 🐞 **Bug Fixes** (1)
35+
- Fix getting a wrong JSON Object mapper (https://github.com/commercetools/commercetools-sync-java/issues/1138)
36+
3037
### 10.0.3 - Dec 21, 2023
3138
[Commits](https://github.com/commercetools/commercetools-sync-java/compare/10.0.2...10.0.3) |
3239
[Javadoc](https://commercetools.github.io/commercetools-sync-java/v/10.0.3/) |

docs/usage/QUICK_START.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@
2020
<dependency>
2121
<groupId>com.commercetools</groupId>
2222
<artifactId>commercetools-sync-java</artifactId>
23-
<version>10.0.3</version>
23+
<version>10.0.4</version>
2424
</dependency>
2525
````
2626
- For Gradle users:
2727
````groovy
2828
// Add commercetools-sync-java dependency.
29-
implementation 'com.commercetools:commercetools-sync-java:10.0.3'
29+
implementation 'com.commercetools:commercetools-sync-java:10.0.4'
3030
````
3131

3232
### 2. Setup Syncing Options

src/main/java/com/commercetools/sync/services/impl/BaseService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ public CompletionStage<Map<String, String>> cacheKeysToIdsUsingGraphQl(
148148
.filter(Objects::nonNull)
149149
.forEach(
150150
data -> {
151-
ObjectMapper objectMapper = JsonUtils.getConfiguredObjectMapper();
151+
final ObjectMapper objectMapper = JsonUtils.getConfiguredObjectMapper();
152152
final JsonNode jsonNode = objectMapper.convertValue(data, JsonNode.class);
153153
final Iterator<JsonNode> elements =
154154
jsonNode.get(queryResource.getName()).get("results").elements();

src/main/java/com/commercetools/sync/services/impl/UnresolvedReferencesServiceImpl.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
import com.commercetools.sync.commons.models.WaitingToBeResolved;
1515
import com.commercetools.sync.commons.utils.ChunkUtils;
1616
import com.commercetools.sync.services.UnresolvedReferencesService;
17-
import com.fasterxml.jackson.databind.DeserializationFeature;
1817
import com.fasterxml.jackson.databind.ObjectMapper;
18+
import io.vrap.rmf.base.client.utils.json.JsonUtils;
1919
import java.util.Collections;
2020
import java.util.List;
2121
import java.util.Optional;
@@ -31,8 +31,7 @@ public class UnresolvedReferencesServiceImpl<WaitingToBeResolvedT extends Waitin
3131

3232
private final BaseSyncOptions syncOptions;
3333

34-
private static final ObjectMapper OBJECT_MAPPER =
35-
new ObjectMapper().configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
34+
private static final ObjectMapper OBJECT_MAPPER = JsonUtils.getConfiguredObjectMapper();
3635

3736
private static final String SAVE_FAILED =
3837
"Failed to save CustomObject with key: '%s' (hash of product key: '%s').";

0 commit comments

Comments
 (0)