-
Notifications
You must be signed in to change notification settings - Fork 29
CRAFT- 2018- trusted pub switch #3900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3900 +/- ##
=======================================
Coverage 75.10% 75.10%
=======================================
Files 259 259
Lines 6382 6382
Branches 1992 2026 +34
=======================================
Hits 4793 4793
Misses 1567 1567
Partials 22 22
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ByronDWall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. The only suggestion I have is that it is probably worth adding an explanatory comment at the top of the file outlining what is happening and why it's necessary.
Npm trusted publishing (OIDC) allows only one workflow to be configured as a trusted publisher, however appkit has 3 publishing scenarios spanning 2 workflows:
publish-release)publish-release)preview-release-on-comment)Using this blog as an example, we will implement a reusable workflow pattern where
release.ymlserves as the single entry point (trusted publisher) and routes to separate publishing workflows based on the event type.outstanding:verify if permissions are needed on the parent level and/or re-declaredcreate description for release.yml processNote that this broke all publishing, but corrected with #3903
other references:
https://docs.npmjs.com/trusted-publishers