Merge pull request #1629 from commercetools/fix_lint_issue

small linter fixes

Author: jenschude

packages/sdk-middleware-http/src/http.js

@@ -92,7 +92,7 @@ export default function createHttpMiddleware({
     request: MiddlewareRequest,
     response: MiddlewareResponse
   ) => {
-    let abortController
+    let abortController: any
     if (timeout || getAbortController || _abortController)
       // eslint-disable-next-line
       abortController = (getAbortController ? getAbortController(): null) || _abortController || new AbortController()
@@ -120,7 +120,7 @@ export default function createHttpMiddleware({
     if (credentialsMode) {
       fetchOptions.credentials = credentialsMode
     }
-    if (timeout || abortController) {
+    if (abortController) {
       fetchOptions.signal = abortController.signal
     }
     if (body) {

packages/sdk-middleware-http/test/http.spec.js

@@ -104,7 +104,7 @@ describe('Http', () => {
 
   test('execute a get request with getAbortController timeout (success)', () => {
     expect.assertions(1)
-    new Promise((resolve, reject) => {
+    return new Promise((resolve, reject) => {
       const request = createTestRequest({
         uri: '/foo/bar',
       })
@@ -133,7 +133,8 @@ describe('Http', () => {
         .reply(200, { foo: 'bar' })
 
       httpMiddleware(next)(request, response)
-    })})
+    })
+  })
 
   test('execute a get request with short timeout (fail)', () =>
     new Promise((resolve, reject) => {
@@ -198,7 +199,8 @@ describe('Http', () => {
         .reply(200, { foo: 'bar' })
 
       httpMiddleware(next)(request, response)
-    })})
+    })
+  })
 
   test('execute a request with timeout and client re-use', () =>
     new Promise((resolve, reject) => {