Merge pull request #1594 from commercetools/fix-empty-categoryOrderHints

test(sync-actions): add test for empty categoryOrderHints

Author: markus-azer

packages/sync-actions/src/product-actions.js

@@ -490,6 +490,8 @@ export function actionsMapCategories(diff) {
 
 export function actionsMapCategoryOrderHints(diff) {
   if (!diff.categoryOrderHints) return []
+  // Ignore this pattern as its means no changes happened [{},0,0]
+  if (Array.isArray(diff.categoryOrderHints)) return []
 
   return Object.keys(diff.categoryOrderHints).map((categoryId) => {
     const hintChange = diff.categoryOrderHints[categoryId]

packages/sync-actions/test/product-sync-base.spec.js

@@ -288,6 +288,30 @@ describe('Actions', () => {
     ])
   })
 
+  test('shouldnt generate any categoryOrderHints actions', () => {
+    const before = {
+      categoryOrderHints: {},
+    }
+
+    const now = {}
+
+    const actions = productsSync.buildActions(now, before)
+
+    expect(actions).toEqual([])
+  })
+
+  test('shouldnt generate any searchKeywords actions', () => {
+    const before = {
+      searchKeywords: {},
+    }
+
+    const now = {}
+
+    const actions = productsSync.buildActions(now, before)
+
+    expect(actions).toEqual([])
+  })
+
   test('should build base actions for long diff text', () => {
     const longText = `
     Lorem ipsum dolor sit amet, consectetur adipiscing elit.